openstack/tempest
Code Issues Proposed changes

Use create_volume wrapper instead of volumes_client

Browse Source 
The create_volume wrapper already includes cleanup, waiting for a
status, and makes use of provided configuration options.

Change-Id: I30d910422f4f51cd7b7f634aed48626b478f384a
This commit is contained in:
Jimmy McCrory 2025-03-28 12:09:23 -07:00
parent 80c0477f78
commit 94582b45d5
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tempest/api/volume/test_volumes_get.py
View File

@ -18,7 +18,6 @@ from testtools import matchers
from tempest.api.volume import base
from tempest.common import utils
from tempest.common import waiters
from tempest import config
from tempest.lib.common.utils import data_utils
from tempest.lib import decorators
@ -38,10 +37,7 @@ class VolumesGetTest(base.BaseVolumeTest):
# Create a volume
kwargs['name'] = v_name
kwargs['metadata'] = metadata
volume = self.volumes_client.create_volume(**kwargs)['volume']
self.addCleanup(self.delete_volume, self.volumes_client, volume['id'])
waiters.wait_for_volume_resource_status(self.volumes_client,
volume['id'], 'available')
volume = self.create_volume(wait_until='available', **kwargs)
self.assertEqual(volume['name'], v_name,
"The created volume name is not equal "
"to the requested name")
@ -103,11 +99,7 @@ class VolumesGetTest(base.BaseVolumeTest):
params = {'description': new_v_desc,
'availability_zone': volume['availability_zone'],
'size': CONF.volume.volume_size}
new_volume = self.volumes_client.create_volume(**params)['volume']
self.addCleanup(self.delete_volume, self.volumes_client,
new_volume['id'])
waiters.wait_for_volume_resource_status(self.volumes_client,
new_volume['id'], 'available')
new_volume = self.create_volume(wait_until='available', **params)
params = {'name': volume['name'],
'description': volume['description']}