openstack/tempest
Code Issues Proposed changes

Merge "Make v3 update_role use **kwargs & doc string"

Browse Source
This commit is contained in:
Jenkins 2015-12-25 06:48:00 +00:00 committed by Gerrit Code Review
commit 99da10d2e1
2 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tempest/api/identity/admin/v3/test_roles.py
View File

@ -75,7 +75,8 @@ class RolesV3TestJSON(base.BaseIdentityV3AdminTest):
self.assertEqual(role['name'], r_name)
new_name = data_utils.rand_name('NewRole')
updated_role = self.client.update_role(new_name, role['id'])['role']
updated_role = self.client.update_role(role['id'],
name=new_name)['role']
self.assertIn('name', updated_role)
self.assertIn('id', updated_role)
self.assertIn('links', updated_role)

13
tempest/services/identity/v3/json/identity_client.py
View File

@ -206,12 +206,13 @@ class IdentityV3Client(service_client.ServiceClient):
body = json.loads(body)
return service_client.ResponseBody(resp, body)
def update_role(self, name, role_id):
"""Create a Role."""
post_body = {
'name': name
}
post_body = json.dumps({'role': post_body})
def update_role(self, role_id, **kwargs):
"""Update a Role.
Available params: see http://developer.openstack.org/
api-ref-identity-v3.html#updateRole
"""
post_body = json.dumps({'role': kwargs})
resp, body = self.patch('roles/%s' % str(role_id), post_body)
self.expected_success(200, resp.status)
body = json.loads(body)