From bf5ed0b676b634af156b313e333a8f37e396b98c Mon Sep 17 00:00:00 2001 From: zhufl Date: Wed, 18 Nov 2020 15:34:25 +0800 Subject: [PATCH] [Trivial]Remove unused variables and methods This is to remove unused variables and methods to keep code clean. Change-Id: Ib0b1e6ecb23481103791b065a622b4b89190412e --- .../identity/admin/v3/test_application_credentials.py | 2 +- .../api/identity/v3/test_application_credentials.py | 2 +- tempest/api/network/test_floating_ips.py | 2 +- tempest/api/object_storage/test_container_sync.py | 2 +- tempest/api/object_storage/test_crossdomain.py | 3 --- tempest/api/object_storage/test_healthcheck.py | 3 --- tempest/api/object_storage/test_object_services.py | 10 +++++----- tempest/api/object_storage/test_object_slo.py | 2 +- 8 files changed, 10 insertions(+), 16 deletions(-) diff --git a/tempest/api/identity/admin/v3/test_application_credentials.py b/tempest/api/identity/admin/v3/test_application_credentials.py index c9cafd82a5..f5b0356cdf 100644 --- a/tempest/api/identity/admin/v3/test_application_credentials.py +++ b/tempest/api/identity/admin/v3/test_application_credentials.py @@ -37,7 +37,7 @@ class ApplicationCredentialsV3AdminTest(base.BaseApplicationCredentialsV3Test, secret = app_cred['secret'] # Check that the application credential is functional - token_id, resp = self.non_admin_token.get_token( + _, resp = self.non_admin_token.get_token( app_cred_id=app_cred['id'], app_cred_secret=secret, auth_data=True diff --git a/tempest/api/identity/v3/test_application_credentials.py b/tempest/api/identity/v3/test_application_credentials.py index 77ad720389..06734aa638 100644 --- a/tempest/api/identity/v3/test_application_credentials.py +++ b/tempest/api/identity/v3/test_application_credentials.py @@ -51,7 +51,7 @@ class ApplicationCredentialsV3Test(base.BaseApplicationCredentialsV3Test): self.assertNotIn('secret', app_cred) # Check that the application credential is functional - token_id, resp = self.non_admin_token.get_token( + _, resp = self.non_admin_token.get_token( app_cred_id=app_cred['id'], app_cred_secret=secret, auth_data=True diff --git a/tempest/api/network/test_floating_ips.py b/tempest/api/network/test_floating_ips.py index c32d3c1075..eb31d244d8 100644 --- a/tempest/api/network/test_floating_ips.py +++ b/tempest/api/network/test_floating_ips.py @@ -66,7 +66,7 @@ class FloatingIPTestJSON(base.BaseNetworkTest): cls.create_router_interface(cls.router['id'], cls.subnet['id']) # Create two ports one each for Creation and Updating of floatingIP cls.ports = [] - for i in range(2): + for _ in range(2): port = cls.create_port(cls.network) cls.ports.append(port) diff --git a/tempest/api/object_storage/test_container_sync.py b/tempest/api/object_storage/test_container_sync.py index c5334a9b66..eb2ef7ff42 100644 --- a/tempest/api/object_storage/test_container_sync.py +++ b/tempest/api/object_storage/test_container_sync.py @@ -92,7 +92,7 @@ class ContainerSyncTest(base.BaseObjectTest): # create object in container object_name = data_utils.rand_name(name='TestSyncObject') data = object_name[::-1].encode() # Raw data, we need bytes - resp, _ = obj_client[0].create_object(cont[0], object_name, data) + obj_client[0].create_object(cont[0], object_name, data) self.objects.append(object_name) # wait until container contents list is not empty diff --git a/tempest/api/object_storage/test_crossdomain.py b/tempest/api/object_storage/test_crossdomain.py index c611ed6ba6..365dc78f8e 100644 --- a/tempest/api/object_storage/test_crossdomain.py +++ b/tempest/api/object_storage/test_crossdomain.py @@ -32,9 +32,6 @@ class CrossdomainTest(base.BaseObjectTest): cls.xml_end = "" - def setUp(self): - super(CrossdomainTest, self).setUp() - @decorators.idempotent_id('d1b8b031-b622-4010-82f9-ff78a9e915c7') @utils.requires_ext(extension='crossdomain', service='object') def test_get_crossdomain_policy(self): diff --git a/tempest/api/object_storage/test_healthcheck.py b/tempest/api/object_storage/test_healthcheck.py index f5e2443b55..d4a6a9f2d4 100644 --- a/tempest/api/object_storage/test_healthcheck.py +++ b/tempest/api/object_storage/test_healthcheck.py @@ -21,9 +21,6 @@ from tempest.lib import decorators class HealthcheckTest(base.BaseObjectTest): """Test healthcheck""" - def setUp(self): - super(HealthcheckTest, self).setUp() - @decorators.idempotent_id('db5723b1-f25c-49a9-bfeb-7b5640caf337') def test_get_healthcheck(self): """Test getting healthcheck""" diff --git a/tempest/api/object_storage/test_object_services.py b/tempest/api/object_storage/test_object_services.py index 4ecbcad2c1..be13ed771e 100644 --- a/tempest/api/object_storage/test_object_services.py +++ b/tempest/api/object_storage/test_object_services.py @@ -770,11 +770,11 @@ class ObjectTest(base.BaseObjectTest): headers = {} headers['X-Copy-From'] = "%s/%s" % (str(self.container_name), str(object_name)) - resp, body = self.object_client.create_object(self.container_name, - object_name, - data=None, - metadata=metadata, - headers=headers) + resp, _ = self.object_client.create_object(self.container_name, + object_name, + data=None, + metadata=metadata, + headers=headers) self.assertHeaders(resp, 'Object', 'PUT') # check the content type diff --git a/tempest/api/object_storage/test_object_slo.py b/tempest/api/object_storage/test_object_slo.py index 7e553caf30..664bbc8e23 100644 --- a/tempest/api/object_storage/test_object_slo.py +++ b/tempest/api/object_storage/test_object_slo.py @@ -165,6 +165,6 @@ class ObjectSloTest(base.BaseObjectTest): self.assertHeaders(resp, 'Object', 'DELETE') - resp, body = self.container_client.list_container_objects( + resp, _ = self.container_client.list_container_objects( self.container_name) self.assertEqual(int(resp['x-container-object-count']), 0)