openstack/tempest
Code Issues Proposed changes

Add noqa support to no_setupclass_for_unit_tests

Browse Source 
This commit adds support for using noqa with the T105 hacking check.
This is need to unit test the _find_caller() utility with setupClass
in the call stack.

Change-Id: I5c1a07d019b79b082cb895a17364f7e7cb2f08fe
This commit is contained in:
Matthew Treinish 2014-05-02 18:50:16 -04:00
parent c5dd40b5b2
commit aaa3595549
2 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tempest/hacking/checks.py
View File

@ -15,6 +15,8 @@
import os
import re
import pep8
PYTHON_CLIENTS = ['cinder', 'glance', 'keystone', 'nova', 'swift', 'neutron',
'trove', 'ironic', 'savanna', 'heat', 'ceilometer',
@ -56,6 +58,10 @@ def scenario_tests_need_service_tags(physical_line, filename,
def no_setupclass_for_unit_tests(physical_line, filename):
if pep8.noqa(physical_line):
return
if 'tempest/tests' in filename:
if SETUPCLASS_DEFINITION.match(physical_line):
return (physical_line.find('def'),

26
tempest/tests/test_hacking.py Normal file
View File

@ -0,0 +1,26 @@
# Copyright 2014 Matthew Treinish
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from tempest.hacking import checks
from tempest.tests import base
class HackingTestCase(base.TestCase):
def test_no_setupclass_for_unit_tests(self):
self.assertTrue(checks.no_setupclass_for_unit_tests(
" def setUpClass(cls):", './tempest/tests/fake_test.py'))
self.assertIsNone(checks.no_setupclass_for_unit_tests(
" def setUpClass(cls): # noqa", './tempest/tests/fake_test.py'))
self.assertFalse(checks.no_setupclass_for_unit_tests(
" def setUpClass(cls):", './tempest/api/fake_test.py'))