openstack
/
tempest
Code Issues Proposed changes

Remove unnecessary tags/attributes from our tests 

Remove the following tags/attributes from our tests:
S3, EC2, slow, bug=lp912922, bug='lp1170718',
category='server-addresses', category='live-migration',
nagative, type='regression'

Now, we are left with:

Tag                   Total # of instances
--------------------  --------------------
'NO TAG'              192
gate                  62
negative              172
positive              110
smoke                 89
whitebox              2

Attribute             Total # of instances
--------------------  --------------------
type                  408

Change-Id: Idab48a7e1a53a3d64fb57ae3cd3975d665180aeb
This commit is contained in:
Giampaolo Lauria 2013-05-17 13:39:25 -04:00
parent 1937d09fb0
commit cb9209ddf0
13 changed files with 8 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tempest/api/compute/flavors/test_flavors.py
View File

@ -56,14 +56,14 @@ class FlavorsTestJSON(base.BaseComputeTest):
self.assertRaises(exceptions.NotFound, self.client.get_flavor_details,
999)
@attr(type='positive', bug='lp912922')
@attr(type='positive')
def test_list_flavors_limit_results(self):
# Only the expected number of flavors should be returned
params = {'limit': 1}
resp, flavors = self.client.list_flavors(params)
self.assertEqual(1, len(flavors))
@attr(type='positive', bug='lp912922')
@attr(type='positive')
def test_list_flavors_detailed_limit_results(self):
# Only the expected number of flavors (detailed) should be returned
params = {'limit': 1}

2
tempest/api/compute/servers/test_list_server_filters.py
View File

@ -205,7 +205,7 @@ class ListServerFiltersTestJSON(base.BaseComputeTest):
self.assertNotIn(self.s3_name, map(lambda x: x['name'], servers))
@testtools.skip('Until Bug #1170718 is resolved.')
@attr(type='positive', bug='lp1170718')
@attr(type='positive')
def test_list_servers_filtered_by_ip(self):
# Filter servers by ip
# Here should be listed 1 server

8
tempest/api/compute/servers/test_server_addresses.py
View File

@ -30,20 +30,20 @@ class ServerAddressesTest(base.BaseComputeTest):
resp, cls.server = cls.create_server(wait_until='ACTIVE')
@attr(type='negative', category='server-addresses')
@attr(type='negative')
def test_list_server_addresses_invalid_server_id(self):
# List addresses request should fail if server id not in system
self.assertRaises(exceptions.NotFound, self.client.list_addresses,
'999')
@attr(type='negative', category='server-addresses')
@attr(type='negative')
def test_list_server_addresses_by_network_neg(self):
# List addresses by network should fail if network name not valid
self.assertRaises(exceptions.NotFound,
self.client.list_addresses_by_network,
self.server['id'], 'invalid')
@attr(type='smoke', category='server-addresses')
@attr(type='smoke')
def test_list_server_addresses(self):
# All public and private addresses for
# a server should be returned
@ -60,7 +60,7 @@ class ServerAddressesTest(base.BaseComputeTest):
self.assertTrue(address['addr'])
self.assertTrue(address['version'])
@attr(type='smoke', category='server-addresses')
@attr(type='smoke')
def test_list_server_addresses_by_network(self):
# Providing a network type should filter
# the addresses return by that type

1
tempest/api/compute/test_live_block_migration.py
View File

@ -26,7 +26,6 @@ from tempest import exceptions
from tempest.test import attr
@attr(category='live-migration')
class LiveBlockMigrationTestJSON(base.BaseComputeAdminTest):
_host_key = 'OS-EXT-SRV-ATTR:host'
_interface = 'json'

2
tempest/api/object_storage/test_object_expiry.py
View File

@ -23,7 +23,6 @@ from tempest.api.object_storage import base
from tempest.common.utils.data_utils import arbitrary_string
from tempest.common.utils.data_utils import rand_name
from tempest import exceptions
from tempest.test import attr
class ObjectExpiryTest(base.BaseObjectTest):
@ -51,7 +50,6 @@ class ObjectExpiryTest(base.BaseObjectTest):
resp, _ = cls.container_client.delete_container(cls.container_name)
@testtools.skip('Until Bug #1069849 is resolved.')
@attr(type='regression')
def test_get_object_after_expiry_time(self):
#TODO(harika-vakadi): similar test case has to be created for
# "X-Delete-At", after this test case works.

3
tempest/thirdparty/boto/test_ec2_instance_run.py vendored
View File

@ -33,7 +33,6 @@ from tempest.thirdparty.boto.utils.wait import state_wait
LOG = logging.getLogger(__name__)
@attr("S3", "EC2")
class InstanceRunTest(BotoTestCase):
@classmethod
@ -141,7 +140,7 @@ class InstanceRunTest(BotoTestCase):
#NOTE(afazekas): doctored test case,
# with normal validation it would fail
@attr("slow", type='smoke')
@attr(type='smoke')
def test_integration_1(self):
# EC2 1. integration test (not strict)
image_ami = self.ec2_client.get_image(self.images["ami"]["image_id"])

1
tempest/thirdparty/boto/test_ec2_keys.py vendored
View File

@ -28,7 +28,6 @@ def compare_key_pairs(a, b):
a.fingerprint == b.fingerprint)
@attr("EC2")
class EC2KeysTest(BotoTestCase):
@classmethod

1
tempest/thirdparty/boto/test_ec2_network.py vendored
View File

@ -22,7 +22,6 @@ from tempest.test import attr
from tempest.thirdparty.boto.test import BotoTestCase
@attr("EC2")
class EC2NetworkTest(BotoTestCase):
@classmethod

1
tempest/thirdparty/boto/test_ec2_security_groups.py vendored
View File

@ -21,7 +21,6 @@ from tempest.test import attr
from tempest.thirdparty.boto.test import BotoTestCase
@attr("EC2")
class EC2SecurityGroupTest(BotoTestCase):
@classmethod

1
tempest/thirdparty/boto/test_ec2_volumes.py vendored
View File

@ -29,7 +29,6 @@ def compare_volumes(a, b):
a.size == b.size)
@attr("EC2")
class EC2VolumesTest(BotoTestCase):
@classmethod

1
tempest/thirdparty/boto/test_s3_buckets.py vendored
View File

@ -23,7 +23,6 @@ from tempest.test import attr
from tempest.thirdparty.boto.test import BotoTestCase
@attr("S3")
class S3BucketsTest(BotoTestCase):
@classmethod

1
tempest/thirdparty/boto/test_s3_ec2_images.py vendored
View File

@ -27,7 +27,6 @@ from tempest.thirdparty.boto.utils.s3 import s3_upload_dir
from tempest.thirdparty.boto.utils.wait import state_wait
@attr("S3", "EC2")
class S3ImagesTest(BotoTestCase):
@classmethod

1
tempest/thirdparty/boto/test_s3_objects.py vendored
View File

@ -25,7 +25,6 @@ from tempest.test import attr
from tempest.thirdparty.boto.test import BotoTestCase
@attr("S3")
class S3BucketsTest(BotoTestCase):
@classmethod