openstack/tempest
Code Issues Proposed changes

Make _create_loginable_secgroup_rule non-private

Browse Source 
_create_loginable_secgroup_rule() is currently private
which is not necessarily required to be private

Implements: blueprint tempest-scenario-manager-stable
Signed-off by: Soniya Vyas<svyas@redhat.com>

Change-Id: Ice42441874bdbc8f58eb2a07320eb484b8780502
This commit is contained in:
Soniya Vyas 2021-02-04 19:35:10 +05:30
parent ccf56b5ca2
commit cb95bba849
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
releasenotes/notes/create_loginable_secgroup_rule-73722fd4b4eb12d0.yaml Normal file
View File

@ -0,0 +1,6 @@
---
features:
- |
Added public interface create_loginable_secgroup_rule().
Since this interface is meant to be used by tempest plugins,
It doesn't neccessarily require to be private api.

12
tempest/scenario/manager.py
View File

@ -515,7 +515,7 @@ class ScenarioTest(tempest.test.BaseTestCase):
self.addCleanup(self._cleanup_volume_type, volume_type)
return volume_type
def _create_loginable_secgroup_rule(self, secgroup_id=None, rulesets=None):
def create_loginable_secgroup_rule(self, secgroup_id=None, rulesets=None):
"""Create loginable security group rule by compute clients.
This function will create by default the following rules:
@ -575,7 +575,7 @@ class ScenarioTest(tempest.test.BaseTestCase):
secgroup['id'])
# Add rules to the security group
self._create_loginable_secgroup_rule(secgroup['id'])
self.create_loginable_secgroup_rule(secgroup['id'])
return secgroup
def get_remote_client(self, ip_address, username=None, private_key=None,
@ -1346,7 +1346,7 @@ class NetworkScenarioTest(ScenarioTest):
project_id=project_id)
# Add rules to the security group
rules = self._create_loginable_secgroup_rule(
rules = self.create_loginable_secgroup_rule(
security_group_rules_client=security_group_rules_client,
secgroup=secgroup,
security_groups_client=security_groups_client)
@ -1435,9 +1435,9 @@ class NetworkScenarioTest(ScenarioTest):
return sg_rule
def _create_loginable_secgroup_rule(self, security_group_rules_client=None,
secgroup=None,
security_groups_client=None):
def create_loginable_secgroup_rule(self, security_group_rules_client=None,
secgroup=None,
security_groups_client=None):
"""Create loginable security group rule by neutron clients by default.
This function will create: