From d99030ee6c0758b72f2a15ff19f17fa8fcd9d1d4 Mon Sep 17 00:00:00 2001 From: whoami-rajat Date: Wed, 4 Jul 2018 04:06:38 +0000 Subject: [PATCH] Adding additional assertions for retype test This commit fixes the review comment of https://review.openstack.org/#/c/572287/ to add extra checks for destination volume type Change-Id: Ie0f4bd7e69f83e83846e5e281c7bd121c584992e --- tempest/api/volume/admin/test_volume_retype.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tempest/api/volume/admin/test_volume_retype.py b/tempest/api/volume/admin/test_volume_retype.py index 423104b3a8..1c56eb2517 100644 --- a/tempest/api/volume/admin/test_volume_retype.py +++ b/tempest/api/volume/admin/test_volume_retype.py @@ -130,6 +130,8 @@ class VolumeRetypeWithMigrationTest(VolumeRetypeTest): for key in keys_with_change: self.assertNotEqual(volume_source[key], volume_dest[key]) + self.assertEqual(volume_dest['volume_type'], self.dst_vol_type['name']) + @decorators.idempotent_id('a1a41f3f-9dad-493e-9f09-3ff197d477cd') def test_available_volume_retype_with_migration(self): src_vol = self.create_volume(volume_type=self.src_vol_type['name']) @@ -168,6 +170,8 @@ class VolumeRetypeWithoutMigrationTest(VolumeRetypeTest): for key in keys_with_change: self.assertNotEqual(volume_source[key], volume_dest[key]) + self.assertEqual(volume_dest['volume_type'], self.dst_vol_type['name']) + @decorators.idempotent_id('b90412ee-465d-46e9-b249-ec84a47d5f25') def test_available_volume_retype(self): src_vol = self.create_volume(volume_type=self.src_vol_type['name'])