openstack
/
tempest
Code Issues Proposed changes

[V3] Rename get_credential to show_credential 

[GET /resources] methods should be "list_<resource name>s"
or "show_<resource name>", so this patch applies the rule
to credentials client.

Partially implements blueprint consistent-service-method-names

Change-Id: I07c4403e42d6f2c7617f455a8a4f292ff10e7059
This commit is contained in:
lei zhang 2015-11-28 22:51:36 +08:00
parent 8b1603bad0
commit f7169e2924
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tempest/api/identity/admin/v3/test_credentials.py
View File

@ -76,7 +76,7 @@ class CredentialsTestJSON(base.BaseIdentityV3AdminTest):
self.assertEqual(update_body['blob']['access'], new_keys[0])
self.assertEqual(update_body['blob']['secret'], new_keys[1])
get_body = self.creds_client.get_credential(cred['id'])['credential']
get_body = self.creds_client.show_credential(cred['id'])['credential']
for value1 in self.creds_list[0]:
self.assertEqual(update_body[value1],
get_body[value1])

1
tempest/hacking/ignored_list_T110.txt
View File

@ -1,5 +1,4 @@
./tempest/services/database/json/flavors_client.py
./tempest/services/identity/v3/json/credentials_client.py
./tempest/services/identity/v3/json/identity_client.py
./tempest/services/identity/v3/json/policy_client.py
./tempest/services/identity/v3/json/region_client.py

2
tempest/services/identity/v3/json/credentials_client.py
View File

@ -51,7 +51,7 @@ class CredentialsClient(service_client.ServiceClient):
body['credential']['blob'] = json.loads(body['credential']['blob'])
return service_client.ResponseBody(resp, body)
def get_credential(self, credential_id):
def show_credential(self, credential_id):
"""To GET Details of a credential."""
resp, body = self.get('credentials/%s' % credential_id)
self.expected_success(200, resp.status)