8827d38b98
TestInterfaceWaiters test case were not verifyinf the main waiters functionality and sometime they could intermittently fail without reason like seen in below openstack-tox-py27 Zuul check. https://review.openstack.org/#/c/559069/33 Solve tests methods failure when time.time() returns two consecutive floats that rounded by int() function is returning two different integers. This patch also verify the condition verification method are properly called and that waiters methods actually returns expected part of returned body. Change-Id: I0a2081d823b304d58a5a69a8965858bd4f1303a0
151 lines
6.4 KiB
Python
151 lines
6.4 KiB
Python
# Copyright 2014 IBM Corp.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import time
|
|
|
|
import mock
|
|
|
|
from tempest.common import waiters
|
|
from tempest import exceptions
|
|
from tempest.lib import exceptions as lib_exc
|
|
from tempest.lib.services.volume.v2 import volumes_client
|
|
from tempest.tests import base
|
|
import tempest.tests.utils as utils
|
|
|
|
|
|
class TestImageWaiters(base.TestCase):
|
|
def setUp(self):
|
|
super(TestImageWaiters, self).setUp()
|
|
self.client = mock.MagicMock()
|
|
self.client.build_timeout = 1
|
|
self.client.build_interval = 1
|
|
|
|
def test_wait_for_image_status(self):
|
|
self.client.show_image.return_value = ({'status': 'active'})
|
|
start_time = int(time.time())
|
|
waiters.wait_for_image_status(self.client, 'fake_image_id', 'active')
|
|
end_time = int(time.time())
|
|
# Ensure waiter returns before build_timeout
|
|
self.assertLess((end_time - start_time), 10)
|
|
|
|
def test_wait_for_image_status_timeout(self):
|
|
time_mock = self.patch('time.time')
|
|
time_mock.side_effect = utils.generate_timeout_series(1)
|
|
|
|
self.client.show_image.return_value = ({'status': 'saving'})
|
|
self.assertRaises(lib_exc.TimeoutException,
|
|
waiters.wait_for_image_status,
|
|
self.client, 'fake_image_id', 'active')
|
|
|
|
def test_wait_for_image_status_error_on_image_create(self):
|
|
self.client.show_image.return_value = ({'status': 'ERROR'})
|
|
self.assertRaises(exceptions.AddImageException,
|
|
waiters.wait_for_image_status,
|
|
self.client, 'fake_image_id', 'active')
|
|
|
|
@mock.patch.object(time, 'sleep')
|
|
def test_wait_for_volume_status_error_restoring(self, mock_sleep):
|
|
# Tests that the wait method raises VolumeRestoreErrorException if
|
|
# the volume status is 'error_restoring'.
|
|
client = mock.Mock(spec=volumes_client.VolumesClient,
|
|
resource_type="volume",
|
|
build_interval=1)
|
|
volume1 = {'volume': {'status': 'restoring-backup'}}
|
|
volume2 = {'volume': {'status': 'error_restoring'}}
|
|
mock_show = mock.Mock(side_effect=(volume1, volume2))
|
|
client.show_volume = mock_show
|
|
volume_id = '7532b91e-aa0a-4e06-b3e5-20c0c5ee1caa'
|
|
self.assertRaises(exceptions.VolumeRestoreErrorException,
|
|
waiters.wait_for_volume_resource_status,
|
|
client, volume_id, 'available')
|
|
mock_show.assert_has_calls([mock.call(volume_id),
|
|
mock.call(volume_id)])
|
|
mock_sleep.assert_called_once_with(1)
|
|
|
|
|
|
class TestInterfaceWaiters(base.TestCase):
|
|
|
|
build_timeout = 1.
|
|
build_interval = 1
|
|
port_down = {'interfaceAttachment': {'port_state': 'DOWN'}}
|
|
port_active = {'interfaceAttachment': {'port_state': 'ACTIVE'}}
|
|
|
|
def mock_client(self, **kwargs):
|
|
return mock.MagicMock(
|
|
build_timeout=self.build_timeout,
|
|
build_interval=self.build_interval,
|
|
**kwargs)
|
|
|
|
def test_wait_for_interface_status(self):
|
|
show_interface = mock.Mock(
|
|
side_effect=[self.port_down, self.port_active])
|
|
client = self.mock_client(show_interface=show_interface)
|
|
self.patch('time.time', return_value=0.)
|
|
sleep = self.patch('time.sleep')
|
|
|
|
result = waiters.wait_for_interface_status(
|
|
client, 'server_id', 'port_id', 'ACTIVE')
|
|
|
|
self.assertIs(self.port_active['interfaceAttachment'], result)
|
|
show_interface.assert_has_calls([mock.call('server_id', 'port_id'),
|
|
mock.call('server_id', 'port_id')])
|
|
sleep.assert_called_once_with(client.build_interval)
|
|
|
|
def test_wait_for_interface_status_timeout(self):
|
|
show_interface = mock.MagicMock(return_value=self.port_down)
|
|
client = self.mock_client(show_interface=show_interface)
|
|
self.patch('time.time', side_effect=[0., client.build_timeout + 1.])
|
|
sleep = self.patch('time.sleep')
|
|
|
|
self.assertRaises(lib_exc.TimeoutException,
|
|
waiters.wait_for_interface_status,
|
|
client, 'server_id', 'port_id', 'ACTIVE')
|
|
|
|
show_interface.assert_has_calls([mock.call('server_id', 'port_id'),
|
|
mock.call('server_id', 'port_id')])
|
|
sleep.assert_called_once_with(client.build_interval)
|
|
|
|
one_interface = {'interfaceAttachments': [{'port_id': 'port_one'}]}
|
|
two_interfaces = {'interfaceAttachments': [{'port_id': 'port_one'},
|
|
{'port_id': 'port_two'}]}
|
|
|
|
def test_wait_for_interface_detach(self):
|
|
list_interfaces = mock.MagicMock(
|
|
side_effect=[self.two_interfaces, self.one_interface])
|
|
client = self.mock_client(list_interfaces=list_interfaces)
|
|
self.patch('time.time', return_value=0.)
|
|
sleep = self.patch('time.sleep')
|
|
|
|
result = waiters.wait_for_interface_detach(
|
|
client, 'server_id', 'port_two')
|
|
|
|
self.assertIs(self.one_interface['interfaceAttachments'], result)
|
|
list_interfaces.assert_has_calls([mock.call('server_id'),
|
|
mock.call('server_id')])
|
|
sleep.assert_called_once_with(client.build_interval)
|
|
|
|
def test_wait_for_interface_detach_timeout(self):
|
|
list_interfaces = mock.MagicMock(return_value=self.one_interface)
|
|
client = self.mock_client(list_interfaces=list_interfaces)
|
|
self.patch('time.time', side_effect=[0., client.build_timeout + 1.])
|
|
sleep = self.patch('time.sleep')
|
|
|
|
self.assertRaises(lib_exc.TimeoutException,
|
|
waiters.wait_for_interface_detach,
|
|
client, 'server_id', 'port_one')
|
|
|
|
list_interfaces.assert_has_calls([mock.call('server_id'),
|
|
mock.call('server_id')])
|
|
sleep.assert_called_once_with(client.build_interval)
|