Fix ansible-lint nits

Ansible lint has become more fussy about its nit picking, blocking CI.

This change makes it happy again.

Change-Id: Ifb86c5e071697acda014bb543cab7ebf2b648dc9
This commit is contained in:
Mark Goddard 2018-12-18 17:09:54 +00:00
parent 8802ff3e0e
commit a30ac7de48
9 changed files with 82 additions and 62 deletions

View File

@ -12,6 +12,9 @@
- name: Ensure general system requirements are installed - name: Ensure general system requirements are installed
package: package:
name: "{{ system_requirements }}" name: "{{ system_requirements }}"
register: result
until: result is success
retries: 3
become: true become: true
# Don't uninstall requirements during teardown since they may already have # Don't uninstall requirements during teardown since they may already have
# been present. # been present.
@ -35,6 +38,9 @@
- name: Ensure Open vSwitch package is installed - name: Ensure Open vSwitch package is installed
package: package:
name: "{{ tenks_openvswitch_pkg_name }}" name: "{{ tenks_openvswitch_pkg_name }}"
register: result
until: result is success
retries: 3
become: true become: true
- name: Ensure Open vSwitch is started and enabled - name: Ensure Open vSwitch is started and enabled

View File

@ -22,6 +22,9 @@
extra_args: >- extra_args: >-
-c {{ ironic_python_upper_constraints_url }} -c {{ ironic_python_upper_constraints_url }}
virtualenv: "{{ ironic_virtualenv_path }}" virtualenv: "{{ ironic_virtualenv_path }}"
register: result
until: result is success
retries: 3
# This command will return the UUIDs, regardless of whether # This command will return the UUIDs, regardless of whether
# ironic_deploy_kernel and ironic_deploy_ramdisk are image UUIDs or names. # ironic_deploy_kernel and ironic_deploy_ramdisk are image UUIDs or names.
@ -36,7 +39,7 @@
# for enrolment to continue. # for enrolment to continue.
when: when:
- item is not none - item is not none
- item != "" - item | length > 0
register: deploy_image_ids register: deploy_image_ids
changed_when: false changed_when: false

View File

@ -11,7 +11,7 @@
- name: Fail if port is not found - name: Fail if port is not found
fail: fail:
msg: Ironic port with MAC address {{ mac }} not found msg: Ironic port with MAC address {{ mac }} not found
when: uuid.stdout == "" when: not uuid.stdout
- name: Get physical network name - name: Get physical network name
set_fact: set_fact:

View File

@ -5,6 +5,9 @@
extra_args: >- extra_args: >-
-c {{ flavors_python_upper_constraints_url }} -c {{ flavors_python_upper_constraints_url }}
virtualenv: "{{ flavors_virtualenv_path }}" virtualenv: "{{ flavors_virtualenv_path }}"
register: result
until: result is success
retries: 3
- name: Configure Nova flavors - name: Configure Nova flavors
os_nova_flavor: os_nova_flavor:

View File

@ -11,9 +11,11 @@
- name: Ensure package dependencies are installed - name: Ensure package dependencies are installed
package: package:
name: "{{ item }}" name: "{{ vbmcd_packages }}"
state: installed state: installed
loop: "{{ vbmcd_packages }}" register: result
until: result is success
retries: 3
become: true become: true
# This is useful to get a uniquely generated temporary path. # This is useful to get a uniquely generated temporary path.
@ -32,6 +34,9 @@
extra_args: >- extra_args: >-
-c {{ vbmcd_python_upper_constraints_url }} -c {{ vbmcd_python_upper_constraints_url }}
virtualenv: "{{ vbmcd_virtualenv_path }}" virtualenv: "{{ vbmcd_virtualenv_path }}"
register: result
until: result is success
retries: 3
- name: Ensure Virtual BMC systemd service is configured - name: Ensure Virtual BMC systemd service is configured
template: template:

View File

@ -29,6 +29,9 @@
-c {{ wait_for_resources_python_upper_constraints_url }} -c {{ wait_for_resources_python_upper_constraints_url }}
{%- endif -%} {%- endif -%}
virtualenv: "{{ wait_for_resources_venv }}" virtualenv: "{{ wait_for_resources_venv }}"
register: result
until: result is success
retries: 3
- name: Call wait_for_resources module - name: Call wait_for_resources module
wait_for_resources: wait_for_resources: