Fix ansible-lint nits

Ansible lint has become more fussy about its nit picking, blocking CI.

This change makes it happy again.

Change-Id: Ifb86c5e071697acda014bb543cab7ebf2b648dc9

ansible/hypervisor_setup.yml

@@ -12,6 +12,9 @@
 - name: Ensure general system requirements are installed
   package:
     name: "{{ system_requirements }}"
+  register: result
+  until: result is success
+  retries: 3
   become: true
   # Don't uninstall requirements during teardown since they may already have
   # been present.
@@ -35,6 +38,9 @@
     - name: Ensure Open vSwitch package is installed
       package:
         name: "{{ tenks_openvswitch_pkg_name }}"
+      register: result
+      until: result is success
+      retries: 3
       become: true
 
     - name: Ensure Open vSwitch is started and enabled

ansible/roles/ironic-enrolment/tasks/main.yml

@@ -22,6 +22,9 @@
     extra_args: >-
       -c {{ ironic_python_upper_constraints_url }}
     virtualenv: "{{ ironic_virtualenv_path }}"
+  register: result
+  until: result is success
+  retries: 3
 
 # This command will return the UUIDs, regardless of whether
 # ironic_deploy_kernel and ironic_deploy_ramdisk are image UUIDs or names.
@@ -36,7 +39,7 @@
   # for enrolment to continue.
   when:
     - item is not none
-    - item != ""
+    - item | length > 0
   register: deploy_image_ids
   changed_when: false
 

ansible/roles/ironic-enrolment/tasks/port.yml

@@ -11,7 +11,7 @@
 - name: Fail if port is not found
   fail:
     msg: Ironic port with MAC address {{ mac }} not found
-  when: uuid.stdout == ""
+  when: not uuid.stdout
 
 - name: Get physical network name
   set_fact:

ansible/roles/nova-flavors/tasks/main.yml

@@ -5,6 +5,9 @@
     extra_args: >-
       -c {{ flavors_python_upper_constraints_url }}
     virtualenv: "{{ flavors_virtualenv_path }}"
+  register: result
+  until: result is success
+  retries: 3
 
 - name: Configure Nova flavors
   os_nova_flavor:

ansible/roles/virtualbmc-daemon/tasks/main.yml

@@ -11,9 +11,11 @@
 
 - name: Ensure package dependencies are installed
   package:
-    name: "{{ item }}"
+    name: "{{ vbmcd_packages }}"
     state: installed
-  loop: "{{ vbmcd_packages }}"
+  register: result
+  until: result is success
+  retries: 3
   become: true
 
 # This is useful to get a uniquely generated temporary path.
@@ -32,6 +34,9 @@
     extra_args: >-
       -c {{ vbmcd_python_upper_constraints_url }}
     virtualenv: "{{ vbmcd_virtualenv_path }}"
+  register: result
+  until: result is success
+  retries: 3
 
 - name: Ensure Virtual BMC systemd service is configured
   template:

ansible/roles/wait-for-resources/tasks/main.yml

@@ -29,6 +29,9 @@
       -c {{ wait_for_resources_python_upper_constraints_url }}
       {%- endif -%}
     virtualenv: "{{ wait_for_resources_venv }}"
+  register: result
+  until: result is success
+  retries: 3
 
 - name: Call wait_for_resources module
   wait_for_resources: