From bbebacc3c566b917a4479b1954970f468dc1040c Mon Sep 17 00:00:00 2001
From: Gerrit User 28522 <28522@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Wed, 1 Jun 2022 10:04:20 +0000
Subject: [PATCH] Update patch set 4
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Patch Set 4:

(2 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 32927 \u003c32927@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Hervé Beraud replied on the change"}
Attention: {"person_ident":"Gerrit User 28522 \u003c28522@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Hervé Beraud replied on the change"}
---
 ae5adcf3874d3ab40a8f6c475b450e72a75f5d23 | 44 ++++++++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 ae5adcf3874d3ab40a8f6c475b450e72a75f5d23

diff --git a/ae5adcf3874d3ab40a8f6c475b450e72a75f5d23 b/ae5adcf3874d3ab40a8f6c475b450e72a75f5d23
new file mode 100644
index 00000000..e1578839
--- /dev/null
+++ b/ae5adcf3874d3ab40a8f6c475b450e72a75f5d23
@@ -0,0 +1,44 @@
+{
+  "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "35aa7506_7d9fd13f",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 4
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 28522
+      },
+      "writtenOn": "2022-06-01T10:04:20Z",
+      "side": 1,
+      "message": "Hello,\n\nThanks for your latest patch set.\nI have one question, see my inline comment.\n\nThanks by advance for your reply.",
+      "revId": "ae5adcf3874d3ab40a8f6c475b450e72a75f5d23",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "2cb03f8f_b730a9e9",
+        "filename": "tooz/drivers/etcd3gw.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 235,
+      "author": {
+        "id": 28522
+      },
+      "writtenOn": "2022-06-01T10:04:20Z",
+      "side": 1,
+      "message": "What does `-1` stand for?\n\nBy looking at the etcd documentation and etcd3gw for `lease` and `refresh` I didn\u0027t find `-1` returns.\n\nWhen `refresh` is called Etcd3gw returns the `TTL` of the lease keepalive related to the ID of the lease [1], however I didn\u0027t see that the TTL could be a negative integer [2]. Please can you indicate me where we can ensure that this value will be returned under some conditions and what we should expect in this condition.\n\n[1]https://opendev.org/openstack/etcd3gw/src/commit/7a1a2b5a672605ae549c73ed18302b7abd9e0e30/etcd3gw/lease.py#L64\n[2]https://etcd.io/docs/v3.4/learning/api/#keep-alives",
+      "range": {
+        "startLine": 235,
+        "startChar": 47,
+        "endLine": 235,
+        "endChar": 49
+      },
+      "revId": "ae5adcf3874d3ab40a8f6c475b450e72a75f5d23",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}
\ No newline at end of file