Update patch set 5
Patch Set 5: (2 comments) Patch-set: 5
This commit is contained in:
parent
6d3b8d548f
commit
d76bcd6ac6
|
@ -0,0 +1,44 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "45071ead_fedf6034",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 28522
|
||||
},
|
||||
"writtenOn": "2022-05-25T13:53:10Z",
|
||||
"side": 1,
|
||||
"message": "Hello,\n\nSee my inline comment.\n\nPlease can add a release note too, to describe this fix and highlight this topic to the community.\n\nThanks by advance.",
|
||||
"revId": "c0471fe71a4c7a6e77d3ce211eaac8a485794f34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "8ddc7b82_a9e03b76",
|
||||
"filename": "tooz/drivers/memcached.py",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 161,
|
||||
"author": {
|
||||
"id": 28522
|
||||
},
|
||||
"writtenOn": "2022-05-25T13:53:10Z",
|
||||
"side": 1,
|
||||
"message": "So do we still need to store the delete\u0027s result into `was_deleted`?\nAccording to your previous comment and according to fact that `was_deleted` seems to be no longer used after this point, I think we can avoid to store it, isn\u0027t?",
|
||||
"range": {
|
||||
"startLine": 161,
|
||||
"startChar": 12,
|
||||
"endLine": 161,
|
||||
"endChar": 76
|
||||
},
|
||||
"revId": "c0471fe71a4c7a6e77d3ce211eaac8a485794f34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue