Update patch set 9
Patch Set 9: Code-Review-1 (6 comments) the main concern is about writing a driver instead of a plugin Patch-set: 9 Label: Code-Review=-1
This commit is contained in:
parent
bd42e8c674
commit
24df05ed18
142
52bacc8e68751d13325a8a65b38acb0f91d94579
Normal file
142
52bacc8e68751d13325a8a65b38acb0f91d94579
Normal file
@ -0,0 +1,142 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f201791_e5b56733",
|
||||
"filename": "tricircle/network/qos.py",
|
||||
"patchSetId": 9
|
||||
},
|
||||
"lineNbr": 32,
|
||||
"author": {
|
||||
"id": 12076
|
||||
},
|
||||
"writtenOn": "2017-06-27T11:58:38Z",
|
||||
"side": 1,
|
||||
"message": "These days we are developing the service function chaining feature. At first we try to write a new plugin, but we later we find out that the original plugin has driver mechanism. So finally we decide to write a new driver instead of a plugin.\n\nQos also has driver mechanism, so I think writing a new driver is a better choice. For detail about writing a Qos driver, you can ping me tomorrow. Or you can refer to the implementation in Neutron.",
|
||||
"range": {
|
||||
"startLine": 32,
|
||||
"startChar": 6,
|
||||
"endLine": 32,
|
||||
"endChar": 24
|
||||
},
|
||||
"revId": "52bacc8e68751d13325a8a65b38acb0f91d94579",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f201791_25059f46",
|
||||
"filename": "tricircle/xjob/xmanager.py",
|
||||
"patchSetId": 9
|
||||
},
|
||||
"lineNbr": 1280,
|
||||
"author": {
|
||||
"id": 12076
|
||||
},
|
||||
"writtenOn": "2017-06-27T11:58:38Z",
|
||||
"side": 1,
|
||||
"message": "this can be simplified to:\n\n\nfor b_pod, _ in mappings:\n self.xjob_handler.create_qos_policy",
|
||||
"range": {
|
||||
"startLine": 1279,
|
||||
"startChar": 0,
|
||||
"endLine": 1280,
|
||||
"endChar": 32
|
||||
},
|
||||
"revId": "52bacc8e68751d13325a8a65b38acb0f91d94579",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f201791_055e2343",
|
||||
"filename": "tricircle/xjob/xmanager.py",
|
||||
"patchSetId": 9
|
||||
},
|
||||
"lineNbr": 1305,
|
||||
"author": {
|
||||
"id": 12076
|
||||
},
|
||||
"writtenOn": "2017-06-27T11:58:38Z",
|
||||
"side": 1,
|
||||
"message": "when using prepare_bottom_element, it\u0027s no need to check the mapping, since prepare_bottom_element will do it for you",
|
||||
"range": {
|
||||
"startLine": 1303,
|
||||
"startChar": 12,
|
||||
"endLine": 1305,
|
||||
"endChar": 31
|
||||
},
|
||||
"revId": "52bacc8e68751d13325a8a65b38acb0f91d94579",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f201791_e52b2792",
|
||||
"filename": "tricircle/xjob/xmanager.py",
|
||||
"patchSetId": 9
|
||||
},
|
||||
"lineNbr": 1346,
|
||||
"author": {
|
||||
"id": 12076
|
||||
},
|
||||
"writtenOn": "2017-06-27T11:58:38Z",
|
||||
"side": 1,
|
||||
"message": "ditto line 1280",
|
||||
"range": {
|
||||
"startLine": 1345,
|
||||
"startChar": 0,
|
||||
"endLine": 1346,
|
||||
"endChar": 32
|
||||
},
|
||||
"revId": "52bacc8e68751d13325a8a65b38acb0f91d94579",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f201791_cd7171aa",
|
||||
"filename": "tricircle/xjob/xmanager.py",
|
||||
"patchSetId": 9
|
||||
},
|
||||
"lineNbr": 1378,
|
||||
"author": {
|
||||
"id": 12076
|
||||
},
|
||||
"writtenOn": "2017-06-27T11:58:38Z",
|
||||
"side": 1,
|
||||
"message": "better to pass POD_NOT_SPECIFIED, and divide the jobs here instead of dividing the jobs in the neutron server side.",
|
||||
"range": {
|
||||
"startLine": 1378,
|
||||
"startChar": 9,
|
||||
"endLine": 1378,
|
||||
"endChar": 17
|
||||
},
|
||||
"revId": "52bacc8e68751d13325a8a65b38acb0f91d94579",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f201791_adb19549",
|
||||
"filename": "tricircle/xjob/xmanager.py",
|
||||
"patchSetId": 9
|
||||
},
|
||||
"lineNbr": 1422,
|
||||
"author": {
|
||||
"id": 12076
|
||||
},
|
||||
"writtenOn": "2017-06-27T11:58:38Z",
|
||||
"side": 1,
|
||||
"message": "no need, NotFound exception is caught by resource_handle module",
|
||||
"range": {
|
||||
"startLine": 1405,
|
||||
"startChar": 0,
|
||||
"endLine": 1422,
|
||||
"endChar": 18
|
||||
},
|
||||
"revId": "52bacc8e68751d13325a8a65b38acb0f91d94579",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue
Block a user