Update patch set 3

Patch Set 3: Code-Review-1

(5 comments)

Patch-set: 3
Label: Code-Review=-1

d2930a5f451cb7d38d0129ed8015a482f8cc0eb2

@@ -0,0 +1,119 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "df140735_17b6b0da",
+        "filename": "tricircle/common/constants.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 143,
+      "author": {
+        "id": 12076
+      },
+      "writtenOn": "2017-06-01T03:14:09Z",
+      "side": 1,
+      "message": "two more parameters res_type, res_id need to be added, according to your xrpcapi definition",
+      "range": {
+        "startLine": 142,
+        "startChar": 4,
+        "endLine": 143,
+        "endChar": 42
+      },
+      "revId": "d2930a5f451cb7d38d0129ed8015a482f8cc0eb2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "df140735_06f43ff1",
+        "filename": "tricircle/network/qos.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 32,
+      "author": {
+        "id": 12076
+      },
+      "writtenOn": "2017-06-01T03:14:09Z",
+      "side": 1,
+      "message": "I see that most of the codes are similar from qos.qos_plugin.py. I think you can inherit from qos.qos_plugin.QoSPlugin, call the parent method and then add your own code.\n\n\nFor driver_manager, I think you can also inherit from qos.drivers.manager.QosServiceDriverManager and overwrite the call method, since we don\u0027t need to interact with agents in central Neutron",
+      "range": {
+        "startLine": 32,
+        "startChar": 6,
+        "endLine": 32,
+        "endChar": 24
+      },
+      "revId": "d2930a5f451cb7d38d0129ed8015a482f8cc0eb2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "df140735_46bfd760",
+        "filename": "tricircle/xjob/xmanager.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 1278,
+      "author": {
+        "id": 12076
+      },
+      "writtenOn": "2017-06-01T03:14:09Z",
+      "side": 1,
+      "message": "without creating local qos policy, there is no mapping.",
+      "range": {
+        "startLine": 1277,
+        "startChar": 11,
+        "endLine": 1278,
+        "endChar": 51
+      },
+      "revId": "d2930a5f451cb7d38d0129ed8015a482f8cc0eb2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "df140735_66bbfb0d",
+        "filename": "tricircle/xjob/xmanager.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 1309,
+      "author": {
+        "id": 12076
+      },
+      "writtenOn": "2017-06-01T03:14:09Z",
+      "side": 1,
+      "message": "In helper.py, we have a \"prepare_bottom_element\" method that can help you create local resource and create the mapping at the same time. It can also handle the case that you successfully create the local resource but fail to create the mapping(for example, machine is rebooted between line 1306 and 1307)",
+      "range": {
+        "startLine": 1303,
+        "startChar": 12,
+        "endLine": 1309,
+        "endChar": 37
+      },
+      "revId": "d2930a5f451cb7d38d0129ed8015a482f8cc0eb2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "df140735_865a8f4c",
+        "filename": "tricircle/xjob/xmanager.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 1520,
+      "author": {
+        "id": 12076
+      },
+      "writtenOn": "2017-06-01T03:14:09Z",
+      "side": 1,
+      "message": "this part can be put into a function",
+      "range": {
+        "startLine": 1487,
+        "startChar": 11,
+        "endLine": 1520,
+        "endChar": 38
+      },
+      "revId": "d2930a5f451cb7d38d0129ed8015a482f8cc0eb2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}