openstack
/
tricircle
Code Issues Proposed changes

Remove outdated todo notes 

1. What is the problem?
We have some outdated todo notes that may confuse developers.

2. What is the solution to the problem?
The following todo notes are removed:
(1) solve ip address conflict issue
Now the external gateway ip and floating ip are allocated from central
Neutron so conflict will not happend. Why this issue existed before is
that we updated local router before updated central router, so the
external gateway ip was not controlled by central Neutron.

(2) decide router is distributed or not from pod table
We already support DVR and this is passed from API, not read from DB

3. What features need to be implemented to the Tricircle to realize
the solution?
N/A

Change-Id: I9306e7f6e20715b6df8bb759be6dbf8a0b28cd2e
Closes-Bug: #1733750
This commit is contained in:
zhiyuan_cai 2017-11-22 12:03:51 +08:00
parent 1155347157
commit 890d2901ab
1 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tricircle/network/central_plugin.py
View File

@ -1466,10 +1466,6 @@ class TricirclePlugin(db_base_plugin_v2.NeutronDbPluginV2,
'distributed': is_distributed}}
else:
# TODO(zhiyuan) decide router is distributed or not from pod table
# currently "distributed" is set to False, should add a metadata
# field to pod table, and decide distributed or not from the
# metadata later
router_type = t_constants.RT_NS_ROUTER
body = {'router': {'name': t_constants.ns_router_name % router_id,
'distributed': False}}
@ -1578,17 +1574,6 @@ class TricirclePlugin(db_base_plugin_v2.NeutronDbPluginV2,
'network_id')
if ext_net_id:
is_add = True
# TODO(zhiyuan) solve ip address conflict issue
# if user creates floating ip before set router gateway, we may trigger
# ip address conflict here. let's say external cidr is 163.3.124.0/24,
# creating floating ip before setting router gateway, the gateway ip
# will be 163.3.124.3 since 163.3.124.2 is used by floating ip, however
# in the bottom pod floating ip is not created when creating floating
# ip on top, so the gateway ip in the bottom pod is still 163.3.124.2,
# thus conflict may occur.
#
# before this issue is solved, user should set router gateway before
# create floating ip.
if not need_update_bottom:
return super(TricirclePlugin, self).update_router(
context, router_id, router)