Update patch set 7

Patch Set 7:

(4 comments)

Patch-set: 7
This commit is contained in:
Gerrit User 12076 2017-06-20 08:29:52 +00:00 committed by Gerrit Code Review
parent fcdf795c00
commit dc79a31387
1 changed files with 96 additions and 0 deletions

View File

@ -47,6 +47,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_6da20b4e",
"filename": "tricircle/common/constants.py",
"patchSetId": 7
},
"lineNbr": 144,
"author": {
"id": 12076
},
"writtenOn": "2017-06-20T08:29:52Z",
"side": 1,
"message": "yes",
"parentUuid": "7f231b9d_2accf95f",
"range": {
"startLine": 144,
"startChar": 20,
"endLine": 144,
"endChar": 41
},
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_4c499889",
@ -94,6 +118,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_f8193b22",
"filename": "tricircle/network/qos.py",
"patchSetId": 7
},
"lineNbr": 32,
"author": {
"id": 12076
},
"writtenOn": "2017-06-20T08:29:52Z",
"side": 1,
"message": "hmm, I am just thinking the first way has too many duplicated codes with QoSPlugin, and later it\u0027s hard for us to figure out which operations belong to the native QosPlugin, which operations are introduced by us.\n\nusing the first way, if native QosPlugin is changed, we need to maintain the same changes in this plugin.\n\nif inherit, we can directly use the newly changes brought by QosPlugin and no need to change this plugin.",
"parentUuid": "7f231b9d_c777be08",
"range": {
"startLine": 32,
"startChar": 6,
"endLine": 32,
"endChar": 24
},
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_4475eccb",
@ -141,6 +189,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_58870f11",
"filename": "tricircle/network/qos.py",
"patchSetId": 7
},
"lineNbr": 52,
"author": {
"id": 12076
},
"writtenOn": "2017-06-20T08:29:52Z",
"side": 1,
"message": "So there\u0027s a third patch, is that right? Then please also submit it so I can do an integration test. Last week I asked Ronghui and he told me that there were only two patches in total.",
"parentUuid": "7f231b9d_8797863b",
"range": {
"startLine": 52,
"startChar": 8,
"endLine": 52,
"endChar": 21
},
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_447ccc1f",
@ -282,6 +354,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_4d0cef41",
"filename": "tricircle/xjob/xmanager.py",
"patchSetId": 7
},
"lineNbr": 1279,
"author": {
"id": 12076
},
"writtenOn": "2017-06-20T08:29:52Z",
"side": 1,
"message": "you can split this job based on mappings of network/port, not qos",
"parentUuid": "7f231b9d_cabc656e",
"range": {
"startLine": 1277,
"startChar": 12,
"endLine": 1279,
"endChar": 57
},
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7f231b9d_2468b01f",