{ "comments": [ { "key": { "uuid": "7f515b1d_dbdbbbea", "filename": "tricircle/network/central_plugin.py", "patchSetId": 50 }, "lineNbr": 180, "author": { "id": 12076 }, "writtenOn": "2017-09-26T09:34:21Z", "side": 1, "message": "so TricircleExtensionManager no longer needed? but you still keep the definition in tricircle.network.managers", "range": { "startLine": 180, "startChar": 32, "endLine": 180, "endChar": 62 }, "revId": "03db3433aabd00caa8ac53d91e808c00f5b70890", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "7f515b1d_0a39cdf0", "filename": "tricircle/network/central_plugin.py", "patchSetId": 50 }, "lineNbr": 180, "author": { "id": 21033 }, "writtenOn": "2017-09-27T16:26:47Z", "side": 1, "message": "sorry, forgot to move it.", "parentUuid": "7f515b1d_dbdbbbea", "range": { "startLine": 180, "startChar": 32, "endLine": 180, "endChar": 62 }, "revId": "03db3433aabd00caa8ac53d91e808c00f5b70890", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "7f515b1d_fb87970e", "filename": "tricircle/network/central_plugin.py", "patchSetId": 50 }, "lineNbr": 849, "author": { "id": 12076 }, "writtenOn": "2017-09-26T09:34:21Z", "side": 1, "message": "request_body_policy_id \u003d request_body.pop(\u0027qos_policy_id\u0027, None)", "range": { "startLine": 846, "startChar": 20, "endLine": 849, "endChar": 65 }, "revId": "03db3433aabd00caa8ac53d91e808c00f5b70890", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "7f515b1d_8db6f73d", "filename": "tricircle/network/central_plugin.py", "patchSetId": 50 }, "lineNbr": 849, "author": { "id": 21033 }, "writtenOn": "2017-09-27T16:26:47Z", "side": 1, "message": "Done", "parentUuid": "7f515b1d_fb87970e", "range": { "startLine": 846, "startChar": 20, "endLine": 849, "endChar": 65 }, "revId": "03db3433aabd00caa8ac53d91e808c00f5b70890", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "7f515b1d_9bad438a", "filename": "tricircle/network/central_plugin.py", "patchSetId": 50 }, "lineNbr": 872, "author": { "id": 12076 }, "writtenOn": "2017-09-26T09:34:21Z", "side": 1, "message": "updated_port[\u0027qos_policy_id\u0027] \u003d request_body.get(\u0027qos_policy_id\u0027)", "range": { "startLine": 867, "startChar": 20, "endLine": 872, "endChar": 60 }, "revId": "03db3433aabd00caa8ac53d91e808c00f5b70890", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "7f515b1d_adad33ea", "filename": "tricircle/network/central_plugin.py", "patchSetId": 50 }, "lineNbr": 872, "author": { "id": 21033 }, "writtenOn": "2017-09-27T16:26:47Z", "side": 1, "message": "Done", "parentUuid": "7f515b1d_9bad438a", "range": { "startLine": 867, "startChar": 20, "endLine": 872, "endChar": 60 }, "revId": "03db3433aabd00caa8ac53d91e808c00f5b70890", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "7f515b1d_d804e14c", "filename": "tricircle/network/central_qos_plugin.py", "patchSetId": 50 }, "lineNbr": 47, "author": { "id": 12076 }, "writtenOn": "2017-09-26T09:34:21Z", "side": 1, "message": "directly query bottom ports with network id, instead of getting the port ids here and query bottom ports one by one.", "range": { "startLine": 46, "startChar": 8, "endLine": 47, "endChar": 45 }, "revId": "03db3433aabd00caa8ac53d91e808c00f5b70890", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "7f515b1d_ab6198d5", "filename": "tricircle/network/central_qos_plugin.py", "patchSetId": 50 }, "lineNbr": 47, "author": { "id": 21033 }, "writtenOn": "2017-09-27T16:26:47Z", "side": 1, "message": "if we use network id to query all bottom ports, we need to traverse regions that network reside in , is it right?", "parentUuid": "7f515b1d_d804e14c", "range": { "startLine": 46, "startChar": 8, "endLine": 47, "endChar": 45 }, "revId": "03db3433aabd00caa8ac53d91e808c00f5b70890", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "7f515b1d_9bcae36a", "filename": "tricircle/tests/unit/network/test_central_plugin.py", "patchSetId": 50 }, "lineNbr": 1919, "author": { "id": 12076 }, "writtenOn": "2017-09-26T09:34:21Z", "side": 1, "message": "why need to mock the original get_port?", "range": { "startLine": 1919, "startChar": 42, "endLine": 1919, "endChar": 71 }, "revId": "03db3433aabd00caa8ac53d91e808c00f5b70890", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "7f515b1d_6b2a807f", "filename": "tricircle/tests/unit/network/test_central_plugin.py", "patchSetId": 50 }, "lineNbr": 1919, "author": { "id": 21033 }, "writtenOn": "2017-09-27T16:26:47Z", "side": 1, "message": "Done", "parentUuid": "7f515b1d_9bcae36a", "range": { "startLine": 1919, "startChar": 42, "endLine": 1919, "endChar": 71 }, "revId": "03db3433aabd00caa8ac53d91e808c00f5b70890", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "7f515b1d_7bfe07af", "filename": "tricircle/xjob/xmanager.py", "patchSetId": 50 }, "lineNbr": 901, "author": { "id": 12076 }, "writtenOn": "2017-09-26T09:34:21Z", "side": 1, "message": "why not get the qos information from t_network? in this case. you don\u0027t need to pass \"qos_need_update\"", "range": { "startLine": 895, "startChar": 8, "endLine": 901, "endChar": 60 }, "revId": "03db3433aabd00caa8ac53d91e808c00f5b70890", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "7f515b1d_d8adcf9b", "filename": "tricircle/xjob/xmanager.py", "patchSetId": 50 }, "lineNbr": 901, "author": { "id": 21033 }, "writtenOn": "2017-09-27T16:26:47Z", "side": 1, "message": "we don\u0027t know the original network qos information if we get qos information from t_network here. So we need a flag to indicate network qos information changed.", "parentUuid": "7f515b1d_7bfe07af", "range": { "startLine": 895, "startChar": 8, "endLine": 901, "endChar": 60 }, "revId": "03db3433aabd00caa8ac53d91e808c00f5b70890", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "7f515b1d_b44e8c6c", "filename": "tricircle/xjob/xmanager.py", "patchSetId": 50 }, "lineNbr": 901, "author": { "id": 12076 }, "writtenOn": "2017-09-28T01:57:19Z", "side": 1, "message": "IMHO, no matter whether the qos has been changed, you just update the latest qos information to local neutron.", "parentUuid": "7f515b1d_d8adcf9b", "range": { "startLine": 895, "startChar": 8, "endLine": 901, "endChar": 60 }, "revId": "03db3433aabd00caa8ac53d91e808c00f5b70890", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "7f515b1d_af3d0490", "filename": "tricircle/xjob/xmanager.py", "patchSetId": 50 }, "lineNbr": 901, "author": { "id": 21033 }, "writtenOn": "2017-09-28T16:27:57Z", "side": 1, "message": "Done", "parentUuid": "7f515b1d_b44e8c6c", "range": { "startLine": 895, "startChar": 8, "endLine": 901, "endChar": 60 }, "revId": "03db3433aabd00caa8ac53d91e808c00f5b70890", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "7f515b1d_9be78341", "filename": "tricircle/xjob/xmanager.py", "patchSetId": 50 }, "lineNbr": 937, "author": { "id": 12076 }, "writtenOn": "2017-09-26T09:34:21Z", "side": 1, "message": "the above body is overwritten", "range": { "startLine": 932, "startChar": 8, "endLine": 937, "endChar": 13 }, "revId": "03db3433aabd00caa8ac53d91e808c00f5b70890", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "7f515b1d_d886ef13", "filename": "tricircle/xjob/xmanager.py", "patchSetId": 50 }, "lineNbr": 937, "author": { "id": 21033 }, "writtenOn": "2017-09-27T16:26:47Z", "side": 1, "message": "Done", "parentUuid": "7f515b1d_9be78341", "range": { "startLine": 932, "startChar": 8, "endLine": 937, "endChar": 13 }, "revId": "03db3433aabd00caa8ac53d91e808c00f5b70890", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false } ] }