tricircle/03d3b5cff88417d303e75b7d86fc24653102ba26

{
  "comments": [
    {
      "key": {
        "uuid": "3a1ff146_e76d6a05",
        "filename": "tricircle/network/qos.py",
        "patchSetId": 1
      },
      "lineNbr": 24,
      "author": {
        "id": 11819
      },
      "writtenOn": "2017-03-16T07:44:27Z",
      "side": 1,
      "message": "from tricircle.db import api as db_api",
      "range": {
        "startLine": 24,
        "startChar": 0,
        "endLine": 24,
        "endChar": 33
      },
      "revId": "03d3b5cff88417d303e75b7d86fc24653102ba26",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a1ff146_12dc82e3",
        "filename": "tricircle/network/qos.py",
        "patchSetId": 1
      },
      "lineNbr": 27,
      "author": {
        "id": 11819
      },
      "writtenOn": "2017-03-16T07:44:27Z",
      "side": 1,
      "message": "inherited from QoSPlugin will call driver and rpc, it\u0027s overhead, could be removed. According to the devref from Neutron: https://github.com/openstack/neutron/blob/02f893a56d5df6319cb880db497e3c0e8c3dbe65/doc/source/devref/quality_of_service.rst it\u0027s recommend to inherit from QoSPluginBase, and borrow most of code from QoSPlugin, or inherit from QoSPlugin, but need to provide simplification for RPC and driver_manager calling",
      "range": {
        "startLine": 27,
        "startChar": 36,
        "endLine": 27,
        "endChar": 45
      },
      "revId": "03d3b5cff88417d303e75b7d86fc24653102ba26",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a1ff146_c71b0e7f",
        "filename": "tricircle/network/qos.py",
        "patchSetId": 1
      },
      "lineNbr": 40,
      "author": {
        "id": 11819
      },
      "writtenOn": "2017-03-16T07:44:27Z",
      "side": 1,
      "message": "move it below update policy in central plugin",
      "range": {
        "startLine": 39,
        "startChar": 7,
        "endLine": 40,
        "endChar": 51
      },
      "revId": "03d3b5cff88417d303e75b7d86fc24653102ba26",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "3a1ff146_d244aa75",
        "filename": "tricircle/network/qos.py",
        "patchSetId": 1
      },
      "lineNbr": 63,
      "author": {
        "id": 11819
      },
      "writtenOn": "2017-03-16T07:44:27Z",
      "side": 1,
      "message": "no need, please refer to QoSPlugin delete_policy",
      "range": {
        "startLine": 56,
        "startChar": 5,
        "endLine": 63,
        "endChar": 68
      },
      "revId": "03d3b5cff88417d303e75b7d86fc24653102ba26",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5a22e58a_eb3f45d4",
        "filename": "tricircle/xjob/xmanager.py",
        "patchSetId": 1
      },
      "lineNbr": 956,
      "author": {
        "id": 12076
      },
      "writtenOn": "2017-03-14T06:55:13Z",
      "side": 1,
      "message": "Cannot handle local resource and mapping creation like this. If line 953 succeeds but line 954 fails, you will create duplicated QoS policies during the redo of this job. Try using tricircle.network.helper.prepare_bottom_element",
      "range": {
        "startLine": 950,
        "startChar": 12,
        "endLine": 956,
        "endChar": 37
      },
      "revId": "03d3b5cff88417d303e75b7d86fc24653102ba26",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5a22e58a_8e4c1f78",
        "filename": "tricircle/xjob/xmanager.py",
        "patchSetId": 1
      },
      "lineNbr": 1026,
      "author": {
        "id": 12076
      },
      "writtenOn": "2017-03-14T06:55:13Z",
      "side": 1,
      "message": "If line 1025 succeeds but line 1026 fails, this job will be redone. During the redo, since local QoS policy has been removed in the previous run, NotFound exception is raised and is caught in line 1027, so the mapping is left without deleting.",
      "range": {
        "startLine": 1025,
        "startChar": 0,
        "endLine": 1026,
        "endChar": 60
      },
      "revId": "03d3b5cff88417d303e75b7d86fc24653102ba26",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5a22e58a_df08832b",
        "filename": "tricircle/xjob/xmanager.py",
        "patchSetId": 1
      },
      "lineNbr": 1037,
      "author": {
        "id": 12076
      },
      "writtenOn": "2017-03-14T08:35:19Z",
      "side": 1,
      "message": "I find that these functions are added in part2. It\u0027s weird that part1 depends on part2.",
      "range": {
        "startLine": 1036,
        "startChar": 0,
        "endLine": 1037,
        "endChar": 43
      },
      "revId": "03d3b5cff88417d303e75b7d86fc24653102ba26",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}