523 lines
15 KiB
Plaintext
523 lines
15 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_cc8da8d4",
|
|
"filename": "tricircle/common/constants.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 144,
|
|
"author": {
|
|
"id": 12076
|
|
},
|
|
"writtenOn": "2017-06-20T06:37:57Z",
|
|
"side": 1,
|
|
"message": "this job has two more parameters, res_type and res_id",
|
|
"range": {
|
|
"startLine": 144,
|
|
"startChar": 20,
|
|
"endLine": 144,
|
|
"endChar": 41
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_2accf95f",
|
|
"filename": "tricircle/common/constants.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 144,
|
|
"author": {
|
|
"id": 21033
|
|
},
|
|
"writtenOn": "2017-06-20T07:51:30Z",
|
|
"side": 1,
|
|
"message": "JT_QOS_CREATE: [(None, \"pod_id\"),\n (RT_QOS, \"policy_id\"),\n (None, \"res_type\"),\n (None, \"res_id\")]\nis it correct?",
|
|
"parentUuid": "7f231b9d_cc8da8d4",
|
|
"range": {
|
|
"startLine": 144,
|
|
"startChar": 20,
|
|
"endLine": 144,
|
|
"endChar": 41
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_6da20b4e",
|
|
"filename": "tricircle/common/constants.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 144,
|
|
"author": {
|
|
"id": 12076
|
|
},
|
|
"writtenOn": "2017-06-20T08:29:52Z",
|
|
"side": 1,
|
|
"message": "yes",
|
|
"parentUuid": "7f231b9d_2accf95f",
|
|
"range": {
|
|
"startLine": 144,
|
|
"startChar": 20,
|
|
"endLine": 144,
|
|
"endChar": 41
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_4c499889",
|
|
"filename": "tricircle/network/qos.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 32,
|
|
"author": {
|
|
"id": 12076
|
|
},
|
|
"writtenOn": "2017-06-20T06:37:57Z",
|
|
"side": 1,
|
|
"message": "I see that most of the codes are similar from qos.qos_plugin.py. I think you can inherit from qos.qos_plugin.QoSPlugin, call the parent method and then add your own code.\n\nFor driver_manager, I think you can also inherit from qos.drivers.manager.QosServiceDriverManager and overwrite the call method, since we don\u0027t need to interact with agents in central Neutron.",
|
|
"range": {
|
|
"startLine": 32,
|
|
"startChar": 6,
|
|
"endLine": 32,
|
|
"endChar": 24
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_c777be08",
|
|
"filename": "tricircle/network/qos.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 32,
|
|
"author": {
|
|
"id": 21033
|
|
},
|
|
"writtenOn": "2017-06-20T07:13:32Z",
|
|
"side": 1,
|
|
"message": "Chaoyi said it is recommend to inherit from QoSPluginBase, and borrow most of code from QoSPlugin, or inherit from QoSPlugin, but need to provide simplification for RPC and driver_manager calling. I think the first way is more intuitive.",
|
|
"parentUuid": "7f231b9d_4c499889",
|
|
"range": {
|
|
"startLine": 32,
|
|
"startChar": 6,
|
|
"endLine": 32,
|
|
"endChar": 24
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_f8193b22",
|
|
"filename": "tricircle/network/qos.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 32,
|
|
"author": {
|
|
"id": 12076
|
|
},
|
|
"writtenOn": "2017-06-20T08:29:52Z",
|
|
"side": 1,
|
|
"message": "hmm, I am just thinking the first way has too many duplicated codes with QoSPlugin, and later it\u0027s hard for us to figure out which operations belong to the native QosPlugin, which operations are introduced by us.\n\nusing the first way, if native QosPlugin is changed, we need to maintain the same changes in this plugin.\n\nif inherit, we can directly use the newly changes brought by QosPlugin and no need to change this plugin.",
|
|
"parentUuid": "7f231b9d_c777be08",
|
|
"range": {
|
|
"startLine": 32,
|
|
"startChar": 6,
|
|
"endLine": 32,
|
|
"endChar": 24
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_4475eccb",
|
|
"filename": "tricircle/network/qos.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 52,
|
|
"author": {
|
|
"id": 12076
|
|
},
|
|
"writtenOn": "2017-06-20T06:37:57Z",
|
|
"side": 1,
|
|
"message": "central_plugin is not changed? so when to create bottom qos policies? you need to trigger bottom qos policy creation when network/port is udpated",
|
|
"range": {
|
|
"startLine": 52,
|
|
"startChar": 8,
|
|
"endLine": 52,
|
|
"endChar": 21
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_8797863b",
|
|
"filename": "tricircle/network/qos.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 52,
|
|
"author": {
|
|
"id": 21033
|
|
},
|
|
"writtenOn": "2017-06-20T07:13:32Z",
|
|
"side": 1,
|
|
"message": "There is another simple patch for associating / disassociating work",
|
|
"parentUuid": "7f231b9d_4475eccb",
|
|
"range": {
|
|
"startLine": 52,
|
|
"startChar": 8,
|
|
"endLine": 52,
|
|
"endChar": 21
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_58870f11",
|
|
"filename": "tricircle/network/qos.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 52,
|
|
"author": {
|
|
"id": 12076
|
|
},
|
|
"writtenOn": "2017-06-20T08:29:52Z",
|
|
"side": 1,
|
|
"message": "So there\u0027s a third patch, is that right? Then please also submit it so I can do an integration test. Last week I asked Ronghui and he told me that there were only two patches in total.",
|
|
"parentUuid": "7f231b9d_8797863b",
|
|
"range": {
|
|
"startLine": 52,
|
|
"startChar": 8,
|
|
"endLine": 52,
|
|
"endChar": 21
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_447ccc1f",
|
|
"filename": "tricircle/tests/unit/utils.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 74,
|
|
"author": {
|
|
"id": 12076
|
|
},
|
|
"writtenOn": "2017-06-20T06:37:57Z",
|
|
"side": 1,
|
|
"message": "in line 55, you can change None to \"qos_bandwidth_limit_rules\" to avoid these codes",
|
|
"range": {
|
|
"startLine": 72,
|
|
"startChar": 0,
|
|
"endLine": 74,
|
|
"endChar": 29
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_ca046581",
|
|
"filename": "tricircle/tests/unit/utils.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 74,
|
|
"author": {
|
|
"id": 21033
|
|
},
|
|
"writtenOn": "2017-06-20T07:51:30Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "7f231b9d_447ccc1f",
|
|
"range": {
|
|
"startLine": 72,
|
|
"startChar": 0,
|
|
"endLine": 74,
|
|
"endChar": 29
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_e4ee38b3",
|
|
"filename": "tricircle/tests/unit/utils.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 597,
|
|
"author": {
|
|
"id": 12076
|
|
},
|
|
"writtenOn": "2017-06-20T06:37:57Z",
|
|
"side": 1,
|
|
"message": "change to\n\nif _type \u003d\u003d \u0027policy\u0027:\n res_list \u003d self._res_map[self.region_name][\u0027qos_policies\u0027]\nelse\n res_list \u003d self._res_map[self.region_name][_type]\n\nso you don\u0027t need to rewrite _type in line 602",
|
|
"range": {
|
|
"startLine": 595,
|
|
"startChar": 0,
|
|
"endLine": 597,
|
|
"endChar": 57
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_8afe6d69",
|
|
"filename": "tricircle/tests/unit/utils.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 597,
|
|
"author": {
|
|
"id": 21033
|
|
},
|
|
"writtenOn": "2017-06-20T07:51:30Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "7f231b9d_e4ee38b3",
|
|
"range": {
|
|
"startLine": 595,
|
|
"startChar": 0,
|
|
"endLine": 597,
|
|
"endChar": 57
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_64a2284e",
|
|
"filename": "tricircle/xjob/xmanager.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 1279,
|
|
"author": {
|
|
"id": 12076
|
|
},
|
|
"writtenOn": "2017-06-20T06:37:57Z",
|
|
"side": 1,
|
|
"message": "before creating bottom qos, there is no mapping",
|
|
"range": {
|
|
"startLine": 1277,
|
|
"startChar": 12,
|
|
"endLine": 1279,
|
|
"endChar": 57
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_cabc656e",
|
|
"filename": "tricircle/xjob/xmanager.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 1279,
|
|
"author": {
|
|
"id": 21033
|
|
},
|
|
"writtenOn": "2017-06-20T07:51:30Z",
|
|
"side": 1,
|
|
"message": "in create_qos_policy job, is the b_pod_id parameter never equal constants.POD_NOT_SPECIFIED?",
|
|
"parentUuid": "7f231b9d_64a2284e",
|
|
"range": {
|
|
"startLine": 1277,
|
|
"startChar": 12,
|
|
"endLine": 1279,
|
|
"endChar": 57
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_4d0cef41",
|
|
"filename": "tricircle/xjob/xmanager.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 1279,
|
|
"author": {
|
|
"id": 12076
|
|
},
|
|
"writtenOn": "2017-06-20T08:29:52Z",
|
|
"side": 1,
|
|
"message": "you can split this job based on mappings of network/port, not qos",
|
|
"parentUuid": "7f231b9d_cabc656e",
|
|
"range": {
|
|
"startLine": 1277,
|
|
"startChar": 12,
|
|
"endLine": 1279,
|
|
"endChar": 57
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_2468b01f",
|
|
"filename": "tricircle/xjob/xmanager.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 1309,
|
|
"author": {
|
|
"id": 12076
|
|
},
|
|
"writtenOn": "2017-06-20T06:37:57Z",
|
|
"side": 1,
|
|
"message": "use helper.prepare_bottom_element to create bottom resources",
|
|
"range": {
|
|
"startLine": 1303,
|
|
"startChar": 12,
|
|
"endLine": 1309,
|
|
"endChar": 37
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_0a47fdbe",
|
|
"filename": "tricircle/xjob/xmanager.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 1309,
|
|
"author": {
|
|
"id": 21033
|
|
},
|
|
"writtenOn": "2017-06-20T07:51:30Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "7f231b9d_2468b01f",
|
|
"range": {
|
|
"startLine": 1303,
|
|
"startChar": 12,
|
|
"endLine": 1309,
|
|
"endChar": 37
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_a465e047",
|
|
"filename": "tricircle/xjob/xmanager.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 1357,
|
|
"author": {
|
|
"id": 12076
|
|
},
|
|
"writtenOn": "2017-06-20T06:37:57Z",
|
|
"side": 1,
|
|
"message": "also check if b_policy_id is None",
|
|
"range": {
|
|
"startLine": 1357,
|
|
"startChar": 8,
|
|
"endLine": 1357,
|
|
"endChar": 19
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_ca1225b5",
|
|
"filename": "tricircle/xjob/xmanager.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 1357,
|
|
"author": {
|
|
"id": 21033
|
|
},
|
|
"writtenOn": "2017-06-20T07:51:30Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "7f231b9d_a465e047",
|
|
"range": {
|
|
"startLine": 1357,
|
|
"startChar": 8,
|
|
"endLine": 1357,
|
|
"endChar": 19
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_04aa5418",
|
|
"filename": "tricircle/xjob/xmanager.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 1552,
|
|
"author": {
|
|
"id": 12076
|
|
},
|
|
"writtenOn": "2017-06-20T06:37:57Z",
|
|
"side": 1,
|
|
"message": "this part can be put into a function for the three types of rules",
|
|
"range": {
|
|
"startLine": 1520,
|
|
"startChar": 0,
|
|
"endLine": 1552,
|
|
"endChar": 76
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7f231b9d_6a8671de",
|
|
"filename": "tricircle/xjob/xmanager.py",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 1552,
|
|
"author": {
|
|
"id": 21033
|
|
},
|
|
"writtenOn": "2017-06-20T07:51:30Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "7f231b9d_04aa5418",
|
|
"range": {
|
|
"startLine": 1520,
|
|
"startChar": 0,
|
|
"endLine": 1552,
|
|
"endChar": 76
|
|
},
|
|
"revId": "bd2b648abf338670ecf6ed5cae284369d799e0d2",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |