tricircle/ea8dd4363a65ac7b7dfd998a9241398d08941f8b

{
  "comments": [
    {
      "key": {
        "uuid": "1f1a1f67_0363551c",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 22,
      "author": {
        "id": 12076
      },
      "writtenOn": "2017-07-13T08:15:25Z",
      "side": 1,
      "message": "move tricircle import block to the last",
      "range": {
        "startLine": 19,
        "startChar": 0,
        "endLine": 22,
        "endChar": 38
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "ff346bd7_b1d05e52",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 22,
      "author": {
        "id": 22787
      },
      "writtenOn": "2017-07-24T10:07:40Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "1f1a1f67_0363551c",
      "range": {
        "startLine": 19,
        "startChar": 0,
        "endLine": 22,
        "endChar": 38
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f1a1f67_f627f5b5",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 25,
      "author": {
        "id": 12076
      },
      "writtenOn": "2017-07-13T08:15:25Z",
      "side": 1,
      "message": "use neutron_lib/services/qos/base.py instead",
      "range": {
        "startLine": 25,
        "startChar": 41,
        "endLine": 25,
        "endChar": 45
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "ff346bd7_31bc6e04",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 25,
      "author": {
        "id": 22787
      },
      "writtenOn": "2017-07-24T10:07:40Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "1f1a1f67_f627f5b5",
      "range": {
        "startLine": 25,
        "startChar": 41,
        "endLine": 25,
        "endChar": 45
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f1a1f67_7612c55a",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 26,
      "author": {
        "id": 12076
      },
      "writtenOn": "2017-07-13T08:15:25Z",
      "side": 1,
      "message": "use neutron_lib/services/qos/constants.py instead",
      "range": {
        "startLine": 26,
        "startChar": 33,
        "endLine": 26,
        "endChar": 43
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "ff346bd7_7121d6b4",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 26,
      "author": {
        "id": 22787
      },
      "writtenOn": "2017-07-24T10:07:40Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "1f1a1f67_7612c55a",
      "range": {
        "startLine": 26,
        "startChar": 33,
        "endLine": 26,
        "endChar": 43
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f1a1f67_835f6540",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 35,
      "author": {
        "id": 12076
      },
      "writtenOn": "2017-07-13T08:15:25Z",
      "side": 1,
      "message": "use constant in neutron_lib/db/constants.py instead",
      "range": {
        "startLine": 35,
        "startChar": 40,
        "endLine": 35,
        "endChar": 60
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "ff346bd7_91243ac8",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 35,
      "author": {
        "id": 22787
      },
      "writtenOn": "2017-07-24T10:07:40Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "1f1a1f67_835f6540",
      "range": {
        "startLine": 35,
        "startChar": 40,
        "endLine": 35,
        "endChar": 60
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f1a1f67_e335f9f8",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 37,
      "author": {
        "id": 12076
      },
      "writtenOn": "2017-07-13T08:15:25Z",
      "side": 1,
      "message": "ditto line 35",
      "range": {
        "startLine": 37,
        "startChar": 40,
        "endLine": 37,
        "endChar": 60
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "ff346bd7_f135c6f8",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 37,
      "author": {
        "id": 22787
      },
      "writtenOn": "2017-07-24T10:07:40Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "1f1a1f67_e335f9f8",
      "range": {
        "startLine": 37,
        "startChar": 40,
        "endLine": 37,
        "endChar": 60
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f1a1f67_6321e9b4",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 39,
      "author": {
        "id": 12076
      },
      "writtenOn": "2017-07-13T08:15:25Z",
      "side": 1,
      "message": "use constant in neutron_lib/constants.py instead",
      "range": {
        "startLine": 39,
        "startChar": 38,
        "endLine": 39,
        "endChar": 54
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "ff346bd7_71cc3689",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 39,
      "author": {
        "id": 22787
      },
      "writtenOn": "2017-07-24T10:07:40Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "1f1a1f67_6321e9b4",
      "range": {
        "startLine": 39,
        "startChar": 38,
        "endLine": 39,
        "endChar": 54
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f1a1f67_e31e196f",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 42,
      "author": {
        "id": 12076
      },
      "writtenOn": "2017-07-13T08:15:25Z",
      "side": 1,
      "message": "ditto line 39",
      "range": {
        "startLine": 42,
        "startChar": 56,
        "endLine": 42,
        "endChar": 72
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "ff346bd7_11a16aaa",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 42,
      "author": {
        "id": 22787
      },
      "writtenOn": "2017-07-24T10:07:40Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "1f1a1f67_e31e196f",
      "range": {
        "startLine": 42,
        "startChar": 56,
        "endLine": 42,
        "endChar": 72
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f1a1f67_630a0927",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 46,
      "author": {
        "id": 12076
      },
      "writtenOn": "2017-07-13T08:15:25Z",
      "side": 1,
      "message": "ditto line 35",
      "range": {
        "startLine": 46,
        "startChar": 40,
        "endLine": 46,
        "endChar": 60
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "ff346bd7_51c93276",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 46,
      "author": {
        "id": 22787
      },
      "writtenOn": "2017-07-24T10:07:40Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "1f1a1f67_630a0927",
      "range": {
        "startLine": 46,
        "startChar": 40,
        "endLine": 46,
        "endChar": 60
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f1a1f67_23041117",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 47,
      "author": {
        "id": 12076
      },
      "writtenOn": "2017-07-13T08:15:25Z",
      "side": 1,
      "message": "ditto line 39",
      "range": {
        "startLine": 47,
        "startChar": 56,
        "endLine": 47,
        "endChar": 72
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "ff346bd7_31c6ae69",
        "filename": "tricircle/network/qos_driver.py",
        "patchSetId": 16
      },
      "lineNbr": 47,
      "author": {
        "id": 22787
      },
      "writtenOn": "2017-07-24T10:07:40Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "1f1a1f67_23041117",
      "range": {
        "startLine": 47,
        "startChar": 56,
        "endLine": 47,
        "endChar": 72
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f1a1f67_f6c6d516",
        "filename": "tricircle/xjob/xmanager.py",
        "patchSetId": 16
      },
      "lineNbr": 1597,
      "author": {
        "id": 12076
      },
      "writtenOn": "2017-07-13T08:15:25Z",
      "side": 1,
      "message": "It\u0027s possible that network/port not found",
      "range": {
        "startLine": 1597,
        "startChar": 23,
        "endLine": 1597,
        "endChar": 58
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f1a1f67_36fd6d3a",
        "filename": "tricircle/xjob/xmanager.py",
        "patchSetId": 16
      },
      "lineNbr": 1669,
      "author": {
        "id": 12076
      },
      "writtenOn": "2017-07-13T08:15:25Z",
      "side": 1,
      "message": "NotFound exception is suppressed by b_client so will not be raised",
      "range": {
        "startLine": 1669,
        "startChar": 32,
        "endLine": 1669,
        "endChar": 40
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f1a1f67_b9084e28",
        "filename": "tricircle/xjob/xmanager.py",
        "patchSetId": 16
      },
      "lineNbr": 1719,
      "author": {
        "id": 12076
      },
      "writtenOn": "2017-07-13T08:15:25Z",
      "side": 1,
      "message": "define key_map outside this function\n\n\nkey_map \u003d {\u0027bandwidth_limit\u0027: (\u0027max_kbps\u0027, \u0027max_burst_kbps\u0027),\n           \u0027dscp_marking\u0027: (\u0027dscp_mark\u0027),\n           \u0027minimum_bandwidth\u0027: (\u0027min_kpbs\u0027, \u0027direction\u0027)}\n\nthen this function can be simplified to\n\n\nreturn dict([(key, rule_data[key]) for key in key_map[rule_type]])",
      "range": {
        "startLine": 1718,
        "startChar": 0,
        "endLine": 1719,
        "endChar": 22
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f1a1f67_39ac3e8b",
        "filename": "tricircle/xjob/xmanager.py",
        "patchSetId": 16
      },
      "lineNbr": 1743,
      "author": {
        "id": 12076
      },
      "writtenOn": "2017-07-13T08:15:25Z",
      "side": 1,
      "message": "simplify to with key_map\n\nfor key in key_map[rule_type]:\n    if rule1[key] !\u003d rule2[key]:\n        return False\nreturn True",
      "range": {
        "startLine": 1743,
        "startChar": 0,
        "endLine": 1743,
        "endChar": 74
      },
      "revId": "ea8dd4363a65ac7b7dfd998a9241398d08941f8b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}