03ba6a92b0
Patch Set 13: (2 comments) Patch-set: 13 Label: Verified=0
98 lines
2.5 KiB
Plaintext
98 lines
2.5 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "3f1d235d_e2a9ac23",
|
|
"filename": "tricircle/network/qos.py",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 33,
|
|
"author": {
|
|
"id": 12076
|
|
},
|
|
"writtenOn": "2017-07-07T02:25:43Z",
|
|
"side": 1,
|
|
"message": "I think no need for this plugin, you have implemented a driver",
|
|
"range": {
|
|
"startLine": 33,
|
|
"startChar": 6,
|
|
"endLine": 33,
|
|
"endChar": 24
|
|
},
|
|
"revId": "ee0776bc222fe7fc28d0586dedef63b0ca0fc2fe",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3f1d235d_5e611739",
|
|
"filename": "tricircle/network/qos.py",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 33,
|
|
"author": {
|
|
"id": 21033
|
|
},
|
|
"writtenOn": "2017-07-10T14:31:15Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "3f1d235d_e2a9ac23",
|
|
"range": {
|
|
"startLine": 33,
|
|
"startChar": 6,
|
|
"endLine": 33,
|
|
"endChar": 24
|
|
},
|
|
"revId": "ee0776bc222fe7fc28d0586dedef63b0ca0fc2fe",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3f1d235d_829af810",
|
|
"filename": "tricircle/network/qos_driver.py",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 143,
|
|
"author": {
|
|
"id": 12076
|
|
},
|
|
"writtenOn": "2017-07-07T02:25:43Z",
|
|
"side": 1,
|
|
"message": "I see that the definition of DRIVER in previous patches is removed, I think this will cause error.",
|
|
"range": {
|
|
"startLine": 143,
|
|
"startChar": 4,
|
|
"endLine": 143,
|
|
"endChar": 17
|
|
},
|
|
"revId": "ee0776bc222fe7fc28d0586dedef63b0ca0fc2fe",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3f1d235d_7e1df3bb",
|
|
"filename": "tricircle/network/qos_driver.py",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 143,
|
|
"author": {
|
|
"id": 21033
|
|
},
|
|
"writtenOn": "2017-07-10T14:31:15Z",
|
|
"side": 1,
|
|
"message": "can you explain it in detail?",
|
|
"parentUuid": "3f1d235d_829af810",
|
|
"range": {
|
|
"startLine": 143,
|
|
"startChar": 4,
|
|
"endLine": 143,
|
|
"endChar": 17
|
|
},
|
|
"revId": "ee0776bc222fe7fc28d0586dedef63b0ca0fc2fe",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |