openstack
/
tripleo-ansible
Code Issues Proposed changes

Improve error messag if subnet is not found 

If a subnet that does not exist the error returned is:
 "Error managing network ports 'intenal_api_leaf2'"

This patch improves this by raising a more informative
error message.

Change-Id: Ic52d8c630d809efdabd10ec921deff83bbcd86bf
(cherry picked from commit 5558f97b2c)
This commit is contained in:
Harald Jensås 2022-02-11 01:45:21 +01:00
parent a6813adb56
commit 060c0ce5ce
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tripleo_ansible/ansible_plugins/modules/tripleo_overcloud_network_ports.py
View File

@ -316,7 +316,12 @@ def generate_port_defs(net_maps, instance, inst_ports):
fixed_ips = [{'ip_address': net['fixed_ip']}]
else:
if net.get('subnet'):
subnet_id = subnet_name_map[net['subnet']]
try:
subnet_id = subnet_name_map[net['subnet']]
except KeyError:
raise Exception(
'Subnet {subnet} not found on network {net_name}'
.format(subnet=net['subnet'], net_name=net_name))
elif len(net_maps['by_name'][net_name]['subnets']) == 1:
subnet_id = next(iter(subnet_name_map.values()))
else: