openstack
/
tripleo-ansible
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 6926 \u003c6926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_6926\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 18002 \u003c18002@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_6926\u003e replied on the change"}
This commit is contained in:
Gerrit User 6926 2022-10-07 14:57:00 +00:00 committed by Gerrit Code Review
parent 460b9e54f0
commit 184db99ad4
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
f8e2d3dc11a3659ee4a69532cdbaad1e7d4f214a
View File

@ -46,6 +46,30 @@
},
"revId": "f8e2d3dc11a3659ee4a69532cdbaad1e7d4f214a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "84e14c69_caeacc26",
"filename": "tripleo_ansible/roles/tripleo_ceph_client/tasks/multiple_external_ceph_clusters.yml",
"patchSetId": 1
},
"lineNbr": 25,
"author": {
"id": 6926
},
"writtenOn": "2022-10-07T14:57:00Z",
"side": 1,
"message": "meant to say\n\ndefault(multiple.tripleo_ceph_cluster_name, true)?\n\nso that it fails back also when tripleo_ceph_client_cluster is an empty string (which seems an expected case, according to https://review.opendev.org/c/openstack/tripleo-ansible/+/859149/1/tripleo_ansible/roles/tripleo_ceph_client/defaults/main.yml#25 )",
"parentUuid": "4361f6c6_1889a344",
"range": {
"startLine": 22,
"startChar": 0,
"endLine": 25,
"endChar": 107
},
"revId": "f8e2d3dc11a3659ee4a69532cdbaad1e7d4f214a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}