From 79f41d1d41a23b8b851410a912fd352c5e6fac32 Mon Sep 17 00:00:00 2001 From: Alex Schultz Date: Thu, 14 Nov 2019 09:38:34 -0700 Subject: [PATCH] Don't fail hard when facter cache doesn't work correctly Since the facter cache is supposed to be a help but not necessarily a hard requirement, let's make sure the tasks don't fail if something goes wrong. We should output the error if the facter execution fails, but we don't want to always output it. Change-Id: I58d42c74295f031b260c0b67dbc12336fc31db1f Related-Bug: #1852606 --- tripleo_ansible/roles/tripleo-puppet-cache/tasks/main.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tripleo_ansible/roles/tripleo-puppet-cache/tasks/main.yml b/tripleo_ansible/roles/tripleo-puppet-cache/tasks/main.yml index c7e3d4ee3..2caf0971c 100644 --- a/tripleo_ansible/roles/tripleo-puppet-cache/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo-puppet-cache/tasks/main.yml @@ -83,6 +83,13 @@ command: facter --config "{{ tripleo_puppet_cache_base_dir }}/facter.conf" no_log: true ignore_errors: true + register: _facter_cache_run + +- name: Facter error output when failed + check_mode: false + debug: + msg: "{{ _facter_cache_run.stderr }}" + when: _facter_cache_run is failed - name: Sync cached facts become: true @@ -91,3 +98,4 @@ src: "/opt/puppetlabs/" dest: "{{ tripleo_puppet_cache_base_dir }}/" delegate_to: "{{ inventory_hostname }}" + when: _facter_cache_run is succeeded