openstack
/
tripleo-ansible
Code Issues Proposed changes

Add idempotency for networks parameter in podman_container 

Change-Id: Ib7235d1cb64ad0f42e7a0201008536e1a35bd696
This commit is contained in:
Sagi Shnaidman 2019-11-25 16:57:47 +02:00
parent 7bb5baa64e
commit 25f8abbc5a
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tripleo_ansible/ansible_plugins/modules/podman_container.py
View File

@ -1313,6 +1313,8 @@ class PodmanDefaults:
"memory_reservation": "0",
# "memory_swappiness": -1,
"no_hosts": False,
# libpod issue with networks in inspection
"network": ["default"],
"oom_score_adj": 0,
"pid": "",
"privileged": False,
@ -1350,7 +1352,6 @@ class PodmanContainerDiff:
'env_file',
'env_host',
'stop_timeout',
"network", # Issue in libpod
"ulimit", # Defaults depend on user and platform, impossible to guess
}
self.all_caps = ['cap_audit_control',
@ -1656,6 +1657,11 @@ class PodmanContainerDiff:
after = self.params['memory_reservation']
return self._diff_update_and_compare('memory_reservation', before, after)
def diffparam_network(self):
before = [self.info['hostconfig']['networkmode']]
after = self.params['network']
return self._diff_update_and_compare('network', before, after)
def diffparam_no_hosts(self):
before = not bool(self.info['hostspath'])
after = self.params['no_hosts']