From 51ac23cebe3ba6fc296350d54cc8e4cdfee75990 Mon Sep 17 00:00:00 2001 From: Emilien Macchi Date: Tue, 7 Apr 2020 10:33:02 -0400 Subject: [PATCH] tripleo_container_manage: add check mode testing Add more molecule coverage by running the role in check mode. Change-Id: I9b73c19b1d9449e1c0956673bcb2114675920f97 --- .../molecule/default/converge.yml | 22 +++++++++++++++++++ .../molecule/default/molecule.yml | 2 +- 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/tripleo_ansible/roles/tripleo_container_manage/molecule/default/converge.yml b/tripleo_ansible/roles/tripleo_container_manage/molecule/default/converge.yml index 09137da7d..95e551f78 100644 --- a/tripleo_ansible/roles/tripleo_container_manage/molecule/default/converge.yml +++ b/tripleo_ansible/roles/tripleo_container_manage/molecule/default/converge.yml @@ -29,6 +29,8 @@ name: tripleo_container_manage post_tasks: - name: Verify that Fedora container was created correctly + when: + - not ansible_check_mode|bool block: - name: Check for fedora container command: podman container exists fedora @@ -103,12 +105,16 @@ podman_container_info: name: fedora register: fedora_infos_old + when: + - not ansible_check_mode|bool - include_role: name: tripleo_container_manage - name: Gather facts about fedora container after new run podman_container_info: name: fedora register: fedora_infos_new + when: + - not ansible_check_mode|bool post_tasks: - name: Assert that fedora container has not been re-created assert: @@ -116,6 +122,8 @@ - fedora_infos_new == fedora_infos_old fail_msg: 'fedora container was wrongly re-created' success_msg: 'fedora container was not re-created' + when: + - not ansible_check_mode|bool - name: Manage only one container become: true @@ -133,6 +141,8 @@ name: tripleo_container_manage post_tasks: - name: Verify that all containers still exist + when: + - not ansible_check_mode|bool block: - name: Check for fedora container command: podman container exists fedora @@ -182,6 +192,8 @@ name: tripleo_container_manage post_tasks: - name: Verify that all containers still exist + when: + - not ansible_check_mode|bool block: - name: Check for fedora container command: podman container exists fedora @@ -226,6 +238,8 @@ name: tripleo_container_manage post_tasks: - name: Verify that all containers still exist + when: + - not ansible_check_mode|bool block: - name: Check that fedora container was removed command: podman container exists fedora @@ -267,6 +281,8 @@ name: tripleo_container_manage post_tasks: - name: Verify that Fedora bis container was re-created correctly + when: + - not ansible_check_mode|bool block: - name: Check for fedora_bis container command: podman container exists fedora_bis @@ -282,6 +298,8 @@ success_msg: 'fedora_bis container has the right image' - name: Check for fedora_three container command: podman container exists fedora_three + when: + - not ansible_check_mode|bool - name: Test a container config override become: true @@ -300,6 +318,8 @@ name: tripleo_container_manage post_tasks: - name: Verify that Fedora bis container was re-created correctly + when: + - not ansible_check_mode|bool block: - name: Check for fedora_bis container command: podman container exists fedora_bis @@ -315,3 +335,5 @@ success_msg: 'fedora_bis container has the right image' - name: Check for fedora_three container command: podman container exists fedora_three + when: + - not ansible_check_mode|bool diff --git a/tripleo_ansible/roles/tripleo_container_manage/molecule/default/molecule.yml b/tripleo_ansible/roles/tripleo_container_manage/molecule/default/molecule.yml index 006e9ffef..330d0097e 100644 --- a/tripleo_ansible/roles/tripleo_container_manage/molecule/default/molecule.yml +++ b/tripleo_ansible/roles/tripleo_container_manage/molecule/default/molecule.yml @@ -44,7 +44,7 @@ scenario: test_sequence: - prepare - converge - - verify + - check verifier: name: testinfra