Check that facter.conf is a file

If docker-puppet.py (or container-puppet.py) is run under docker prior
to the facter config being generated, the file is created as a
directory. This causes a failure later when we try to write the file
out.

Change-Id: I9b5a1e06e73b3b4cfc0ebfaeba8f1eb4b5d6fcfe
Closes-Bug: #1852606

tripleo_ansible/roles/tripleo-puppet-cache/tasks/main.yml

@@ -42,6 +42,24 @@
     selevel: s0
     recurse: true
 
+- name: Check for facter.conf
+  check_mode: false
+  stat:
+    path: "{{ tripleo_puppet_cache_base_dir }}/facter.conf"
+  register: _facter_conf_file
+
+# See LP#1852606 for context
+- name: Remove facter.conf if directory
+  check_mode: false
+  become: true
+  file:
+    path: "{{ tripleo_puppet_cache_base_dir }}/facter.conf"
+    state: absent
+    force: true
+  when:
+    - _facter_conf_file.stat.isdir is defined
+    - _facter_conf_file.stat.isdir
+
 - name: Write facter cache config
   become: true
   check_mode: false