openstack
/
tripleo-ansible
Code Issues Proposed changes

Do not inherit the calling ansible env by default 

As per I428f6deb416b540dae552b5fc7a778cbc7505e8c ANSIBLE_*
environment variables are passed to Ansible executions which
are used to deploy Ceph.

The method of inheritance is fragile and possibly unsafe. This
patch disables inheritance by default. In inheritance feature
can be made more safe in subsequent patches for Related-Bug but
but this new default should stay.

Change-Id: Ifa6d147664fc993ca08c8fb2efa860f7605628cb
Fixes-Bug: #1863629
This commit is contained in:
John Fulton 2020-02-17 14:51:52 -05:00
parent 3c4078cd62
commit 692678dce5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tripleo_ansible/roles/tripleo_ceph_common/defaults/main.yml
View File

@ -133,4 +133,4 @@ swift_get_url: ''
swift_put_url: ''
ceph_ansible_skip_tags: 'package-install,with_pkg'
ceph_ansible_environment_variables: []
ceph_ansible_inherits_calling_ansible_environment: true
ceph_ansible_inherits_calling_ansible_environment: false