fix all tripleo_container_* molecule jobs on centos8

- --systemd needs to be given with a string (default to true, so since
  we used that argument we want true).
- Add fedora registry in the list of container registries to strip when
  figuring out what image is deployed  in podman_container (for
  idempotency). This code should be improved in a future patch to stop
  hardcoding these registries and find another way to figure out the
  image name.

Change-Id: If0d4cc6590105808a07569b60877eb440f1dd6d1
Closes-Bug: #1867787

tripleo_ansible/ansible_plugins/modules/podman_container.py

@@ -1524,6 +1524,7 @@ class PodmanContainerDiff:
         strip_from_name = [
             "docker.io/library/",
             "docker.io/",
+            "registry.fedoraproject.org/",
             ":latest",
         ]
         for repl in strip_from_name:

tripleo_ansible/roles/tripleo_container_rm/molecule/legacy_vars/prepare.yml

@@ -35,7 +35,7 @@
       command: "podman pull centos:8"
 
     - name: Create test containers
-      command: "podman run -itd --systemd --name {{ item }} fedora bash"
+      command: "podman run -itd --systemd true --name {{ item }} fedora bash"
       with_items:
         - podman-legacy-container1
         - podman-legacy-container2

tripleo_ansible/roles/tripleo_container_rm/molecule/podman-rm-stopped/prepare.yml

@@ -35,7 +35,7 @@
       command: "podman pull centos:8"
 
     - name: Create test containers
-      command: "podman run -itd --systemd --name {{ item }} fedora bash"
+      command: "podman run -itd --systemd true --name {{ item }} fedora bash"
       with_items:
         - podman-container1
         - podman-container2

tripleo_ansible/roles/tripleo_container_rm/molecule/podman/prepare.yml

@@ -35,7 +35,7 @@
       command: "podman pull centos:8"
 
     - name: Create test containers
-      command: "podman run -itd --systemd --name {{ item }} fedora bash"
+      command: "podman run -itd --systemd true --name {{ item }} fedora bash"
       with_items:
         - podman-container1
         - podman-container2

tripleo_ansible/roles/tripleo_container_stop/molecule/podman/prepare.yml

@@ -35,7 +35,7 @@
       command: "podman pull centos:8"
 
     - name: Create test containers
-      command: "podman run -itd --systemd --name {{ item }} fedora bash"
+      command: "podman run -itd --systemd true --name {{ item }} fedora bash"
       with_items:
         - podman-container1
         - podman-container2

zuul.d/molecule.yaml

@@ -236,7 +236,6 @@
     parent: tripleo-ansible-centos-8-base
     vars:
       tripleo_role_name: tripleo_container_manage
-    voting: false
 - job:
     files:
     - ^tripleo_ansible/roles/tripleo_container_rm/.*
@@ -244,7 +243,6 @@
     parent: tripleo-ansible-centos-8-base
     vars:
       tripleo_role_name: tripleo_container_rm
-    voting: false
 - job:
     files:
     - ^tripleo_ansible/roles/tripleo_container_stop/.*
@@ -252,7 +250,6 @@
     parent: tripleo-ansible-centos-8-base
     vars:
       tripleo_role_name: tripleo_container_stop
-    voting: false
 - job:
     files:
     - ^tripleo_ansible/roles/tripleo_container_tag/.*