openstack
/
tripleo-ansible
Code Issues Proposed changes

tripleo-keystone-resources: hide logs for resources with passwords 

Hide the logs for the modules where we use data that shows the password when
creating a user, this isn't good for the security.
Let's hide it with no_log: true.

Change-Id: Icc80c239f507a1a4e50298345a94aba4fabed80d
This commit is contained in:
Emilien Macchi 2020-02-07 21:29:51 -05:00
parent 2b1e1eda6f
commit 6f77ee5e7b
4 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tripleo_ansible/roles/tripleo_keystone_resources/tasks/admin.yml
View File

@ -39,6 +39,7 @@
- keystone_enable_member | default(tripleo_keystone_resources_member_role_enabled) - keystone_enable_member | default(tripleo_keystone_resources_member_role_enabled)
- name: Create admin user - name: Create admin user
no_log: true
os_user: os_user:
cloud: "{{ tripleo_keystone_resources_cloud_name }}" cloud: "{{ tripleo_keystone_resources_cloud_name }}"
name: admin name: admin

2
tripleo_ansible/roles/tripleo_keystone_resources/tasks/endpoints.yml
View File

@ -15,6 +15,7 @@
# under the License. # under the License.
- name: "Async creation of Keystone {{ keystone_endpoint_type }} endpoint" - name: "Async creation of Keystone {{ keystone_endpoint_type }} endpoint"
no_log: true
os_keystone_endpoint: os_keystone_endpoint:
cloud: "{{ tripleo_keystone_resources_cloud_name }}" cloud: "{{ tripleo_keystone_resources_cloud_name }}"
service: "{{ tripleo_keystone_resources_data.key }}" service: "{{ tripleo_keystone_resources_data.key }}"
@ -30,6 +31,7 @@
loop_var: tripleo_keystone_resources_data loop_var: tripleo_keystone_resources_data
- name: "Check Keystone {{ keystone_endpoint_type }} endpoint status" - name: "Check Keystone {{ keystone_endpoint_type }} endpoint status"
no_log: true
async_status: async_status:
jid: "{{ tripleo_keystone_resources_endpoint_async_result_item.ansible_job_id }}" jid: "{{ tripleo_keystone_resources_endpoint_async_result_item.ansible_job_id }}"
loop: "{{ tripleo_keystone_resources_endpoint_results.results }}" loop: "{{ tripleo_keystone_resources_endpoint_results.results }}"

2
tripleo_ansible/roles/tripleo_keystone_resources/tasks/services.yml
View File

@ -15,6 +15,7 @@
# under the License. # under the License.
- name: Async creation of Keystone service - name: Async creation of Keystone service
no_log: true
os_keystone_service: os_keystone_service:
cloud: "{{ tripleo_keystone_resources_cloud_name }}" cloud: "{{ tripleo_keystone_resources_cloud_name }}"
name: "{{ tripleo_keystone_resources_data.key }}" name: "{{ tripleo_keystone_resources_data.key }}"
@ -29,6 +30,7 @@
loop_var: tripleo_keystone_resources_data loop_var: tripleo_keystone_resources_data
- name: Check Keystone service status - name: Check Keystone service status
no_log: true
async_status: async_status:
jid: "{{ tripleo_keystone_resources_service_async_result_item.ansible_job_id }}" jid: "{{ tripleo_keystone_resources_service_async_result_item.ansible_job_id }}"
loop: "{{ tripleo_keystone_resources_service_results.results }}" loop: "{{ tripleo_keystone_resources_service_results.results }}"

2
tripleo_ansible/roles/tripleo_keystone_resources/tasks/users.yml
View File

@ -15,6 +15,7 @@
# under the License. # under the License.
- name: "Async creation of Keystone user" - name: "Async creation of Keystone user"
no_log: true
os_user: os_user:
cloud: "{{ tripleo_keystone_resources_cloud_name }}" cloud: "{{ tripleo_keystone_resources_cloud_name }}"
name: "{{ lookup('dict', tripleo_keystone_resources_data).key }}" name: "{{ lookup('dict', tripleo_keystone_resources_data).key }}"
@ -30,6 +31,7 @@
loop_var: tripleo_keystone_resources_data loop_var: tripleo_keystone_resources_data
- name: "Check Keystone user status" - name: "Check Keystone user status"
no_log: true
async_status: async_status:
jid: "{{ tripleo_keystone_resources_user_async_result_item.ansible_job_id }}" jid: "{{ tripleo_keystone_resources_user_async_result_item.ansible_job_id }}"
loop: "{{ tripleo_keystone_resources_user_results.results }}" loop: "{{ tripleo_keystone_resources_user_results.results }}"