Merge "bnr - backup of the control plane in composable roles deployment"

tripleo_ansible/playbooks/cli-overcloud-backup.yaml

@@ -30,16 +30,17 @@
   tasks:
     - assert:
         that:
-          - tripleo_controller_group_name in groups
-          - ( groups[tripleo_controller_group_name] | length ) > 0
-        fail_msg: "There is no server on {{ tripleo_controller_group_name }} groups"
+          - item in groups
+          - ( groups[item] | length ) > 0
+        fail_msg: "There is no server on {{ item }} groups"
+      with_items: "{{ tripleo_controller_group_name }}"
       tags:
         - bar_create_recover_image
 
 - name: TripleO Controller backup
   hosts: '{{ tripleo_controller_group_name }}'
   remote_user: "{{ tripleo_target_user | default(lookup('env', 'USER')) }}"
-  serial: "{{ tripleo_backup_and_restore_enable_snapshots|bool | ternary(1, groups[tripleo_controller_group_name]|length) }}"
+  serial: "{{ (tripleo_controller_group_name|length > 1) or (tripleo_backup_and_restore_enable_snapshots|bool) | ternary(1, groups[tripleo_controller_group_name]|length) }}"
   vars_files:
     ../roles/backup_and_restore/defaults/main.yml
   become: true

tripleo_ansible/roles/backup_and_restore/molecule/default/prepare.yml

@@ -41,6 +41,7 @@
       test_deps_setup_tripleo: true
       test_deps_tripleo_packages:
         - hiera
+        - puppet-tripleo
       test_deps_extra_packages:
         - rear
         - syslinux

tripleo_ansible/roles/backup_and_restore/tasks/main.yml

@@ -32,6 +32,36 @@
   tags:
     - always
 
+- name: Getting enabled_services
+  command: |
+    puppet lookup --node agent.local --explain enabled_services
+  register: tripleo_backup_and_restore_enabled_services
+  tags:
+    - bar_create_recover_image
+
+- name: Set pacemaker variable as false by default
+  set_fact:
+    pacemaker_enabled: false
+  tags:
+    - bar_create_recover_image
+
+- name: Check pacemaker status
+  block:
+  - name:
+    command: |
+      pcs status
+    register: pacemaker_result
+    failed_when:
+      - '"error running crm_mon" not in pacemaker_result.stderr'
+      - pacemaker_result.stderr| length > 0
+
+  - name: Set pacemaker variable
+    set_fact:
+      pacemaker_enabled: "{{ pacemaker_result.rc == 0| ternary(true,false) }}"
+  when: tripleo_backup_and_restore_enabled_services.stdout is search('pacemaker')
+  tags:
+    - bar_create_recover_image
+
 - name: Setup NFS server
   import_tasks: setup_nfs.yml
 
@@ -46,9 +76,11 @@
 
 - name: Backup the database
   import_tasks: db_backup.yml
+  when: tripleo_backup_and_restore_enabled_services.stdout is search('mysql^')
 
 - name: Backup pacemaker configuration
   import_tasks: pacemaker_backup.yml
+  when: pacemaker_enabled
 
 - name: Perform backup
   block:

tripleo_ansible/roles/backup_and_restore/tasks/pacemaker_backup.yml

@@ -15,19 +15,6 @@
 # under the License.
 #
 
-- name: Getting enabled_services
-  command: |
-    hiera -c "{{ tripleo_backup_and_restore_hiera_config_file }}" 'enabled_services'
-  register: tripleo_backup_and_restore_enabled_services
-  tags:
-    - bar_create_recover_image
-
-- name: Set pacemaker enable variable
-  set_fact:
-    pacemaker_enabled: "{{ (tripleo_backup_and_restore_enabled_services.stdout is search('pacemaker')) |  ternary(true,false) }}"
-  tags:
-    - bar_create_recover_image
-
 - name: Delete previous backup files if exists
   file:
     path: "{{ item }}"

tripleo_ansible/roles/backup_and_restore/tasks/run_backup.yml

@@ -35,6 +35,7 @@
 - name: Take this node out of pacemaker
   command: pcs cluster stop --request-timeout={{ tripleo_backup_and_restore_pcs_timeout }}
   when:
+    - tripleo_backup_and_restore_enabled_services.stdout is search('pacemaker')
     - pacemaker_enabled
     - tripleo_backup_and_restore_enable_snapshots|bool
   tags: