openstack
/
tripleo-ansible
Code Issues Proposed changes

Update patch set 53 

Patch Set 53:

(2 comments)

Patch-set: 53
Attention: {"person_ident":"Gerrit User 30073 \u003c30073@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_30073\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 6816 \u003c6816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_30073\u003e replied on the change"}
This commit is contained in:
Gerrit User 30073 2022-10-07 12:15:52 +00:00 committed by Gerrit Code Review
parent 05f19d044a
commit 89cf35d713
1 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
4d191bc496cc79ef1e494960ea70d2700aedcd48
View File

@ -23,6 +23,30 @@
"revId": "4d191bc496cc79ef1e494960ea70d2700aedcd48",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5df368dc_e9fb01f0",
"filename": "tripleo_ansible/roles/tripleo_ovn/defaults/main.yml",
"patchSetId": 53
},
"lineNbr": 33,
"author": {
"id": 30073
},
"writtenOn": "2022-10-07T12:15:52Z",
"side": 1,
"message": "I don\u0027t think so? I haven\u0027t had any issues with them like this, unless you have found something?",
"parentUuid": "dd889fad_737d3259",
"range": {
"startLine": 33,
"startChar": 2,
"endLine": 33,
"endChar": 12
},
"revId": "4d191bc496cc79ef1e494960ea70d2700aedcd48",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -39,6 +63,24 @@
"message": "this change means we need tripleo_ovn_dbs set in the inventory somewhere. I\u0027ll give it a default value there.",
"revId": "4d191bc496cc79ef1e494960ea70d2700aedcd48",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b2dbdc35_365c57fb",
"filename": "tripleo_ansible/roles/tripleo_ovn/defaults/main.yml",
"patchSetId": 53
},
"lineNbr": 40,
"author": {
"id": 30073
},
"writtenOn": "2022-10-07T12:15:52Z",
"side": 1,
"message": "We definitely need this value yeah. We could probably determine it from the Controller node IPs though.",
"parentUuid": "c893edad_e86341d9",
"revId": "4d191bc496cc79ef1e494960ea70d2700aedcd48",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}