From 0007e05c789fbf1eb0da2a5b10135d97facd56b0 Mon Sep 17 00:00:00 2001 From: Rabi Mishra Date: Tue, 7 Apr 2020 10:49:14 +0530 Subject: [PATCH] Don't call sdk.connect() again openstack_cloud_from_module() returns a connection object. Change-Id: Icda289b76b8b57857e6ace521c7984b70ba04392 --- .../modules/baremetal_register_or_update_nodes.py | 3 +-- .../ansible_plugins/modules/os_tripleo_baremetal_configure.py | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/tripleo_ansible/ansible_plugins/modules/baremetal_register_or_update_nodes.py b/tripleo_ansible/ansible_plugins/modules/baremetal_register_or_update_nodes.py index 58c319002..3e95a69aa 100644 --- a/tripleo_ansible/ansible_plugins/modules/baremetal_register_or_update_nodes.py +++ b/tripleo_ansible/ansible_plugins/modules/baremetal_register_or_update_nodes.py @@ -105,8 +105,7 @@ def run_module(): **openstack_module_kwargs() ) - sdk, _ = openstack_cloud_from_module(module) - conn = sdk.connect() + _, conn = openstack_cloud_from_module(module) session = conn.session # if the user is working with this module in only check mode we do not diff --git a/tripleo_ansible/ansible_plugins/modules/os_tripleo_baremetal_configure.py b/tripleo_ansible/ansible_plugins/modules/os_tripleo_baremetal_configure.py index 4875214f5..b4f286127 100644 --- a/tripleo_ansible/ansible_plugins/modules/os_tripleo_baremetal_configure.py +++ b/tripleo_ansible/ansible_plugins/modules/os_tripleo_baremetal_configure.py @@ -124,8 +124,7 @@ def main(): **openstack_module_kwargs() ) - sdk, _ = openstack_cloud_from_module(module) - conn = sdk.connect() + _, conn = openstack_cloud_from_module(module) tripleo = TripleOCommon(session=conn.session) if hasattr(tripleo, module.params["action"]):