openstack
/
tripleo-ansible
Code Issues Proposed changes

More descriptive task names 

As highlighted by marios on [1] and [2] the task names were
not descriptive of what it was being done, as it implied that some kind
of verification was being done.

This patch does not change any functionality, but it changes the names
of the tasks to something more according to what it is being done.

[1] https://review.opendev.org/c/openstack/tripleo-ansible/+/791450/12/tripleo_ansible/roles/backup_and_restore/tasks/ceph_authentication.yml
[2] https://review.opendev.org/c/openstack/tripleo-ansible/+/791450/12/tripleo_ansible/roles/backup_and_restore/tasks/db_backup.yml

Change-Id: I19445ffd1c8d35972fbf8ea3da4a9fbe599f6127
(cherry picked from commit 138f9f6708)
(cherry picked from commit d3e2068b79)
This commit is contained in:
Juan Larriba 2021-06-11 12:20:00 +02:00
parent f196d2c8ab
commit c00065f76e
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tripleo_ansible/roles/backup_and_restore/tasks/ceph_authentication.yml
View File

@ -32,7 +32,7 @@
tags:
- always
- name: Unpause ceph mon container if paused
- name: Ensure cephmon container is running
command: "{{ tripleo_container_cli }} unpause ceph-mon-{{ ansible_facts['hostname'] }}"
failed_when: false
tags:

4
tripleo_ansible/roles/backup_and_restore/tasks/db_backup.yml
View File

@ -48,7 +48,7 @@
tags:
- bar_create_recover_image
- name: Enable pacemaker if it is stopped
- name: Ensure pacemaker is running
command: pcs cluster start --all
when:
- enabled_galera
@ -90,7 +90,7 @@
tags:
- bar_create_recover_image
- name: Unpause mysql for backup if it is paused
- name: Ensure mysql container is running
command: "{{ tripleo_container_cli }} unpause {{ tripleo_backup_and_restore_mysql_container }}"
when:
- mysql_password.stderr is defined