From c0bc395ab494ee18e77fba608cdd40762c7b8c51 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Jeanneret?= <cjeanner@redhat.com>
Date: Tue, 8 Nov 2022 15:50:29 +0100
Subject: [PATCH] Move cryprography pin

This moves the cryptography pin to ansible-requirements.txt
which is used as a constraints file[1].

[1] https://opendev.org/openstack/tripleo-ansible/src/branch/master/zuul.d/playbooks/pre.yml#L42

Related-Bug: #1995608
Change-Id: I646cd49b614a9f494e77f9893521d3c070900ed5
---
 ansible-requirements.txt                                       | 1 +
 molecule-requirements.txt                                      | 2 +-
 tox.ini                                                        | 3 ++-
 .../molecule/default/start_keystone.sh                         | 1 -
 zuul.d/playbooks/run-role-addition.yml                         | 1 +
 5 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/ansible-requirements.txt b/ansible-requirements.txt
index ea2c37a1b..ccc2856a7 100644
--- a/ansible-requirements.txt
+++ b/ansible-requirements.txt
@@ -1,4 +1,5 @@
 ansible-core<2.12.0
+cryptography<37.0.0
 metalsmith>=1.4.0 # Apache-2.0
 importlib-metadata
 jsonschema  # MIT
diff --git a/molecule-requirements.txt b/molecule-requirements.txt
index b37a9c13c..503721e73 100644
--- a/molecule-requirements.txt
+++ b/molecule-requirements.txt
@@ -14,7 +14,7 @@ molecule-podman>=1.0.0a1
 ruamel.yaml
 netaddr
 jinja2
-cryptography<37.0.0
+cryptography
 
 ansible-core<2.12.0
 
diff --git a/tox.ini b/tox.ini
index d4fd4f566..09a1959a6 100644
--- a/tox.ini
+++ b/tox.ini
@@ -100,7 +100,8 @@ sitepackages = False
 [testenv:role-addition]
 basepython = python3
 deps =
-   {[testenv:linters]deps}
+   pre-commit
+   virtualenv
    -r {toxinidir}/molecule-requirements.txt
    -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
 commands =
diff --git a/tripleo_ansible/roles/tripleo_keystone_resources/molecule/default/start_keystone.sh b/tripleo_ansible/roles/tripleo_keystone_resources/molecule/default/start_keystone.sh
index a6b618dd2..2d3381787 100755
--- a/tripleo_ansible/roles/tripleo_keystone_resources/molecule/default/start_keystone.sh
+++ b/tripleo_ansible/roles/tripleo_keystone_resources/molecule/default/start_keystone.sh
@@ -3,7 +3,6 @@ set -x
 
 ### Openstack Keystone
 
-: ${OS_RELEASE:=queens}
 : ${IPADDR:=127.0.0.1}
 # Identity service configuration
 : ${OS_IDENTITY_URL_IPADDR:=$IPADDR}
diff --git a/zuul.d/playbooks/run-role-addition.yml b/zuul.d/playbooks/run-role-addition.yml
index 33b8388e9..423535b7c 100644
--- a/zuul.d/playbooks/run-role-addition.yml
+++ b/zuul.d/playbooks/run-role-addition.yml
@@ -1,5 +1,6 @@
 ---
 - hosts: localhost
+  connection: local
   tasks:
     - name: set basic zuul fact
       set_fact: