Remove all ignore_errors to avoid confusion when debugging

- octavia_controller_post_config: remove "ignore_errors: true". It's not
  supposed to be needed, since there is already a
  "failed_when: config_contents.rc != 0" which knows when to fail.

- octavia_undercloud, tripleo_cellv2, tripleo_ceph_common,
  tripleo_container_manage, tripleo_packages and tripleo_puppet_cache:
  replace "ignore_errors: true" by "failed_when: false" for debugging
  experience. We know the tasks can fail and we don't care, let's just
  not show them as failures in that case and force the task to never
  fail.

- tripleo_podman: instead of ignoring errors, check if the config file
  actually exists before wipping it out.

Change-Id: Ib3716e4823735a9db9bd3cac33b8daf0e5f3d186
This commit is contained in:
Emilien Macchi
2020-03-03 18:44:56 -05:00
parent be80cd7ac6
commit c1959707db
10 changed files with 25 additions and 22 deletions

View File

@@ -22,7 +22,6 @@
register: config_contents
failed_when: config_contents.rc != 0
changed_when: false
ignore_errors: true
- name: retrieve current ip list
set_fact:
@@ -54,7 +53,7 @@
become_user: root
shell: |
systemctl is-active --quiet {{ item }} && echo {{ item }}
ignore_errors: true
failed_when: false
register: octavia_active_services
loop:
- tripleo_octavia_api