openstack/tripleo-ansible
Code Issues Proposed changes

Remove all ignore_errors to avoid confusion when debugging

Browse Source 
- octavia_controller_post_config: remove "ignore_errors: true". It's not
  supposed to be needed, since there is already a
  "failed_when: config_contents.rc != 0" which knows when to fail.

- octavia_undercloud, tripleo_cellv2, tripleo_ceph_common,
  tripleo_container_manage, tripleo_packages and tripleo_puppet_cache:
  replace "ignore_errors: true" by "failed_when: false" for debugging
  experience. We know the tasks can fail and we don't care, let's just
  not show them as failures in that case and force the task to never
  fail.

- tripleo_podman: instead of ignoring errors, check if the config file
  actually exists before wipping it out.

Change-Id: Ib3716e4823735a9db9bd3cac33b8daf0e5f3d186
This commit is contained in:
Emilien Macchi
2020-03-03 18:44:56 -05:00
parent be80cd7ac6
commit c1959707db
10 changed files with 25 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tripleo_ansible/roles/tripleo_ceph_common/tasks/main.yml
View File

@@ -39,7 +39,7 @@
- name: get all ansible environment variables
shell: "env | grep ^ANSIBLE_"
register: env_shell_output
ignore_errors: true
failed_when: false
delegate_to: localhost
connection: local
run_once: true