From dac34d302c336192f9f5fa13d2723b991d78ec12 Mon Sep 17 00:00:00 2001 From: Luke Short Date: Thu, 23 Jan 2020 17:22:22 -0500 Subject: [PATCH] Generate the /etc/hosts content once. This resolves a performance penalty of rendering many hosts files for large deployments. Since they should all match, we now generate the hosts block once and then push it out to all of the nodes. Change-Id: Iff6db6a520b9ff7fbb737a1ddb69c66cc2008ea7 Closes-Bug: #1860146 Signed-off-by: Luke Short --- .../tripleo_hosts_entries/tasks/main.yml | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/tripleo_ansible/roles/tripleo_hosts_entries/tasks/main.yml b/tripleo_ansible/roles/tripleo_hosts_entries/tasks/main.yml index bcae0eb8a..400f3dbba 100644 --- a/tripleo_ansible/roles/tripleo_hosts_entries/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_hosts_entries/tasks/main.yml @@ -27,12 +27,10 @@ tags: - tripleo_hosts_entries -- name: Update /etc/hosts - become: true - blockinfile: - create: true - path: "{{ tripleo_hosts_entries_hosts_path }}" - block: | +- name: Render out the hosts entries + run_once: true + set_fact: + tripleo_hosts_entries_block: | {{ tripleo_hosts_entries_undercloud_hosts_entries | join('') }} {{ tripleo_hosts_entries_vip_hosts_entries | join('') }} @@ -55,3 +53,12 @@ {{ tripleo_hosts_entries_extra_hosts_entries | join('') }} tags: - tripleo_hosts_entries + +- name: Update /etc/hosts + become: true + blockinfile: + create: true + path: "{{ tripleo_hosts_entries_hosts_path }}" + block: "{{ tripleo_hosts_entries_block }}" + tags: + - tripleo_hosts_entries