From e7bc62c20e6017704fbdd476ce9143e23f8504ec Mon Sep 17 00:00:00 2001 From: Alex Schultz Date: Fri, 19 Feb 2021 09:23:36 -0700 Subject: [PATCH] Use ansible_facts instead In order to ANSIBLE_INJECT_FACT_VARS=False we have to use ansible_facts instead of ansible_* vars. This change switches our distribution and hostname related items to use ansible_facts instead. Change-Id: Id01e754f0cf9f6e98c02f45a4011f3d6f59f80a1 Related-Bug: #1915761 --- .../modules/container_puppet_config.py | 2 +- .../roles/aide/tasks/aide_config.yml | 2 +- tripleo_ansible/roles/aide/tasks/main.yml | 12 ++++---- .../tasks/ceph_authentication.yml | 14 +++++----- .../backup_and_restore/tasks/ceph_backup.yml | 14 +++++----- .../tasks/ceph_mgr_stop.yml | 14 +++++----- .../tasks/ceph_mon_stop.yml | 14 +++++----- .../tasks/ceph_nfs_stop.yml | 12 ++++---- .../tasks/ceph_rgw_stop.yml | 14 +++++----- .../roles/backup_and_restore/tasks/main.yml | 12 ++++---- .../backup_and_restore/tasks/run_backup.yml | 12 ++++---- .../backup_and_restore/tasks/setup_nfs.yml | 12 ++++---- .../backup_and_restore/tasks/setup_rear.yml | 12 ++++---- .../roles/octavia_undercloud/tasks/main.yml | 4 +-- .../roles/test_deps/defaults/main.yml | 2 +- .../roles/test_deps/tasks/main.yml | 22 +++++++-------- .../roles/test_package_action/tasks/main.yml | 12 ++++---- .../roles/tripleo_bootstrap/tasks/main.yml | 18 ++++++------ .../roles/tripleo_ceph_client/tasks/main.yml | 12 ++++---- .../tripleo_clients_install/tasks/main.yml | 12 ++++---- .../tripleo_container_manage/tasks/main.yml | 12 ++++---- .../roles/tripleo_firewall/tasks/main.yml | 12 ++++---- .../roles/tripleo_frr/defaults/main.yml | 2 +- .../roles/tripleo_ha_wrapper/tasks/main.yml | 12 ++++---- .../roles/tripleo_kernel/tasks/reboot.yaml | 4 +-- .../tripleo_keystone_resources/tasks/main.yml | 12 ++++---- .../roles/tripleo_lvmfilter/tasks/main.yml | 9 +++++- .../molecule/default/prepare.yml | 2 +- .../tripleo_nova_image_cache/tasks/main.yml | 12 ++++---- .../roles/tripleo_nvdimm/tasks/main.yml | 12 ++++---- .../tasks/fast_forward_upgrade.yml | 2 +- .../roles/tripleo_packages/tasks/upgrade.yml | 2 +- .../roles/tripleo_podman/tasks/load_vars.yaml | 12 ++++---- .../tasks/tripleo_docker_purge.yml | 3 +- .../tasks/tripleo_podman_buildah_login.yml | 12 ++++---- .../tasks/tripleo_podman_install.yml | 9 +++--- .../tripleo_provision_mcelog/tasks/main.yml | 12 ++++---- .../roles/tripleo_ptp/defaults/main.yml | 2 +- .../roles/tripleo_ptp/tasks/main.yml | 28 +++++++++++++++---- .../roles/tripleo_ptp/tasks/tripleo_ptp.yml | 7 ----- .../roles/tripleo_puppet_cache/tasks/main.yml | 12 ++++---- .../tripleo_redhat_enforce/tasks/main.yml | 4 +-- .../roles/tripleo_sshd/tasks/main.yml | 12 ++++---- .../tripleo_systemd_wrapper/tasks/main.yml | 12 ++++---- tripleo_ansible/roles/tuned/tasks/main.yml | 12 ++++---- 45 files changed, 237 insertions(+), 221 deletions(-) diff --git a/tripleo_ansible/ansible_plugins/modules/container_puppet_config.py b/tripleo_ansible/ansible_plugins/modules/container_puppet_config.py index 744d30d41..0eda33549 100644 --- a/tripleo_ansible/ansible_plugins/modules/container_puppet_config.py +++ b/tripleo_ansible/ansible_plugins/modules/container_puppet_config.py @@ -105,7 +105,7 @@ EXAMPLES = """ container_puppet_config: step: 1 puppet-config: /var/lib/container-puppet/container-puppet.json - short_hostname: "{{ ansible_hostname }}" + short_hostname: "{{ ansible_facts['hostname'] }}" update_config_hash_only: false - name: Update config hashes for container startup configs container_puppet_config: diff --git a/tripleo_ansible/roles/aide/tasks/aide_config.yml b/tripleo_ansible/roles/aide/tasks/aide_config.yml index 358e346fe..5a60d7568 100644 --- a/tripleo_ansible/roles/aide/tasks/aide_config.yml +++ b/tripleo_ansible/roles/aide/tasks/aide_config.yml @@ -64,7 +64,7 @@ --check --config {{ aide_conf_path }} | {{ aide_mua_path }} - -s '{{ ansible_fqdn }} - AIDE integrity check' {{ aide_email }} + -s '{{ ansible_facts['fqdn'] }} - AIDE integrity check' {{ aide_email }} when: - aide_email.find("v=" ~ "@") == -1 diff --git a/tripleo_ansible/roles/aide/tasks/main.yml b/tripleo_ansible/roles/aide/tasks/main.yml index 0566fe298..757523b8f 100644 --- a/tripleo_ansible/roles/aide/tasks/main.yml +++ b/tripleo_ansible/roles/aide/tasks/main.yml @@ -22,12 +22,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/backup_and_restore/tasks/ceph_authentication.yml b/tripleo_ansible/roles/backup_and_restore/tasks/ceph_authentication.yml index 4e8fec03b..252017208 100644 --- a/tripleo_ansible/roles/backup_and_restore/tasks/ceph_authentication.yml +++ b/tripleo_ansible/roles/backup_and_restore/tasks/ceph_authentication.yml @@ -23,19 +23,19 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always - name: Export ceph authentication shell: | set -o pipefail - {{ tripleo_container_cli }} exec ceph-mon-{{ ansible_hostname }} bash -c "ceph auth export" + {{ tripleo_container_cli }} exec ceph-mon-{{ ansible_facts['hostname'] }} bash -c "ceph auth export" become: true register: bar_ceph_authentication_content tags: diff --git a/tripleo_ansible/roles/backup_and_restore/tasks/ceph_backup.yml b/tripleo_ansible/roles/backup_and_restore/tasks/ceph_backup.yml index 08690bc52..fd8ecc950 100644 --- a/tripleo_ansible/roles/backup_and_restore/tasks/ceph_backup.yml +++ b/tripleo_ansible/roles/backup_and_restore/tasks/ceph_backup.yml @@ -23,12 +23,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always @@ -68,7 +68,7 @@ - name: Copy the backup to the shared directory copy: src: "{{ tripleo_backup_and_restore_ceph_backup_file }}" - dest: "{{ tripleo_backup_and_restore_temporary_dir.path }}/{{ ansible_hostname }}" + dest: "{{ tripleo_backup_and_restore_temporary_dir.path }}/{{ ansible_facts['hostname'] }}" remote_src: true tags: - bar_create_recover_image diff --git a/tripleo_ansible/roles/backup_and_restore/tasks/ceph_mgr_stop.yml b/tripleo_ansible/roles/backup_and_restore/tasks/ceph_mgr_stop.yml index 531f8bcb1..77a03e0e7 100644 --- a/tripleo_ansible/roles/backup_and_restore/tasks/ceph_mgr_stop.yml +++ b/tripleo_ansible/roles/backup_and_restore/tasks/ceph_mgr_stop.yml @@ -23,19 +23,19 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always - name: Stop ceph management systemd: state: stopped - name: "ceph-mgr@{{ ansible_hostname }}" + name: "ceph-mgr@{{ ansible_facts['hostname'] }}" become: true tags: - bar_create_recover_image diff --git a/tripleo_ansible/roles/backup_and_restore/tasks/ceph_mon_stop.yml b/tripleo_ansible/roles/backup_and_restore/tasks/ceph_mon_stop.yml index 5d5e68376..f7e23b3a8 100644 --- a/tripleo_ansible/roles/backup_and_restore/tasks/ceph_mon_stop.yml +++ b/tripleo_ansible/roles/backup_and_restore/tasks/ceph_mon_stop.yml @@ -23,19 +23,19 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always - name: Stop ceph monitor systemd: state: stopped - name: "ceph-mon@{{ ansible_hostname }}" + name: "ceph-mon@{{ ansible_facts['hostname'] }}" become: true tags: - bar_create_recover_image diff --git a/tripleo_ansible/roles/backup_and_restore/tasks/ceph_nfs_stop.yml b/tripleo_ansible/roles/backup_and_restore/tasks/ceph_nfs_stop.yml index 4bb6fed56..14816bfd6 100644 --- a/tripleo_ansible/roles/backup_and_restore/tasks/ceph_nfs_stop.yml +++ b/tripleo_ansible/roles/backup_and_restore/tasks/ceph_nfs_stop.yml @@ -23,12 +23,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/backup_and_restore/tasks/ceph_rgw_stop.yml b/tripleo_ansible/roles/backup_and_restore/tasks/ceph_rgw_stop.yml index 3ee39480b..19d1ed6bb 100644 --- a/tripleo_ansible/roles/backup_and_restore/tasks/ceph_rgw_stop.yml +++ b/tripleo_ansible/roles/backup_and_restore/tasks/ceph_rgw_stop.yml @@ -23,12 +23,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always @@ -53,7 +53,7 @@ - name: Stop ceph rgw systemd: state: stopped - name: "ceph-radosgw@rgw.{{ ansible_hostname }}.{{ bar_ceph_rgw_name.stdout }}" + name: "ceph-radosgw@rgw.{{ ansible_facts['hostname'] }}.{{ bar_ceph_rgw_name.stdout }}" become: true when: - bar_ceph_rgw_exits.stdout!="0" diff --git a/tripleo_ansible/roles/backup_and_restore/tasks/main.yml b/tripleo_ansible/roles/backup_and_restore/tasks/main.yml index fd5209fe4..d71c236ed 100644 --- a/tripleo_ansible/roles/backup_and_restore/tasks/main.yml +++ b/tripleo_ansible/roles/backup_and_restore/tasks/main.yml @@ -23,12 +23,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/backup_and_restore/tasks/run_backup.yml b/tripleo_ansible/roles/backup_and_restore/tasks/run_backup.yml index 705492d18..ab8a51a1c 100644 --- a/tripleo_ansible/roles/backup_and_restore/tasks/run_backup.yml +++ b/tripleo_ansible/roles/backup_and_restore/tasks/run_backup.yml @@ -23,12 +23,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/backup_and_restore/tasks/setup_nfs.yml b/tripleo_ansible/roles/backup_and_restore/tasks/setup_nfs.yml index ae2250077..1e28a391f 100644 --- a/tripleo_ansible/roles/backup_and_restore/tasks/setup_nfs.yml +++ b/tripleo_ansible/roles/backup_and_restore/tasks/setup_nfs.yml @@ -23,12 +23,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/backup_and_restore/tasks/setup_rear.yml b/tripleo_ansible/roles/backup_and_restore/tasks/setup_rear.yml index 5ec42a573..eba0521f0 100644 --- a/tripleo_ansible/roles/backup_and_restore/tasks/setup_rear.yml +++ b/tripleo_ansible/roles/backup_and_restore/tasks/setup_rear.yml @@ -23,12 +23,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/octavia_undercloud/tasks/main.yml b/tripleo_ansible/roles/octavia_undercloud/tasks/main.yml index d12419a16..f01128149 100644 --- a/tripleo_ansible/roles/octavia_undercloud/tasks/main.yml +++ b/tripleo_ansible/roles/octavia_undercloud/tasks/main.yml @@ -11,14 +11,14 @@ set_fact: image_filename: "/usr/share/openstack-octavia-amphora-images/amphora-x64-haproxy.qcow2" when: - - ansible_distribution == 'CentOS' + - ansible_facts['distribution'] == 'CentOS' - not (image_filename is defined) - name: set location if Red Hat set_fact: image_filename: "/usr/share/openstack-octavia-amphora-images/octavia-amphora.qcow2" when: - - ansible_distribution == 'RedHat' + - ansible_facts['distribution'] == 'RedHat' - not (image_filename is defined) - name: check if amphora image file exists diff --git a/tripleo_ansible/roles/test_deps/defaults/main.yml b/tripleo_ansible/roles/test_deps/defaults/main.yml index da6681cc8..4bc5abdfb 100644 --- a/tripleo_ansible/roles/test_deps/defaults/main.yml +++ b/tripleo_ansible/roles/test_deps/defaults/main.yml @@ -17,5 +17,5 @@ test_deps_extra_packages: [] test_deps_setup_tripleo: false -test_deps_repo_version: "{{ ansible_distribution | lower }}{{ ansible_distribution_major_version }}-master" +test_deps_repo_version: "{{ ansible_facts['distribution'] | lower }}{{ ansible_facts['distribution_major_version'] }}-master" test_deps_mirrors_file_path: /etc/ci/mirror_info.sh diff --git a/tripleo_ansible/roles/test_deps/tasks/main.yml b/tripleo_ansible/roles/test_deps/tasks/main.yml index f847d580f..38aba3adc 100644 --- a/tripleo_ansible/roles/test_deps/tasks/main.yml +++ b/tripleo_ansible/roles/test_deps/tasks/main.yml @@ -22,12 +22,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always @@ -39,12 +39,12 @@ - name: RHEL Block become: true when: - - (ansible_os_family | lower) == 'redhat' + - (ansible_facts['os_family'] | lower) == 'redhat' - mirrors_file.stat.exists | bool block: - name: Fetch latest repo version uri: - url: https://trunk.rdoproject.org/centos{{ ansible_distribution_major_version }}/current/delorean.repo + url: https://trunk.rdoproject.org/centos{{ ansible_facts['distribution_major_version'] }}/current/delorean.repo return_content: true register: tripleo_packages @@ -67,7 +67,7 @@ - name: Tripleo setup block become: true when: - - (ansible_os_family | lower) == 'redhat' + - (ansible_facts['os_family'] | lower) == 'redhat' - test_deps_setup_tripleo | bool block: - name: Create tripleo repos @@ -86,14 +86,14 @@ name: "{{ test_deps_selinux_packages }}" state: present when: - - (ansible_os_family | lower) == 'redhat' + - (ansible_facts['os_family'] | lower) == 'redhat' - name: Install python yaml libs package: name: "{{ test_deps_yaml_packages }}" state: present when: - - (ansible_os_family | lower) == 'redhat' + - (ansible_facts['os_family'] | lower) == 'redhat' - name: Install extra packages package: diff --git a/tripleo_ansible/roles/test_package_action/tasks/main.yml b/tripleo_ansible/roles/test_package_action/tasks/main.yml index a21a3cd68..9f9122743 100644 --- a/tripleo_ansible/roles/test_package_action/tasks/main.yml +++ b/tripleo_ansible/roles/test_package_action/tasks/main.yml @@ -22,12 +22,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/tripleo_bootstrap/tasks/main.yml b/tripleo_ansible/roles/tripleo_bootstrap/tasks/main.yml index 2e5c697a2..4dd8e688c 100644 --- a/tripleo_ansible/roles/tripleo_bootstrap/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_bootstrap/tasks/main.yml @@ -23,12 +23,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always @@ -39,7 +39,7 @@ name: "{{ tripleo_bootstrap_release_version_package }}" state: present when: - - (ansible_distribution | lower) == 'redhat' + - (ansible_facts['distribution'] | lower) == 'redhat' - (tripleo_bootstrap_release_version_package |list | length) > 0 - name: Deploy required packages to bootstrap TripleO @@ -51,7 +51,7 @@ # ignore the case where the package can't be found (e.g. missing subscription). # https://bugzilla.redhat.com/show_bug.cgi?id=1820306 failed_when: - - (ansible_distribution | lower) == 'redhat' + - (ansible_facts['distribution'] | lower) == 'redhat' - not ansible_check_mode|bool - (tripleo_bootstrap_packages_bootstrap_result.rc | int) == 1 - not ('No package openvswitch available.' in tripleo_bootstrap_packages_bootstrap_result.failures | default([])) @@ -110,7 +110,7 @@ - name: Create empty ruleset in /etc/sysconfig/iptables and /etc/sysconfig/ip6tables become: true - ignore_errors: "{{ (((ansible_os_family | lower) ~ '-' ~ ansible_distribution_major_version) == 'redhat-7') | bool }}" + ignore_errors: "{{ (((ansible_facts['os_family'] | lower) ~ '-' ~ ansible_distribution_major_version) == 'redhat-7') | bool }}" copy: dest: "{{ item }}" content: "# empty ruleset created by deployed-server bootstrap" diff --git a/tripleo_ansible/roles/tripleo_ceph_client/tasks/main.yml b/tripleo_ansible/roles/tripleo_ceph_client/tasks/main.yml index 044b0db3f..8b0d4687a 100644 --- a/tripleo_ansible/roles/tripleo_ceph_client/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_ceph_client/tasks/main.yml @@ -23,12 +23,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/tripleo_clients_install/tasks/main.yml b/tripleo_ansible/roles/tripleo_clients_install/tasks/main.yml index 0491650a1..69578fe1a 100644 --- a/tripleo_ansible/roles/tripleo_clients_install/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_clients_install/tasks/main.yml @@ -20,12 +20,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/tripleo_container_manage/tasks/main.yml b/tripleo_ansible/roles/tripleo_container_manage/tasks/main.yml index ab0c4426f..1a5f7b4cb 100644 --- a/tripleo_ansible/roles/tripleo_container_manage/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_container_manage/tasks/main.yml @@ -23,12 +23,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/tripleo_firewall/tasks/main.yml b/tripleo_ansible/roles/tripleo_firewall/tasks/main.yml index aaaea87a5..ba29d68fb 100644 --- a/tripleo_ansible/roles/tripleo_firewall/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_firewall/tasks/main.yml @@ -19,12 +19,12 @@ - name: Gather variables for each operating system include_vars: "{{ item }}" with_first_found: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/tripleo_frr/defaults/main.yml b/tripleo_ansible/roles/tripleo_frr/defaults/main.yml index a63a47176..2239163bc 100644 --- a/tripleo_ansible/roles/tripleo_frr/defaults/main.yml +++ b/tripleo_ansible/roles/tripleo_frr/defaults/main.yml @@ -29,7 +29,7 @@ tripleo_frr_bgp_ipv6_allowas_in: false tripleo_frr_bgp_neighbor_ttl_security_hops: 1 tripleo_frr_bgp_uplinks_scope: internal tripleo_frr_config_basedir: "/var/lib/config-data/ansible-generated/frr" -tripleo_frr_hostname: "{{ ansible_hostname }}" +tripleo_frr_hostname: "{{ ansible_facts['hostname'] }}" tripleo_frr_log_level: informational tripleo_frr_watchfrr: true tripleo_frr_zebra: false diff --git a/tripleo_ansible/roles/tripleo_ha_wrapper/tasks/main.yml b/tripleo_ansible/roles/tripleo_ha_wrapper/tasks/main.yml index ec4381869..086bdd450 100644 --- a/tripleo_ansible/roles/tripleo_ha_wrapper/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_ha_wrapper/tasks/main.yml @@ -38,12 +38,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/tripleo_kernel/tasks/reboot.yaml b/tripleo_ansible/roles/tripleo_kernel/tasks/reboot.yaml index 51c3107da..d5351760b 100644 --- a/tripleo_ansible/roles/tripleo_kernel/tasks/reboot.yaml +++ b/tripleo_ansible/roles/tripleo_kernel/tasks/reboot.yaml @@ -56,10 +56,10 @@ when: - item.path | regex_replace('(^.*ifcfg-)(.*)', '\\2') != "lo" # Ensure the interface information is available in the facts - - hostvars[inventory_hostname]['ansible_' + item.path | regex_replace('(^.*ifcfg-)(.*)', '\\2') | replace('-', '_') ] is defined + - hostvars[inventory_hostname]['ansible_facts'][item.path | regex_replace('(^.*ifcfg-)(.*)', '\\2') | replace('-', '_')] is defined # This condition will list all the interfaces except the one with valid IP (which is Provisioning network at this stage) # Simpler Version - hostvars[inventory_hostname]['ansible_' + iface_name ]['ipv4'] is undefined - - hostvars[inventory_hostname]['ansible_' + item.path | regex_replace('(^.*ifcfg-)(.*)', '\\2') | replace('-', '_') ]['ipv4'] is undefined + - hostvars[inventory_hostname]['ansible_facts'][item.path | regex_replace('(^.*ifcfg-)(.*)', '\\2') | replace('-', '_')]['ipv4'] is undefined with_items: - "{{ ifcfg_files.files }}" become: true diff --git a/tripleo_ansible/roles/tripleo_keystone_resources/tasks/main.yml b/tripleo_ansible/roles/tripleo_keystone_resources/tasks/main.yml index b04ce9e73..1473cde60 100644 --- a/tripleo_ansible/roles/tripleo_keystone_resources/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_keystone_resources/tasks/main.yml @@ -23,12 +23,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/tripleo_lvmfilter/tasks/main.yml b/tripleo_ansible/roles/tripleo_lvmfilter/tasks/main.yml index 662f9baed..8aa437c74 100644 --- a/tripleo_ansible/roles/tripleo_lvmfilter/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_lvmfilter/tasks/main.yml @@ -26,13 +26,20 @@ - lvm_pkg_check.rc == 0 - tripleo_tripleo_lvmfilter_enabled or tripleo_tripleo_lvmfilter_dry_run block: + - name: collect ansible devices + become: true + setup: + gather_subset: + - '!all' + - devices + filter: 'ansible_devices' - name: collect in-use lvm2 devices list become: true lvm2_physical_devices_facts: - name: set allowed_devices set_fact: allowed_devices: "{{ (ansible_facts['lvm2_active_pvs'] | default([]) | list) - | intersect(ansible_devices.keys()) + | intersect(ansible_facts['devices'].keys()) + (tripleo_tripleo_lvmfilter_devices_allowlist | default([])) | unique }}" - name: build lvm2 allow list diff --git a/tripleo_ansible/roles/tripleo_network_config/molecule/default/prepare.yml b/tripleo_ansible/roles/tripleo_network_config/molecule/default/prepare.yml index 9f34d9253..dd0156fc4 100644 --- a/tripleo_ansible/roles/tripleo_network_config/molecule/default/prepare.yml +++ b/tripleo_ansible/roles/tripleo_network_config/molecule/default/prepare.yml @@ -27,4 +27,4 @@ name: network-scripts state: present when: - - ansible_distribution_major_version|int == 8 + - ansible_facts['distribution_major_version'] is version('8', '==') diff --git a/tripleo_ansible/roles/tripleo_nova_image_cache/tasks/main.yml b/tripleo_ansible/roles/tripleo_nova_image_cache/tasks/main.yml index f8f31dcf7..e59bb35cc 100644 --- a/tripleo_ansible/roles/tripleo_nova_image_cache/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_nova_image_cache/tasks/main.yml @@ -23,12 +23,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/tripleo_nvdimm/tasks/main.yml b/tripleo_ansible/roles/tripleo_nvdimm/tasks/main.yml index 698ea6df3..7464a185e 100644 --- a/tripleo_ansible/roles/tripleo_nvdimm/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_nvdimm/tasks/main.yml @@ -22,12 +22,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/tripleo_packages/tasks/fast_forward_upgrade.yml b/tripleo_ansible/roles/tripleo_packages/tasks/fast_forward_upgrade.yml index 484ee1c39..d2e282745 100644 --- a/tripleo_ansible/roles/tripleo_packages/tasks/fast_forward_upgrade.yml +++ b/tripleo_ansible/roles/tripleo_packages/tasks/fast_forward_upgrade.yml @@ -17,7 +17,7 @@ - name: set is_bootstrap_node fact set_fact: - is_bootstrap_node: "{{ tripleo_packages_short_bootstrap_node_name|lower == ansible_hostname|lower }}" + is_bootstrap_node: "{{ tripleo_packages_short_bootstrap_node_name|lower == ansible_facts['hostname']|lower }}" - name: Debug fast forward upgrade repo variables debug: diff --git a/tripleo_ansible/roles/tripleo_packages/tasks/upgrade.yml b/tripleo_ansible/roles/tripleo_packages/tasks/upgrade.yml index 17f096dae..a0fee2969 100644 --- a/tripleo_ansible/roles/tripleo_packages/tasks/upgrade.yml +++ b/tripleo_ansible/roles/tripleo_packages/tasks/upgrade.yml @@ -108,7 +108,7 @@ - python3-heat-agent* state: present when: - - ansible_distribution_major_version == '8' + - ansible_facts['distribution_major_version'] is version('8', '==') # With the layered product packaging, the key package is rhosp-openvswitch. It depends on # a openvswitch package that includes the version as part of the name (e.g openvswitch2.10). diff --git a/tripleo_ansible/roles/tripleo_podman/tasks/load_vars.yaml b/tripleo_ansible/roles/tripleo_podman/tasks/load_vars.yaml index 3c710231b..e6f91045a 100644 --- a/tripleo_ansible/roles/tripleo_podman/tasks/load_vars.yaml +++ b/tripleo_ansible/roles/tripleo_podman/tasks/load_vars.yaml @@ -24,9 +24,9 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" diff --git a/tripleo_ansible/roles/tripleo_podman/tasks/tripleo_docker_purge.yml b/tripleo_ansible/roles/tripleo_podman/tasks/tripleo_docker_purge.yml index 8bd48edb7..68c19f64c 100644 --- a/tripleo_ansible/roles/tripleo_podman/tasks/tripleo_docker_purge.yml +++ b/tripleo_ansible/roles/tripleo_podman/tasks/tripleo_docker_purge.yml @@ -57,12 +57,13 @@ - '!all' - '!min' - hardware + filter: 'ansible_mounts' - name: Un-mount docker directories mount: path: "{{ item.mount }}" state: unmounted - loop: "{{ ansible_mounts | selectattr('mount', 'search', 'docker') | list }}" + loop: "{{ ansible_facts['mounts'] | selectattr('mount', 'search', 'docker') | list }}" - name: Purge /var/lib/docker file: diff --git a/tripleo_ansible/roles/tripleo_podman/tasks/tripleo_podman_buildah_login.yml b/tripleo_ansible/roles/tripleo_podman/tasks/tripleo_podman_buildah_login.yml index 8f95de3f1..c9add96f3 100644 --- a/tripleo_ansible/roles/tripleo_podman/tasks/tripleo_podman_buildah_login.yml +++ b/tripleo_ansible/roles/tripleo_podman/tasks/tripleo_podman_buildah_login.yml @@ -19,12 +19,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" - name: ensure buildah is installed become: true diff --git a/tripleo_ansible/roles/tripleo_podman/tasks/tripleo_podman_install.yml b/tripleo_ansible/roles/tripleo_podman/tasks/tripleo_podman_install.yml index 463f89c5d..ab431bafb 100644 --- a/tripleo_ansible/roles/tripleo_podman/tasks/tripleo_podman_install.yml +++ b/tripleo_ansible/roles/tripleo_podman/tasks/tripleo_podman_install.yml @@ -26,9 +26,9 @@ name: "{{ tripleo_podman_packages }}" state: latest - - name: Ensure we get the ansible_interfaces fact + - name: Ensure we get the ansible interfaces facts when: - - ansible_interfaces is undefined + - ansible_facts['interfaces'] is undefined setup: gather_subset: - '!all' @@ -39,7 +39,7 @@ - name: Delete legacy cni0 interface (podman < 1.6) command: ip link delete cni0 when: - - '"cni0" in ansible_interfaces' + - '"cni0" in ansible_facts["interfaces"]' # don't update the network config if the network is already running # meaning cni-podman0 is running somewhere @@ -51,8 +51,7 @@ owner: root group: root when: - - '"cni-podman0" not in ansible_interfaces' - + - '"cni-podman0" not in ansible_facts["interfaces"]' - name: Write containers registries.conf template: diff --git a/tripleo_ansible/roles/tripleo_provision_mcelog/tasks/main.yml b/tripleo_ansible/roles/tripleo_provision_mcelog/tasks/main.yml index 475377a23..e31e5aa59 100644 --- a/tripleo_ansible/roles/tripleo_provision_mcelog/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_provision_mcelog/tasks/main.yml @@ -23,12 +23,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/tripleo_ptp/defaults/main.yml b/tripleo_ansible/roles/tripleo_ptp/defaults/main.yml index 0e840c49d..4917c4e23 100644 --- a/tripleo_ansible/roles/tripleo_ptp/defaults/main.yml +++ b/tripleo_ansible/roles/tripleo_ptp/defaults/main.yml @@ -18,7 +18,7 @@ # All variables intended for modification should be placed in this file. tripleo_ptp_slave_mode: 1 -tripleo_ptp_interfaces: ["{{ ansible_default_ipv4.interface }}"] +tripleo_ptp_interfaces: [] tripleo_ptp_transport: UDPv4 tripleo_ptp_hardware_offload: false diff --git a/tripleo_ansible/roles/tripleo_ptp/tasks/main.yml b/tripleo_ansible/roles/tripleo_ptp/tasks/main.yml index 09900ec2e..bcbe5063e 100644 --- a/tripleo_ansible/roles/tripleo_ptp/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_ptp/tasks/main.yml @@ -23,15 +23,31 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always +- name: Get default interface network facts + setup: + gather_subset: + - '!all' + - '!any' + - network + filter: 'ansible_default_ipv4' + +- name: Set default ptp interface + set_fact: + tripleo_ptp_interfaces: ["{{ ansible_facts['default_ipv4']['interface'] }}"] + when: + - tripleo_ptp_interfaces | length == 0 + - ansible_facts['default_ipv4'] is defined + - ansible_facts['default_ipv4']['interface'] is defined + - name: Run ptp tasks include_tasks: tripleo_ptp.yml diff --git a/tripleo_ansible/roles/tripleo_ptp/tasks/tripleo_ptp.yml b/tripleo_ansible/roles/tripleo_ptp/tasks/tripleo_ptp.yml index 31dbe19af..a564682c6 100644 --- a/tripleo_ansible/roles/tripleo_ptp/tasks/tripleo_ptp.yml +++ b/tripleo_ansible/roles/tripleo_ptp/tasks/tripleo_ptp.yml @@ -21,13 +21,6 @@ state: present register: _ptp_install_result -- name: Collect only facts returned by facter - setup: - gather_subset: - - '!all' - - '!any' - - network - # NOTE(cloudnull): In the future, we could potentially revisit this once the Heat # template for the "kernel" sysctl settings has been converted into # an Ansible role and re-use the functionality of that. diff --git a/tripleo_ansible/roles/tripleo_puppet_cache/tasks/main.yml b/tripleo_ansible/roles/tripleo_puppet_cache/tasks/main.yml index 8134b91f9..69412337b 100644 --- a/tripleo_ansible/roles/tripleo_puppet_cache/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_puppet_cache/tasks/main.yml @@ -23,12 +23,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/tripleo_redhat_enforce/tasks/main.yml b/tripleo_ansible/roles/tripleo_redhat_enforce/tasks/main.yml index 2d7383485..617ebd947 100644 --- a/tripleo_ansible/roles/tripleo_redhat_enforce/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_redhat_enforce/tasks/main.yml @@ -27,12 +27,12 @@ when: - include_file is exists vars: - include_file: "{{ role_path }}/vars/{{ ansible_distribution | lower }}.yml" + include_file: "{{ role_path }}/vars/{{ ansible_facts['distribution'] | lower }}.yml" tags: - always - include_tasks: enforce_release.yml name: Enforce RHEL/OSP version pair when: - - (ansible_distribution | lower) == "redhat" + - (ansible_facts['distribution'] | lower) == "redhat" - tripleo_redhat_enforce|bool diff --git a/tripleo_ansible/roles/tripleo_sshd/tasks/main.yml b/tripleo_ansible/roles/tripleo_sshd/tasks/main.yml index d05528d78..e9bc59255 100644 --- a/tripleo_ansible/roles/tripleo_sshd/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_sshd/tasks/main.yml @@ -20,12 +20,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/tripleo_systemd_wrapper/tasks/main.yml b/tripleo_ansible/roles/tripleo_systemd_wrapper/tasks/main.yml index a97c576bc..7a7e048a9 100644 --- a/tripleo_ansible/roles/tripleo_systemd_wrapper/tasks/main.yml +++ b/tripleo_ansible/roles/tripleo_systemd_wrapper/tasks/main.yml @@ -23,12 +23,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always diff --git a/tripleo_ansible/roles/tuned/tasks/main.yml b/tripleo_ansible/roles/tuned/tasks/main.yml index d16931359..ed3e23279 100644 --- a/tripleo_ansible/roles/tuned/tasks/main.yml +++ b/tripleo_ansible/roles/tuned/tasks/main.yml @@ -22,12 +22,12 @@ with_first_found: - skip: true files: - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml" - - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml" - - "{{ ansible_distribution | lower }}.yml" - - "{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yml" - - "{{ ansible_os_family | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" + - "{{ ansible_facts['distribution'] | lower }}.yml" + - "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + - "{{ ansible_facts['os_family'] | lower }}.yml" tags: - always