From e8ec5ecea6a344f605518e9753babd34bf61c561 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Harald=20Jens=C3=A5s?= Date: Sat, 11 Jun 2022 01:47:39 +0200 Subject: [PATCH] Ensure lowercase hostname in NodePortMap When a node's hostnae contain uppercase characters the RoleNetIpMap will have missing entries. Since hostname is case insensitive, convert to lowercase when creating the NodePortMap to ensure the lookups in THT succeedes. Closes-Bug: #1978362 Change-Id: I69050773472e25f49878c18a2ac4922a9aed8892 (cherry picked from commit f83c9e0cae99642a8525ee169ae2f500bef16f30) --- releasenotes/notes/bug-1978362-e2b878f5f6c61298.yaml | 6 ++++++ .../modules/tripleo_overcloud_network_ports.py | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/bug-1978362-e2b878f5f6c61298.yaml diff --git a/releasenotes/notes/bug-1978362-e2b878f5f6c61298.yaml b/releasenotes/notes/bug-1978362-e2b878f5f6c61298.yaml new file mode 100644 index 000000000..09e881998 --- /dev/null +++ b/releasenotes/notes/bug-1978362-e2b878f5f6c61298.yaml @@ -0,0 +1,6 @@ +--- +fixes: + - | + Fixed an issue which caused RoleNetIpMap to have missing overcloud node IP + addresses when overcloud node hostname contain uppercase characters. + See bug: `1978362 `_. diff --git a/tripleo_ansible/ansible_plugins/modules/tripleo_overcloud_network_ports.py b/tripleo_ansible/ansible_plugins/modules/tripleo_overcloud_network_ports.py index cb2829f6a..04362254f 100644 --- a/tripleo_ansible/ansible_plugins/modules/tripleo_overcloud_network_ports.py +++ b/tripleo_ansible/ansible_plugins/modules/tripleo_overcloud_network_ports.py @@ -424,7 +424,7 @@ def _unprovision_ports(result, conn, stack, instance, ironic_uuid): def generate_node_port_map(result, net_maps, ports_by_node): node_port_map = result['node_port_map'] for hostname, ports in ports_by_node.items(): - node = node_port_map[hostname] = dict() + node = node_port_map[hostname.lower()] = dict() for port in ports: if not port.fixed_ips: continue