openstack
/
tripleo-ansible
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(2 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 6926 \u003c6926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_6926\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 18002 \u003c18002@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_6926\u003e replied on the change"}
This commit is contained in:
Gerrit User 6926 2022-10-07 12:39:28 +00:00 committed by Gerrit Code Review
parent 1f893d2e54
commit ea17b59523
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
4fcb0827c9bfd4d8d41a571e81e513647975e67a Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "843e07dd_8275f1e4",
"filename": "tripleo_ansible/roles/tripleo_nova_libvirt/files/nova_libvirt_init_secret.sh",
"patchSetId": 4
},
"lineNbr": 45,
"author": {
"id": 6926
},
"writtenOn": "2022-10-07T12:39:28Z",
"side": 1,
"message": "these 3 lines could be merged with #40, and you can remove the HAVE_FIRST_SECRET env var and an extra condition",
"revId": "4fcb0827c9bfd4d8d41a571e81e513647975e67a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0d91760b_ffadc194",
"filename": "tripleo_ansible/roles/tripleo_nova_libvirt/files/nova_libvirt_init_secret.sh",
"patchSetId": 4
},
"lineNbr": 49,
"author": {
"id": 6926
},
"writtenOn": "2022-10-07T12:39:28Z",
"side": 1,
"message": "and these 2 - can go to the line #39",
"revId": "4fcb0827c9bfd4d8d41a571e81e513647975e67a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}