From ef33a0f91fad48bce3c2f8bb0b50d751c1971004 Mon Sep 17 00:00:00 2001 From: John Fulton Date: Sun, 17 Jan 2021 12:36:48 -0500 Subject: [PATCH] Create ceph directories in config-download without become Given how config-download runs in the main branch it's no longer necessary to use become when creating the work directories for ceph-ansible to be executed or when running the tripleo_ceph_client role. Using become introduces the bug this change resolves. Also, as we are not using become we won't set the owner of the directory. Instead we will use the default owner of whoever created the directory. Change-Id: I65cd66ed5c94b548b775b9b4829717c202837d7e Closes-Bug: #1912103 --- tripleo_ansible/roles/tripleo_ceph_client/tasks/fetch_dir.yml | 2 -- tripleo_ansible/roles/tripleo_ceph_work_dir/tasks/prepare.yml | 2 -- 2 files changed, 4 deletions(-) diff --git a/tripleo_ansible/roles/tripleo_ceph_client/tasks/fetch_dir.yml b/tripleo_ansible/roles/tripleo_ceph_client/tasks/fetch_dir.yml index df8f80ef2..4ab24e295 100644 --- a/tripleo_ansible/roles/tripleo_ceph_client/tasks/fetch_dir.yml +++ b/tripleo_ansible/roles/tripleo_ceph_client/tasks/fetch_dir.yml @@ -24,10 +24,8 @@ path: "{{ tripleo_ceph_client_fetch_dir }}/" when: clean - name: Create ceph_client_fetch_dir for the current execution - become: true tags: 'build_fetch_dir' file: path: "{{ tripleo_ceph_client_fetch_dir }}" state: directory - owner: "{{ ansible_user }}" when: build diff --git a/tripleo_ansible/roles/tripleo_ceph_work_dir/tasks/prepare.yml b/tripleo_ansible/roles/tripleo_ceph_work_dir/tasks/prepare.yml index 9ef421420..5e41349c2 100644 --- a/tripleo_ansible/roles/tripleo_ceph_work_dir/tasks/prepare.yml +++ b/tripleo_ansible/roles/tripleo_ceph_work_dir/tasks/prepare.yml @@ -15,11 +15,9 @@ # under the License. - name: create ceph-ansible temp dirs - become: true file: path: "{{ item }}" state: directory - owner: "{{ ansible_user }}" with_items: - "{{ playbook_dir }}/ceph-ansible" - "{{ playbook_dir }}/ceph-ansible/group_vars"