Commit Graph

1168 Commits (cdb59feb206cf0ff3e079695c23ecfdb07271e25)

Author SHA1 Message Date
Alex Schultz cdb59feb20 Fix missing requirements for tests
We added heatclient and metalsmith requirements as part of our modules
so we need to make sure to properly capture them.

Change-Id: Ia5859ecf0822f19b9f04dda79d5b8b5eaf5220be
2020-06-26 15:04:21 -06:00
Zuul b387893e21 Merge "Make sure failed containers get stopped by systemd" 2020-06-26 15:25:50 +00:00
Zuul f5b1dfcba3 Merge "Install osc-placement package during client package installation" 2020-06-24 16:18:09 +00:00
Zuul fff2e1cea7 Merge "Prepare tripleo deps repo in tripleo_client_install molecule job" 2020-06-24 16:18:08 +00:00
Zuul 6d27cb1ff8 Merge "Remove paunch module" 2020-06-24 16:18:06 +00:00
Zuul 9c233b2803 Merge "Make tripleo_ceph_run_ansible handle change in remote_tmp" 2020-06-24 16:08:32 +00:00
John Fulton 1b440db7f6
Make tripleo_ceph_run_ansible handle change in remote_tmp
Ansible's remote_tmp module changed in 2.9.10 [1] causing
the reported bug this patch addresses. The error from the
module suggests creating the remote_tmp dir with the correct
permissions. This patch does that within external_deploy_steps
by having tripleo-ansible create the remote_tmp dir accordingly
before running ceph-ansible (which uses that remote_tmp dir).


Change-Id: I0350d5253571a2b0d12a0a2f25e5469c9d1fefe0
Closes-Bug: #1884816
2020-06-24 11:09:03 +02:00
Zuul b36a5dd651 Merge "Set retry timeout for nodes introspection" 2020-06-24 05:42:42 +00:00
Emilien Macchi fe45611870 Remove paunch module
Paunch was removed in Victoria cycle, therefore this module isn't useful
anymore and can't work. So we need to remove it.

Change-Id: Ie1bd288ec524e025fb6e56f7bdb740ce35d6a104
2020-06-24 03:32:10 +00:00
Takashi Kajinami 77b4f66504 Make sure failed containers get stopped by systemd
When the main PID (i.e., common) of a container is killed because of
some reasons, systemd won't execute ExecStop command.
Current podman doesn't detect this failure ang recognize that container
is still running and this causes failure when systemd tries to restart
the container.

This patch introduces ExecStopPost configuration into systemd unit
files so that stop operation is executed even when a container fails
because of killed main process. The stale container should be cleaned
up by ExecStopPost task before systemd tries to restart it.

Note that the similar change has been introcuded to "podman generate
systemd" command already[1].
[1] e5c3432944

Change-Id: Idb8be98f83f95ae536762f79809aa375f04e56ab
Closes-Bug: #1884866
2020-06-24 11:34:35 +09:00
Zuul d6fb5548d2 Merge "tripleo_profile_tasks: add a final line break" 2020-06-23 23:30:56 +00:00
Takashi Kajinami 8f758e5e4f Install osc-placement package during client package installation
This patch makes osc-placmeent package installed as a part of client
packages, because this package is required to manage resources in
placement service.

Change-Id: Ib2524cf97f97693d7d03c1bb4fb1c2bde40d3bec
2020-06-23 22:37:57 +00:00
Zuul a8b7f43c3d Merge "Module tripleo_list_overclouds" 2020-06-23 17:20:06 +00:00
Sagi Shnaidman a368a641ef Set retry timeout for nodes introspection
When restarting node introspection wait a configured amount of time
so that node can be unlocked.
Change-Id: Iff582edfe8ebbf9f30e5cdc13402986fea1c39aa
2020-06-23 19:52:28 +03:00
Takashi Kajinami c70a5c8f08 Prepare tripleo deps repo in tripleo_client_install molecule job
Change-Id: I96453d9236cb92922b058d697be8d8696f279c66
Closes-Bug: #1884696
2020-06-23 22:03:00 +09:00
Emilien Macchi db3ff367f5 tripleo_profile_tasks: add a final line break
If a trace occurs, a final line break is visually useful to know when
the task profiling ends. The trace will be show *after* the callback so
we reduce confusion where the problem is.

Change-Id: Ibe21bdf046f71ce45f0fd36068635c4d954da5f2
2020-06-23 02:45:38 +00:00
Zuul d0dc2f9847 Merge "metalsmith_instances: Handle an empty instance list" 2020-06-22 22:06:34 +00:00
Steve Baker 669af49bbb Module tripleo_list_overclouds
When upgrading the undercloud it will be necessary to have some
ansible tasks to loop on tasks which operate on every existing stack.

This simple module will lookup existing heat stacks and return a list
of stacks which appear to be overcloud stacks. They are assumed to be
overcloud stacks if they have the output: AnsibleHostVarsMap.

Change-Id: Ib7dc2c968a5aaff40696f591caa2399c0fb5a7bc
Blueprint: nova-less-deploy
2020-06-22 21:36:57 +00:00
Zuul 4ce6fda21b Merge "Use folder with plan name with config download export" 2020-06-22 12:20:27 +00:00
Zuul dedd9a5c33 Merge "Handle unreachable" 2020-06-19 19:10:13 +00:00
Rabi Mishra 4000770dec Use folder with plan name with config download export
To be consistent with auto config-download and overcloud export
create subfloder with plan/stack name.

Change-Id: I08b447379ae6e267f8dff11e6e703a991918683c
Closes-Bug: #1884246
2020-06-19 20:25:51 +05:30
Emilien Macchi ca2ca08333 tripleo_container_manage: remove paunch-related tasks
Paunch was removed from TripleO during Victoria Cycle.
tripleo_container_manage was enabled by default in Ussuri.

Therefore there is no need to run these tasks anymore, since they were
suppose to run during a deployment or upgrade of Ussuri.

Change-Id: I4f61dc954695d6c235effd44f16215d5e5401088
2020-06-19 02:54:25 +00:00
Zuul e5c35bdb7a Merge "Add pre stop exec hook for container systemd units" 2020-06-18 22:20:58 +00:00
Zuul 7dc4495b2f Merge "Adding playbook support for changes coming to python-tripleoclient." 2020-06-18 19:43:59 +00:00
Zuul e6a0466600 Merge "Don't add non-existing groups in podman tests" 2020-06-18 15:31:51 +00:00
Sagi Shnaidman a7d3ad9ed4 Don't add non-existing groups in podman tests
Change-Id: I59d11e19c512ce2a795049371f08a10c6cd68de4
2020-06-18 15:23:30 +03:00
Bogdan Dobrelya 26abebb293 Add pre stop exec hook for container systemd units
Sometimes, actions taken as the part of a container's entrypoint script
should become the pre-stop actions. Allow such configurations composed
for managed containers.

Change-Id: I40237e2b35ce83c5b519a117a6d4e74cb845b2c3
Related-bug: #1884048
Signed-off-by: Bogdan Dobrelya <>
2020-06-18 12:08:23 +02:00
Alex Schultz 746bd9a52b Fix host entries permissions
The cleanup tasks needs become: true because it was created with root.

Change-Id: Iaa39aa301be182722e0650583d1ad17c0e8dc82b
Related-Bug: #1883609
2020-06-17 20:19:27 +00:00
Alex Schultz 19ef86c627 Ensure pip is installed
We need pip and virtualenv for molcule jobs. This was dropped recently
in the base image so we need to handle this ourselves.

Change-Id: Ie5ba86c4d8aa97959d7336886536dc1439ce54bd
2020-06-17 13:48:30 -06:00
Giulio Fidente bdf648ff20 Revert "Add osd blacklist cap when openstack client cap is built"
Explicit allowance for command blacklist shouldn't be necessary in
master nor ussuri/train as per [1] and, more in general, shouldn't
ever be needed with "profile rbd"

It seems a problem seen when upgrading from jewel to luminous, for
tripleo that means upgrading from newton to queens; the changes are
for the jewel keyring so I think the patch should be posted for
the newton branch only


This reverts commit 4421bf8056.

Change-Id: I151a1b8d0f2775463580f46082aa22469878dc15
2020-06-15 15:59:01 +00:00
Zuul 19172a2169 Merge "Octavia: handle empty amphora image search result" 2020-06-13 04:54:10 +00:00
Zuul ea954bc5f3 Merge "Add osd blacklist cap when openstack client cap is built" 2020-06-13 02:22:08 +00:00
Alex Schultz ffe694808e Handle unreachable
We forgot to handle unreachable errors.

fatal: [compute-1]: UNREACHABLE! => {"changed": false, "msg": "Failed to
connect to the host via ssh: ssh: connect to host port 22:
No route to host", "unreachable": true}

Change-Id: I55f078be5fbdd762ffb63fb25ca6a192abb2e049
2020-06-11 15:42:03 -06:00
Zuul c15a7ce013 Merge "Add playbook for config-download export" 2020-06-11 16:56:26 +00:00
Zuul 08e447aa09 Merge "Add toggle for sensitive data within keystone" 2020-06-10 17:42:52 +00:00
Francesco Pantano 4421bf8056
Add osd blacklist cap when openstack client cap is built
This patch modifies the keyring for OpenStack client and enables
osd blacklist command. Usually this is not required but adding
this capability to the OpenStack client Keyring, the OpenStack
nodes can advise that the 'watcher' state from the specified IP
address should be cleared (blacklisted).

Change-Id: Ia39bbdb883265782ee15083ad5e58d6495aca125
2020-06-10 12:58:31 +02:00
Kevin Carter 8cc51067d8 Add toggle for sensitive data within keystone
This change will allow deployers to expose sensitive data as needed. 

> This change also fixes the tests for keystone. The role test was
  broken because the use of test-deps needed to be updated for the new
  repo layout.

Change-Id: I200efe00b735a17a996fbfe64e3f0f4d4c813f73
Signed-off-by: Kevin Carter <>
2020-06-10 02:12:06 +00:00
Zuul 6a96c8d204 Merge "Fix error when display_ok_hosts is false" 2020-06-09 20:18:32 +00:00
Zuul b7a80e1cde Merge "Preserve inode when updating /etc/hosts" 2020-06-09 16:46:50 +00:00
Alex Schultz 3ff730bc6f Fix error when display_ok_hosts is false
If display_ok_hosts is false, we were returning None but the function is
expected to return a tuple. So let's return a tuple of (None, None) and
check if we don't have a line then return.

Change-Id: Iaf2f83a8f13bcb9cf0c37acff627a456005057de
2020-06-09 08:28:18 -06:00
Damien Ciabrini 7761249774 Preserve inode when updating /etc/hosts
Containers configured by tripleo bind-mount /etc/hosts directly,
which means any change to that file has to preserve the original
inode, otherwise the containers will get out of sync with the
host and will not see updates.

Change tripleo_host_entries to not depend on atomic semantics of
ansible, which changes inodes on update. Instead, perform a
non-atomic update to preserve inodes, and rely on the retry
logics of openstack containers to recover from unexpected
behaviour in case /etc/hosts is consumed while it is being updated.

Closes-Bug: #1882290
Change-Id: I34dd9121bbd650b79cb523e4dbed5949a0e7d52d
2020-06-09 08:51:54 +02:00
Rabi Mishra 5e71104828 Add playbook for config-download export
We'll switch to use this playbook in python-tripleoclient

Change-Id: Ie0237cdc691034eaa35970a5b1d0186a76c5bc25
2020-06-09 11:22:24 +05:30
Zuul 41f132edb5 Merge "Make throttle optional" 2020-06-08 16:55:55 +00:00
Zuul bfb7b649cd Merge "Molecule testing for TripleO Strategy Plugins" 2020-06-08 07:20:36 +00:00
Zuul 90e7ac0d2f Merge "Max percentage failure support" 2020-06-08 07:20:35 +00:00
Zuul 43c1a3f01d Merge "Fix tripleo_profile_tasks callback plugin _output()" 2020-06-05 22:05:11 +00:00
Toure eb9c4944a9 Adding playbook support for changes coming to python-tripleoclient.
These playbooks will allow for clean interface to the backup and restore

Change-Id: I6f3fa1a6bf6a7f7ebc8c41b69708b75c94cce738
2020-06-05 17:19:41 -04:00
Alex Schultz ee3c9c841e Make throttle optional
Tasks did not have the concept of throttling prior to ansible 2.9 so if
we want to allow this to be re-used with older versions then we need to
skip the throttling code if task doesn't contain the throttle attribute.
This will help if we want to backport this for upgrades.

Change-Id: I01f6e3a69dec25ec69782c087d6b81ce3f33e6c0
2020-06-05 13:34:38 -06:00
Zuul 23f958a011 Merge "Switch to newer openstackdocstheme and reno versions" 2020-06-05 16:53:01 +00:00
Rabi Mishra f0dbd1d0f5 Fix tripleo_profile_tasks callback plugin _output()
Regression from

Change-Id: Ied39aaef9c65c65f33cceb99071c53af7f9aa464
2020-06-05 11:41:03 +05:30