92 lines
4.2 KiB
Plaintext
92 lines
4.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "4685008e_30eafccb",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 18002
|
|
},
|
|
"writtenOn": "2022-09-20T23:03:57Z",
|
|
"side": 1,
|
|
"message": "Requires an inventory file with the following:\n\n tripleo_cinder_enable_rbd_backend\u003dtrue\n tripleo_ceph_cluster_fsid\u003d$FSID\n tripleo_ceph_client_key\u003d$CEPHX\n\nand requires tripleo_nova_libvirt_ceph_config_path (e.g. /etc/ceph) to\nbe pre-populated with the cephx key and conf file. Which can be done\nvia the following which should also land in standalone-roles.\n\n include_role:\n name: tripleo_ceph_client\n",
|
|
"revId": "6304aa0f86c5bfd2bbf1960db1cec1deae660618",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "6665789a_589ee905",
|
|
"filename": "tripleo_ansible/roles/tripleo_nova_libvirt/files/nova_libvirt_init_secret.yaml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 13,
|
|
"author": {
|
|
"id": 6926
|
|
},
|
|
"writtenOn": "2022-09-22T15:34:01Z",
|
|
"side": 1,
|
|
"message": "there are some facts set that resemble this, targeting Multiple rbd backends support. Should we use those facts instead?",
|
|
"revId": "6304aa0f86c5bfd2bbf1960db1cec1deae660618",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2f44c20d_c92f25e4",
|
|
"filename": "tripleo_ansible/roles/tripleo_nova_libvirt/files/nova_libvirt_init_secret.yaml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 13,
|
|
"author": {
|
|
"id": 18002
|
|
},
|
|
"writtenOn": "2022-09-23T14:30:17Z",
|
|
"side": 1,
|
|
"message": "The kolla config file could be templated with a loop on tripleo_nova_libvirt_cinder_rbd_multi_config and I\u0027d do a rename:\n\n\u0027templates/nova_libvirt_init_secret.yaml.j2\u0027 --\u003e \u0027templates/nova_libvirt_init_secret_container_defs.yaml.j2\u0027\n\n\u0027files/nova_libvirt_init_secret.yaml\u0027 --\u003e \u0027templates/nova_libvirt_init_secret_kolla_config.yaml.j2\u0027\n\nIs that what you have in mind?",
|
|
"parentUuid": "6665789a_589ee905",
|
|
"revId": "6304aa0f86c5bfd2bbf1960db1cec1deae660618",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b4689fda_a9c646e9",
|
|
"filename": "tripleo_ansible/roles/tripleo_nova_libvirt/files/nova_libvirt_init_secret.yaml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 13,
|
|
"author": {
|
|
"id": 6926
|
|
},
|
|
"writtenOn": "2022-10-07T12:42:04Z",
|
|
"side": 1,
|
|
"message": "if that works for us, yes, somthing like that",
|
|
"parentUuid": "2f44c20d_c92f25e4",
|
|
"revId": "6304aa0f86c5bfd2bbf1960db1cec1deae660618",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f9631065_da805636",
|
|
"filename": "tripleo_ansible/roles/tripleo_nova_libvirt/files/nova_libvirt_init_secret.yaml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 13,
|
|
"author": {
|
|
"id": 18002
|
|
},
|
|
"writtenOn": "2022-10-07T19:59:36Z",
|
|
"side": 1,
|
|
"message": "I found I don\u0027t need to modify tripleo_nova_libvirt/files/nova_libvirt_init_secret.yaml as I had done prior to PS4 since tripleo_nova_libvirt/files/nova_virtsecretd.yaml starts virtsecretd. I just needed to let that happen before calling nova_libvirt_init_secret.sh since that script runs \u0027virsh secret-define\u0027 which requires virtsecretd to be running. Thus I did the reordering in tripleo_nova_libvirt/tasks/run.yml.\n\nI think I might be able to hand case where we create multiple virsh secrets by updating tripleo_nova_libvirt/templates/nova_libvirt_init_secret.yaml.j2 line 9. Thus, I\u0027ve restored tripleo_nova_libvirt/files/nova_libvirt_init_secret.yaml so that it\u0027s unchanged by this patch in PS4.",
|
|
"parentUuid": "b4689fda_a9c646e9",
|
|
"revId": "6304aa0f86c5bfd2bbf1960db1cec1deae660618",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |