Update patch set 10

Patch Set 10: Code-Review+1

(2 comments)

Patch-set: 10
Reviewer: Gerrit User 8449 <8449@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 4fb68fd7aec9ee4f1e8426f33a000e624844402a
Attention: {"person_ident":"Gerrit User 33080 \u003c33080@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8449\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 8449 \u003c8449@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8449\u003e replied on the change"}
This commit is contained in:
Gerrit User 8449 2023-10-17 06:31:34 +00:00 committed by Gerrit Code Review
parent 44e439f7e4
commit 5236b801dd
1 changed files with 38 additions and 0 deletions

View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "47612f1e_d0f367a5",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 10
},
"lineNbr": 0,
"author": {
"id": 8449
},
"writtenOn": "2023-10-17T06:31:34Z",
"side": 1,
"message": "lgtm, but before we merge did you please get a chance to sanity check that the RDO periodic minor update job is not broken by this (and the two other patches quickstart/extras)",
"revId": "149db5491338d8740d70a4c46ca0ce612bdf4c95",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "745c4692_c638f0be",
"filename": "roles/run-test/templates/toci_gate_test.sh.j2",
"patchSetId": 10
},
"lineNbr": 133,
"author": {
"id": 8449
},
"writtenOn": "2023-10-17T06:31:34Z",
"side": 1,
"message": "ack thanks for update.\n\nfor the record/benefit of other reviewers, this bit is likely to be removed when Mikolaj revisits this after this series is merged. we will try to remove the new release file added with https://code.engineering.redhat.com/gerrit/c/tripleo-environments/+/447281 (and referenced here line 136) and we will try to re-use the existing one with appropriate conditionals",
"revId": "149db5491338d8740d70a4c46ca0ce612bdf4c95",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}