Fixed yamlint violations

Change-Id: I7468ef9929cd6a7c0969bcd6befb320bfd671097

.ansible-lint

@@ -6,8 +6,6 @@ skip_list:
     - empty-string-compare  # https://github.com/ansible/ansible-lint/issues/457
     - role-name  # Role name run-test does not match ``^[a-z][a-z0-9_]+$`` pattern
     - risky-file-permissions  # File permissions unset or incorrect
-    # TODO(ssbarnea): Remove these in follow-ups
-    - yaml
 verbosity: 1
 mock_modules:
     - zuul_return

playbooks/deprecated/pre.yaml

@@ -1,6 +1,7 @@
+---
 - name: Deprecation warning
   hosts: all
-  gather_facts: no
+  gather_facts: false
   tasks:
     - name: Warn that the job is deprecated
       debug:

playbooks/nodepool-provider/pre.yaml

@@ -1,6 +1,7 @@
+---
 - name: Configure /etc/nodepool/provider for backwards compatibility
   hosts: all
-  gather_facts: no
+  gather_facts: false
   tasks:
     - name: Warn that /etc/nodepool/provider is deprecated
       debug:

playbooks/openstack-zuul-jobs/legacy/pre.yaml

@@ -1,5 +1,6 @@
+---
 - hosts: all
-  gather_facts: no
+  gather_facts: false
   tasks:
     - name: Set IP addresses for the nodes missing private IPs
       set_fact:

playbooks/tripleo-buildcontainers/docker.yaml

@@ -1,3 +1,4 @@
+---
 - hosts: all
   tasks:
     - name: Configure docker proxy
@@ -7,7 +8,7 @@
 
     - name: Set fact of docker upstream
       set_fact:
-        use_upstream_docker: False
+        use_upstream_docker: false
 
     - name: Install docker
       include_role:

playbooks/tripleo-buildcontainers/post.yaml

@@ -1,3 +1,4 @@
+---
 - hosts: primary
   tasks:
     - name: Run build containers post tasks

playbooks/tripleo-buildcontainers/pre.yaml

@@ -1,3 +1,4 @@
+---
 - hosts: all
   name: TripleO Setup Container Registry and repos mirror
   tasks:

playbooks/tripleo-buildcontainers/run.yaml

@@ -1,3 +1,4 @@
+---
 - hosts: all
   name: TripleO container image building job
   tasks:

playbooks/tripleo-buildimages/post.yaml

@@ -1,3 +1,4 @@
+---
 - hosts: primary
   tasks:
     - name: Run build-images role post tasks (collect logs)

playbooks/tripleo-buildimages/pre.yaml

@@ -1,3 +1,4 @@
+---
 - hosts: all
   name: TripleO image building job pre.yaml
   tasks:

playbooks/tripleo-buildimages/run-v3.yaml

@@ -1,3 +1,4 @@
+---
 - hosts: all
   tasks:
   - name: Run image build using the build-images role

playbooks/tripleo-ci/ceph.yaml

@@ -1,3 +1,4 @@
+---
 - hosts: subnodes
   name: Bootstrap subnodes - setup ceph-ansible /dev/loop3 /var/lib/ceph-osd.img
   tasks:

playbooks/tripleo-ci/post.yaml

@@ -1,3 +1,4 @@
+---
 - name: Write console log to localhost as fact zuul_console_json
   hosts: localhost
   tasks:
@@ -12,7 +13,7 @@
       file:
         path: "{{ ansible_user_dir }}/workspace/logs"
         state: directory
-        recurse: yes
+        recurse: true
 
     - name: Build report (content provider)
       include_role:

playbooks/tripleo-ci/pre.yaml

@@ -1,3 +1,4 @@
+---
 - hosts: all
   name: Common tasks for nodes preparation
   roles:

playbooks/tripleo-ci/run-provider.yml

@@ -1,4 +1,4 @@
-
+---
 - hosts: all
   tasks:
 

playbooks/tripleo-ci/run-v3.yaml

@@ -1,3 +1,4 @@
+---
 - hosts:
     - primary
   roles:

playbooks/tripleo-ci/run.yaml

@@ -1,3 +1,4 @@
+---
 - hosts:
     - primary
     - centos-7

roles/build-containers/defaults/main.yaml

@@ -1,3 +1,4 @@
+---
 push_registry_port: 8787
 push_registry: "127.0.0.1:{{ push_registry_port }}"
 push_containers: "false"

roles/build-containers/tasks/build-report.yaml

@@ -1,3 +1,4 @@
+---
 - name: Container build report
   block:
 
@@ -6,7 +7,7 @@
       become: true
       args:
         chdir: "{{ workspace }}"
-      ignore_errors: yes
+      ignore_errors: true
 
     - name: Set ci_branch for building containers check jobs
       include_tasks: set_ci_branch.yml
@@ -19,7 +20,7 @@
       fetch:
         src: "{{ openstack_git_root }}/{% if zuul_internal is defined %}openstack-{% endif %}tripleo-common/container-images/tripleo_containers.yaml"
         dest: "{{ zuul.executor.work_root }}/"
-        flat: yes
+        flat: true
 
     - name: Load list of containers expected to build
       include_vars:
@@ -49,7 +50,7 @@
       lineinfile:
         line: "{{ item }}"
         path: "{{ workspace }}/containers-expected.log"
-        create: yes
+        create: true
         state: present
       with_items: "{{ expected_containers }}"
 
@@ -97,4 +98,4 @@
         chdir: "{{ workspace }}"
       become: true
 
-  ignore_errors: yes
+  ignore_errors: true

roles/build-containers/tasks/main.yaml

@@ -74,7 +74,7 @@
     description: Dummy epel repository
     file: delorean_epel_dummy
     baseurl: https://download.fedoraproject.org/pub/epel/$releasever/$basearch/
-    enabled: no
+    enabled: false
   with_items:
     - epel
     - epel-modular
@@ -128,12 +128,12 @@
     src: templates/kolla-build.conf.j2
     dest: "{{ workspace }}/kolla-build.conf"
     mode: 0644
-    force: yes
+    force: true
 
 - name: Set container cli
   set_fact:
     container_cli: "{% if use_buildah|bool %}buildah{% else %}docker{% endif %}"
-    cacheable: yes
+    cacheable: true
 
 - name: Set config-file
   set_fact:
@@ -211,7 +211,7 @@
     src: templates/kolla-build.sh.j2
     dest: "{{ workspace }}/build_containers.sh"
     mode: 0777
-    force: yes
+    force: true
   when: use_kolla | default(true)
 
 - name: Generate tripleo building script
@@ -219,7 +219,7 @@
     src: templates/tripleo-build.sh.j2
     dest: "{{ workspace }}/build_containers.sh"
     mode: 0777
-    force: yes
+    force: true
   when: not use_kolla | default(true)
 
 
@@ -258,7 +258,7 @@
       vars:
         image: "{{ item }}"
       include: tag.yaml
-      static: no
+      static: false
       with_items: "{{ built_images.stdout_lines }}"
   become: true
 
@@ -298,6 +298,6 @@
       vars:
         image: "{{ item }}"
       include: provider_push.yaml
-      static: no
+      static: false
       with_items: "{{ built_images.stdout_lines }}"
   become: true

roles/build-containers/tasks/package_setup.yml

@@ -1,3 +1,4 @@
+---
 - name: Include OS distro version specific variables
   include_vars: "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml"
 

roles/build-containers/tasks/venv_setup.yml

@@ -1,3 +1,4 @@
+---
 - name: Make sure we have pip
   include_role:
     name: ensure-pip

roles/build-containers/templates/component_ci/compute_overcloud_containers.yaml

@@ -1,3 +1,4 @@
+---
 container_images:
   - imagename: docker.io/tripleomaster/centos-binary-nova-api:current-tripleo
     image_source: kolla

roles/build-containers/templates/component_ci/keystone_overcloud_containers.yaml

@@ -1,3 +1,4 @@
+---
 container_images:
   - imagename: docker.io/tripleomaster/centos-binary-keystone:current-tripleo
     image_source: kolla

roles/build-containers/vars/main.yaml

@@ -1,3 +1,4 @@
+---
 workspace: "{{ ansible_user_dir }}/workspace"
 
 # https://review.opendev.org/#/c/669471 - rhel8 kolla support

roles/common/tasks/main.yml

@@ -1,3 +1,4 @@
+---
 # In ansible 2.7 should be enough to add the option public: true to the calling include_role
 # for this role. This is the best workaround
 - name: Include the vars to be available for the playbook

roles/common/vars/main.yaml

@@ -1,3 +1,4 @@
+---
 workspace: "{{ ansible_user_dir }}/workspace"
 tripleo_root: "{{ ansible_user_dir }}/src/opendev.org/openstack"
 tripleo_ci_dir: "{{ ansible_user_dir }}/{{ zuul.projects['opendev.org/openstack/tripleo-ci'].src_dir }}"

roles/oooci-build-images/defaults/main.yaml

@@ -1,3 +1,4 @@
+---
 tripleo_image_source: https://images.rdoproject.org/CentOS-8-x86_64-GenericCloud.qcow2
 workspace: "{{ ansible_user_dir }}/workspace"
 openstack_git_root: "{{ ansible_user_dir }}/src/opendev.org/openstack"

roles/oooci-build-images/tasks/image_sanity.yaml

@@ -38,7 +38,7 @@
     chdir: "{{ workspace }}"
   register: files_missing
   changed_when: false
-  ignore_errors: True
+  ignore_errors: true
   loop: "{{ missing_dirs }}"
 
 - name: Show warning if missing files

roles/oooci-build-images/tasks/main.yaml

@@ -61,7 +61,7 @@
     src: templates/build-images.sh.j2
     dest: "{{ workspace }}/build_images.sh"
     mode: 0777
-    force: yes
+    force: true
 
 - name: Run build-images.sh
   args:

roles/oooci-build-images/tasks/pre.yaml

@@ -91,7 +91,7 @@
 # Workaround for https://bugs.launchpad.net/diskimage-builder/+bug/1745626
 # venv created with 'python3 -m venv' does not have activate_this.py
 # TODO(rfolco): Remove this workaround when bug #1745626 is fixed
-- name: Workaround for bug #1745626
+- name: "Workaround for bug #1745626"
   block:
     - name: Create temp venv w/ virtualenv command
       pip:
@@ -103,4 +103,4 @@
       copy:
         src: "{{ workspace }}/.tmp/bin/activate_this.py"
         dest: "{{ workspace }}/venv/bin/"
-        remote_src: yes
+        remote_src: true

roles/oooci-build-images/vars/centos-7.yaml

@@ -1,3 +1,4 @@
+---
 tripleo_image_source: https://images.rdoproject.org/CentOS-7-x86_64-GenericCloud.qcow2
 dib_yum_repo_conf:
   - /etc/yum.repos.d/CentOS*

roles/prepare-node/tasks/main.yaml

@@ -1,3 +1,4 @@
+---
 - name: Swap is essential as we are not meeting memory requirements
   vars:
     configure_swap_size: 8192
@@ -24,7 +25,7 @@
     path: /home/zuul/src/
     state: directory
     mode: u=rwX,g=rX,o=rX
-    recurse: yes
+    recurse: true
 
 - name: "set zull_dump"
   set_fact:

roles/run-test/tasks/main.yaml

@@ -1,8 +1,10 @@
+---
 - name: Set legacy log path
   include_role:
     name: set-zuul-log-path-fact
 
-- block:
+- when: featureset_override is defined and featureset_override
+  block:
     - name: Check overridable settings
       vars:
         allowed_overrides:
@@ -62,18 +64,17 @@
         src: templates/featureset-override.j2
         dest: "{{ tripleo_root }}/tripleo-ci/featureset-override.yaml"
         mode: 0755
-      force: yes
+        force: true
     - name: Include some extra for generating toci scripts
       set_fact:
         extra_vars: "--extra-vars @{{ tripleo_root }}/tripleo-ci/featureset-override.yaml"
-  when: featureset_override is defined and featureset_override
 
 - name: Generate role variable file
   template:
     src: templates/role-vars.j2
     dest: "{{ workspace }}/logs/role-vars.yaml"
     mode: 0755
-    force: yes
+    force: true
 - name: Include role variables to be passed to quickstart
   set_fact:
     role_vars: "--extra-vars @{{ workspace }}/logs/role-vars.yaml"
@@ -83,33 +84,33 @@
     src: templates/toci_gate_test.sh.j2
     dest: "{{ tripleo_root }}/tripleo-ci/toci_gate_test.sh"
     mode: 0755
-    force: yes
+    force: true
 
 - name: render toci_quickstart script
   template:
     src: templates/toci_quickstart.sh.j2
     dest: "{{ tripleo_root }}/tripleo-ci/toci_quickstart.sh"
     mode: 0755
-    force: yes
+    force: true
 
 - name: render common_vars script
   template:
     src: templates/common_vars.bash.j2
     dest: "{{ tripleo_root }}/tripleo-ci/scripts/common_vars.bash"
-    force: yes
+    force: true
 
 - name: render oooq_common_functions script
   template:
     src: templates/oooq_common_functions.sh.j2
     dest: "{{ tripleo_root }}/tripleo-ci/scripts/oooq_common_functions.sh"
-    force: yes
+    force: true
 
 - name: render ready releases.sh file
   copy:
     content: "{{ ready_releases_file }}"
     dest: "{{ workspace }}/logs/releases.sh"
     mode: 0644
-    force: yes
+    force: true
   when: ready_releases_file is defined
 
 - name: run toci_gate_test.sh

roles/tripleo-repos/meta/main.yml

@@ -1,3 +1,4 @@
+---
 galaxy_info:
   author: Alex Schultz
   description: Role to run tripleo-repos

roles/tripleo-repos/molecule/default/converge.yml

@@ -1,5 +1,4 @@
 ---
-
 - name: Converge
   hosts: all
   tasks:

scripts/website/tripleo-reviewday.yaml

@@ -1,3 +1,4 @@
+---
 projects:
   - name: os-apply-config
   - name: os-collect-config

test-environments/worker-config.yaml

@@ -1,3 +1,4 @@
+---
 # TODO(bnemec): Should these settings be moved to low-memory-usage.yaml
 # in tripleo-heat-templates?
 parameter_defaults:

toci-quickstart/config/testenv/multinode.yml

@@ -1,3 +1,4 @@
+---
 # TRIPLEO-CI environment settings
 cloudenv: "upstream"
 undercloud_user: "{{ lookup('env','USER') }}"

toci-quickstart/config/testenv/ovb-psi.yml

@@ -1,3 +1,4 @@
+---
 # This file contains settings that are specific to Psi
 # These settings will override the ovb default settings
 

toci-quickstart/config/testenv/ovb-rdocloud.yml

@@ -1,3 +1,4 @@
+---
 # This file contains settings that are specific to RDO Cloud.
 # These settings will override the ovb default settings
 

toci-quickstart/config/testenv/ovb-vexxhost.yml

@@ -1,3 +1,4 @@
+---
 # This file contains settings that are specific to Vexxhost
 # These settings will override the ovb default settings
 

zuul.d/periodic.yaml

@@ -1,3 +1,4 @@
+---
 - project-template:
     name: tripleo-periodic
     periodic: