openstack/tripleo-common
Code Issues Proposed changes

Don't mock mkdtemp

Browse Source 
As far as I can tell there's no reason to do this, and it breaks
the ability for NestedTempfile to clean up after the tests by
forcing the file to go to the system /tmp directory (which I'm
pretty sure is a security issue too...).  It's also causing some
weird errors in the gate so let's remove it.

Change-Id: I04f3f569ff904e002758098cfd90b5bbb31c6afc
Closes-Bug: 1714306
This commit is contained in:
Ben Nemec 2017-08-31 16:29:30 +00:00
parent 9becd05eb3
commit 0be202dcd1
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tripleo_common/tests/actions/test_logging_to_swift.py
View File

@ -126,15 +126,13 @@ class PrepareLogDownloadActionTest(base.TestCase):
self.ctx = mock.MagicMock()
@mock.patch('tripleo_common.utils.tarball.create_tarball')
@mock.patch('tempfile.mkdtemp')
def test_run_success(self, mock_mkdtemp, mock_create_tarball):
def test_run_success(self, mock_create_tarball):
get_object_mock_calls = [
mock.call('logging-container', lf) for lf in self.log_files
]
get_container_mock_calls = [
mock.call('logging-container')
]
mock_mkdtemp.return_value = '/tmp/test123'
action = logging_to_swift.PrepareLogDownloadAction(
'logging-container', 'downloads-container', 3600