openstack
/
tripleo-common
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(5 comments)

Patch-set: 3
This commit is contained in:
Gerrit User 8449 2016-02-26 10:51:30 +00:00 committed by Gerrit Code Review
parent d00785a351
commit 10d48c36bd
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9aed3d3a_d0f83ce8",
"filename": "scripts/upgrade-non-controller.sh",
"patchSetId": 3
},
"lineNbr": 19,
"author": {
"id": 8449
},
"writtenOn": "2016-02-26T10:51:30Z",
"side": 1,
"message": "why, I expect we will be documenting this at some point in tripleo-docs and would like to point at it",
"parentUuid": "9aed3d3a_cd5c2728",
"revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9aed3d3a_6d4cfb70",
@ -34,6 +52,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9aed3d3a_10dbc47d",
"filename": "scripts/upgrade-non-controller.sh",
"patchSetId": 3
},
"lineNbr": 21,
"author": {
"id": 8449
},
"writtenOn": "2016-02-26T10:51:30Z",
"side": 1,
"message": "Done",
"parentUuid": "9aed3d3a_6d4cfb70",
"revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9aed3d3a_0d93af5c",
@ -69,6 +105,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9aed3d3a_10f744d4",
"filename": "scripts/upgrade-non-controller.sh",
"patchSetId": 3
},
"lineNbr": 29,
"author": {
"id": 8449
},
"writtenOn": "2016-02-26T10:51:30Z",
"side": 1,
"message": "No. the idea is that we will deliver the (non-controller) nodes upgrade script to /root/tripleo_upgrade_node.sh as part of the controller upgrade workflow as in that patch you refer to.\n\nThe (latest) upgrades workflow is that the operator will invoke those scripts, after the controllers are upgraded, for each non-controller node, using this script, here.",
"parentUuid": "9aed3d3a_0d93af5c",
"revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9aed3d3a_8d7e9fe2",
@ -86,6 +140,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9aed3d3a_f0b460f3",
"filename": "scripts/upgrade-non-controller.sh",
"patchSetId": 3
},
"lineNbr": 70,
"author": {
"id": 8449
},
"writtenOn": "2016-02-26T10:51:30Z",
"side": 1,
"message": "I expect doing that, and then revising every invocation of \u0027echo\u0027 in the various functions here would stand up by itself as a follow on patch. Trying to add it here would be messy and not make sense imo.",
"parentUuid": "9aed3d3a_8d7e9fe2",
"revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9aed3d3a_4de3f7a3",
@ -120,6 +192,24 @@
"revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9aed3d3a_f082a0ff",
"filename": "scripts/upgrade-non-controller.sh",
"patchSetId": 3
},
"lineNbr": 76,
"author": {
"id": 8449
},
"writtenOn": "2016-02-26T10:51:30Z",
"side": 1,
"message": "no, i think it should fail and they will know why. I thought about adding a \u0027function source_stackrc like we have in tripleo.sh but I really dont want _anything_ extra here. Bash gets very messy very quickly and I would like to keep this as short and simple as possible.",
"parentUuid": "9aed3d3a_4de3f7a3",
"revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}