openstack/tripleo-common
Code Issues Proposed changes

Remove tftp healthcheck from ironic-pxe image

Browse Source 
This is failing downstream because the installed curl-minimal does not
have tftp support. This healthcheck likely doesn't add much value
since dnsmasq is a self-contained tool which will be bound to the port
if it is running.

The healthcheck for dnsmasq as a DHCP server has already been
removed[1].

The alternative to removing this check is to ensure the 'curl' package
is installed instead of 'curl-minimal'.

[1] https://review.opendev.org/c/openstack/tripleo-common/+/799946

Change-Id: I126b997608edb217b0fbf40f4228d0f0af689b0e
This commit is contained in:
Steve Baker 2022-03-01 14:15:29 +13:00
parent 5d2538a203
commit 1a73f9561f
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
healthcheck/ironic-pxe
View File

@ -8,9 +8,6 @@ if grep "/httpd " /run_command 2>/dev/null ; then
protocol=http protocol=http
path= path=
else else
bind_host=$(hiera ironic::pxe::tftp_bind_host -c /etc/puppet/hiera.yaml) exit 0
bind_port=69
protocol=tftp
path=map-file
fi fi
healthcheck_curl ${protocol}://${bind_host}:${bind_port}/${path} healthcheck_curl ${protocol}://${bind_host}:${bind_port}/${path}